* [PATCH] serial: 8250_mtk: Fix uart_get_baud_rate warning
@ 2020-11-02 12:07 Claire Chang
0 siblings, 0 replies; only message in thread
From: Claire Chang @ 2020-11-02 12:07 UTC (permalink / raw)
To: gregkh, jirislaby, andriy.shevchenko
Cc: eddie.huang, hsinyi, Sergey.Semin, changqi.hu, linux-serial,
linux-arm-kernel, linux-mediatek, linux-kernel, Claire Chang
Mediatek 8250 port supports speed higher than uartclk / 16. If the baud
rates in both the new and the old termios setting are higher than
uartclk / 16, the WARN_ON in uart_get_baud_rate() will be triggered.
Passing NULL as the old termios so uart_get_baud_rate() will use
uartclk / 16 - 1 as the new baud rate which will be replaced by the
original baud rate later by tty_termios_encode_baud_rate() in
mtk8250_set_termios().
Fixes: 551e553f0d4a ("serial: 8250_mtk: Fix high-speed baud rates clamping")
Signed-off-by: Claire Chang <tientzu@chromium.org>
---
drivers/tty/serial/8250/8250_mtk.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/tty/serial/8250/8250_mtk.c b/drivers/tty/serial/8250/8250_mtk.c
index 41f4120abdf2..fa876e2c13e5 100644
--- a/drivers/tty/serial/8250/8250_mtk.c
+++ b/drivers/tty/serial/8250/8250_mtk.c
@@ -317,7 +317,7 @@ mtk8250_set_termios(struct uart_port *port, struct ktermios *termios,
*/
baud = tty_termios_baud_rate(termios);
- serial8250_do_set_termios(port, termios, old);
+ serial8250_do_set_termios(port, termios, NULL);
tty_termios_encode_baud_rate(termios, baud, baud);
--
2.29.1.341.ge80a0c044ae-goog
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2020-11-02 12:07 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-02 12:07 [PATCH] serial: 8250_mtk: Fix uart_get_baud_rate warning Claire Chang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).