[PATCH v2 1/2] misc: c2port: core: Make copying name from userspace more secure

* [PATCH v2 1/2] misc: c2port: core: Make copying name from userspace more secure
@ 2020-11-02 14:20 Lee Jones
  2020-11-02 14:20 ` [PATCH v2 2/2] misc: ocxl: config: Rename function attribute description Lee Jones
  0 siblings, 1 reply; 4+ messages in thread
From: Lee Jones @ 2020-11-02 14:20 UTC (permalink / raw)
  To: gregkh, arnd
  Cc: linux-kernel, Lee Jones, Rodolfo Giometti, Eurotech S.p.A,
	David Laight, Geert Uytterhoeven

Currently the 'c2dev' device data is not initialised when it's
allocated.  There maybe an issue when using strncpy() to populate the
'name' attribute since a NUL terminator may not be provided in all
use-cases.  To prevent such a failing, let's ensure the 'c2dev'
device data area is fully zeroed out on allocation.

Cc: Rodolfo Giometti <giometti@enneenne.com>
Cc: "Eurotech S.p.A" <info@eurotech.it>
Cc: David Laight <David.Laight@aculab.com>
Reported-by: Geert Uytterhoeven <geert+renesas@glider.be>
Acked-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
 drivers/misc/c2port/core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/misc/c2port/core.c b/drivers/misc/c2port/core.c
index 80d87e8a0bea9..fb9a1b49ff6de 100644
--- a/drivers/misc/c2port/core.c
+++ b/drivers/misc/c2port/core.c
@@ -899,7 +899,7 @@ struct c2port_device *c2port_device_register(char *name,
 		unlikely(!ops->c2d_get) || unlikely(!ops->c2d_set))
 		return ERR_PTR(-EINVAL);
 
-	c2dev = kmalloc(sizeof(struct c2port_device), GFP_KERNEL);
+	c2dev = kzalloc(sizeof(struct c2port_device), GFP_KERNEL);
 	if (unlikely(!c2dev))
 		return ERR_PTR(-ENOMEM);
 
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread