From: Krzysztof Kozlowski <krzk@kernel.org>
To: Yu Kuai <yukuai3@huawei.com>
Cc: thierry.reding@gmail.com, jonathanh@nvidia.com,
mperttunen@nvidia.com, tomeu.vizoso@collabora.com,
linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org,
yi.zhang@huawei.com
Subject: Re: [PATCH] memory: tegra: add missing put_devcie() call in tegra_emc_probe()
Date: Mon, 2 Nov 2020 19:52:16 +0100 [thread overview]
Message-ID: <20201102185216.GB13405@kozik-lap> (raw)
In-Reply-To: <20201031105355.2303794-1-yukuai3@huawei.com>
On Sat, Oct 31, 2020 at 06:53:55PM +0800, Yu Kuai wrote:
> if of_find_device_by_node() succeed, tegra_emc_probe() doesn't have a
> corresponding put_device(). Thus add jump target to fix the exception
> handling for this function implementation.
Please fix the title in subject and reword, it's not possible to
understand it. You are fixing here error paths, so for example:
"The reference to device obtained with of_find_device_by_node() should
be dropped. Add missing put_device() calls in probe error paths.
>
> Fixes: 73a7f0a90641("memory: tegra: Add EMC (external memory controller) driver")
> Signed-off-by: Yu Kuai <yukuai3@huawei.com>
> ---
> drivers/memory/tegra/tegra124-emc.c | 19 +++++++++++++------
> 1 file changed, 13 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/memory/tegra/tegra124-emc.c b/drivers/memory/tegra/tegra124-emc.c
> index 76ace42a688a..831dfca0804c 100644
> --- a/drivers/memory/tegra/tegra124-emc.c
> +++ b/drivers/memory/tegra/tegra124-emc.c
> @@ -1207,8 +1207,10 @@ static int tegra_emc_probe(struct platform_device *pdev)
> return -ENOENT;
>
> emc->mc = platform_get_drvdata(mc);
> - if (!emc->mc)
> - return -EPROBE_DEFER;
> + if (!emc->mc) {
> + err = -EPROBE_DEFER;
> + goto put_device;
> + }
>
> ram_code = tegra_read_ram_code();
>
> @@ -1217,25 +1219,27 @@ static int tegra_emc_probe(struct platform_device *pdev)
> dev_err(&pdev->dev,
> "no memory timings for RAM code %u found in DT\n",
> ram_code);
> - return -ENOENT;
> + err = -ENOENT;
> + goto put_device;
> }
>
> err = tegra_emc_load_timings_from_dt(emc, np);
> of_node_put(np);
> if (err)
> - return err;
> + goto put_device;
>
> if (emc->num_timings == 0) {
> dev_err(&pdev->dev,
> "no memory timings for RAM code %u registered\n",
> ram_code);
> - return -ENOENT;
> + err = -ENOENT;
> + goto put_device;
> }
>
> err = emc_init(emc);
> if (err) {
> dev_err(&pdev->dev, "EMC initialization failed: %d\n", err);
> - return err;
> + goto put_device;
> }
>
> platform_set_drvdata(pdev, emc);
> @@ -1244,6 +1248,9 @@ static int tegra_emc_probe(struct platform_device *pdev)
> emc_debugfs_init(&pdev->dev, emc);
>
> return 0;
Line break
> +put_device:
> + put_device(&mc->dev);
Line break
Best regards,
Krzysztof
next prev parent reply other threads:[~2020-11-02 18:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-31 10:53 [PATCH] memory: tegra: add missing put_devcie() call in tegra_emc_probe() Yu Kuai
2020-11-02 18:52 ` Krzysztof Kozlowski [this message]
2020-11-09 13:28 ` [PATCH V2] memory: tegra: add missing put_devcie() call in error path of tegra_emc_probe() Yu Kuai
2020-11-09 16:41 ` Krzysztof Kozlowski
2020-11-10 1:33 ` [PATCH V3] memory: tegra: add missing put_device() " Yu Kuai
2020-11-10 15:21 ` Krzysztof Kozlowski
2020-11-11 1:11 ` yukuai (C)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201102185216.GB13405@kozik-lap \
--to=krzk@kernel.org \
--cc=jonathanh@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mperttunen@nvidia.com \
--cc=thierry.reding@gmail.com \
--cc=tomeu.vizoso@collabora.com \
--cc=yi.zhang@huawei.com \
--cc=yukuai3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).