linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Yu Kuai <yukuai3@huawei.com>
Cc: thierry.reding@gmail.com, jonathanh@nvidia.com,
	madalin.bucur@nxp.com, davem@davemloft.net, kuba@kernel.org,
	mperttunen@nvidia.com, tomeu.vizoso@collabora.com,
	linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org,
	netdev@vger.kernel.org, yi.zhang@huawei.com
Subject: Re: [PATCH V2] memory: tegra: add missing put_devcie() call in error path of tegra_emc_probe()
Date: Mon, 9 Nov 2020 17:41:54 +0100	[thread overview]
Message-ID: <20201109164154.GA211123@kozik-lap> (raw)
In-Reply-To: <20201109132847.1738010-1-yukuai3@huawei.com>

On Mon, Nov 09, 2020 at 09:28:47PM +0800, Yu Kuai wrote:
> The reference to device obtained with of_find_device_by_node() should
> be dropped. Thus add jump target to fix the exception handling for this
> function implementation.

You still need to correct the typo devcie->device in subject, as in v1.

> 
> Fixes: 73a7f0a90641("memory: tegra: Add EMC (external memory controller) driver")
> Signed-off-by: Yu Kuai <yukuai3@huawei.com>
> ---
>  drivers/memory/tegra/tegra124-emc.c           | 21 +++++++++++++------
>  .../net/ethernet/freescale/fman/fman_port.c   |  3 +--

Changes in net are not related, please split... although actually I
think the issue is already fixed by 1f1997eb44b1 ("memory: tegra: Add
and use devm_tegra_memory_controller_get()").

Best regards,
Krzysztof


  reply	other threads:[~2020-11-09 16:42 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-31 10:53 [PATCH] memory: tegra: add missing put_devcie() call in tegra_emc_probe() Yu Kuai
2020-11-02 18:52 ` Krzysztof Kozlowski
2020-11-09 13:28   ` [PATCH V2] memory: tegra: add missing put_devcie() call in error path of tegra_emc_probe() Yu Kuai
2020-11-09 16:41     ` Krzysztof Kozlowski [this message]
2020-11-10  1:33       ` [PATCH V3] memory: tegra: add missing put_device() " Yu Kuai
2020-11-10 15:21         ` Krzysztof Kozlowski
2020-11-11  1:11           ` yukuai (C)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201109164154.GA211123@kozik-lap \
    --to=krzk@kernel.org \
    --cc=davem@davemloft.net \
    --cc=jonathanh@nvidia.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=madalin.bucur@nxp.com \
    --cc=mperttunen@nvidia.com \
    --cc=netdev@vger.kernel.org \
    --cc=thierry.reding@gmail.com \
    --cc=tomeu.vizoso@collabora.com \
    --cc=yi.zhang@huawei.com \
    --cc=yukuai3@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).