* [PATCH] mfd: htc-i2cpld: Add the missed i2c_put_adapter() in htcpld_register_chip_i2c()
@ 2020-11-04 6:31 Jing Xiangfeng
[not found] ` <ec8f256f-d796-1311-1faa-443e33631ced@web.de>
0 siblings, 1 reply; 2+ messages in thread
From: Jing Xiangfeng @ 2020-11-04 6:31 UTC (permalink / raw)
To: lee.jones; +Cc: linux-kernel, jingxiangfeng
htcpld_register_chip_i2c() misses to call i2c_put_adapter() in an error
path. Add the missed function call to fix it.
Signed-off-by: Jing Xiangfeng <jingxiangfeng@huawei.com>
---
drivers/mfd/htc-i2cpld.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/mfd/htc-i2cpld.c b/drivers/mfd/htc-i2cpld.c
index 247f9849e54a..417b0355d904 100644
--- a/drivers/mfd/htc-i2cpld.c
+++ b/drivers/mfd/htc-i2cpld.c
@@ -346,6 +346,7 @@ static int htcpld_register_chip_i2c(
if (!i2c_check_functionality(adapter, I2C_FUNC_SMBUS_READ_BYTE_DATA)) {
dev_warn(dev, "i2c adapter %d non-functional\n",
pdata->i2c_adapter_id);
+ i2c_put_adapter(adapter);
return -EINVAL;
}
@@ -360,6 +361,7 @@ static int htcpld_register_chip_i2c(
/* I2C device registration failed, contineu with the next */
dev_warn(dev, "Unable to add I2C device for 0x%x\n",
plat_chip_data->addr);
+ i2c_put_adapter(adapter);
return PTR_ERR(client);
}
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] mfd: htc-i2cpld: Add the missed i2c_put_adapter() in htcpld_register_chip_i2c()
[not found] ` <ec8f256f-d796-1311-1faa-443e33631ced@web.de>
@ 2020-11-06 0:54 ` Jing Xiangfeng
0 siblings, 0 replies; 2+ messages in thread
From: Jing Xiangfeng @ 2020-11-06 0:54 UTC (permalink / raw)
To: Markus Elfring, Lee Jones; +Cc: linux-kernel, kernel-janitors
On 2020/11/4 14:50, Markus Elfring wrote:
>> htcpld_register_chip_i2c() misses to call i2c_put_adapter() in an error
>> path. Add the missed function call to fix it.
> Would you like to add the tag “Fixes”?
OK, I'll send a v2 with it.
Thanks
>
> Regards,
> Markus
> .
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-11-06 0:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-04 6:31 [PATCH] mfd: htc-i2cpld: Add the missed i2c_put_adapter() in htcpld_register_chip_i2c() Jing Xiangfeng
[not found] ` <ec8f256f-d796-1311-1faa-443e33631ced@web.de>
2020-11-06 0:54 ` Jing Xiangfeng
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).