From: Johan Hovold <johan@kernel.org>
To: Davidlohr Bueso <dave@stgolabs.net>
Cc: johan@kernel.org, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org, Davidlohr Bueso <dbueso@suse.de>
Subject: Re: [PATCH] usb/mos7720: process deferred urbs in a workqueue
Date: Wed, 4 Nov 2020 12:06:57 +0100 [thread overview]
Message-ID: <20201104110657.GW4085@localhost> (raw)
In-Reply-To: <20201103204014.3ue37owcras6cx7p@linux-p48b.lan>
On Tue, Nov 03, 2020 at 12:40:14PM -0800, Davidlohr Bueso wrote:
> On Mon, 02 Nov 2020, Bueso wrote:
>
> >There is
> >also no need anymore for atomic allocations.
>
> Bleh this is a brain fart - obviously not true as usb_submit_urb() is
> called under mos_parport->listlock. I'll send a v2 unless you have
> any objections.
The conversion looks good to me otherwise; it's not making this parport
mess any worse than it already is...
But please try to be a bit more stringent when updating the comments and
printk messages, for example, "runs *from* a workqueue", "schedule a
*worker*" or "queue a work item", etc.
Johan
next prev parent reply other threads:[~2020-11-04 11:07 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-02 21:14 [PATCH] usb/mos7720: process deferred urbs in a workqueue Davidlohr Bueso
2020-11-03 20:40 ` Davidlohr Bueso
2020-11-04 11:06 ` Johan Hovold [this message]
2020-11-04 16:25 ` Johan Hovold
2020-11-05 0:13 ` Davidlohr Bueso
2020-11-05 8:25 ` Johan Hovold
2020-11-06 6:17 ` Davidlohr Bueso
2020-11-09 9:22 ` Oliver Neukum
2020-11-09 19:14 ` Davidlohr Bueso
2020-11-13 9:14 ` Johan Hovold
2020-11-14 4:27 ` [PATCH] USB: serial: mos7720: defer state restore to " Davidlohr Bueso
2020-11-16 17:09 ` Johan Hovold
2020-11-16 22:31 ` Davidlohr Bueso
2020-11-17 16:28 ` Johan Hovold
2020-11-17 16:48 ` [PATCH v2] " Davidlohr Bueso
2020-11-18 10:11 ` Johan Hovold
2020-11-20 4:53 ` [PATCH v3] " Davidlohr Bueso
2020-11-20 9:37 ` Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201104110657.GW4085@localhost \
--to=johan@kernel.org \
--cc=dave@stgolabs.net \
--cc=dbueso@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).