* [PATCH -next] dpaa_eth: use false and true for bool variables
@ 2020-11-03 12:05 Zou Wei
2020-11-03 12:13 ` Madalin Bucur
0 siblings, 1 reply; 3+ messages in thread
From: Zou Wei @ 2020-11-03 12:05 UTC (permalink / raw)
To: madalin.bucur, davem, kuba; +Cc: netdev, linux-kernel, Zou Wei
Fix coccicheck warnings:
./dpaa_eth.c:2549:2-22: WARNING: Assignment of 0/1 to bool variable
./dpaa_eth.c:2562:2-22: WARNING: Assignment of 0/1 to bool variable
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zou Wei <zou_wei@huawei.com>
---
drivers/net/ethernet/freescale/dpaa/dpaa_eth.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c b/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c
index d9c2859..31407c1 100644
--- a/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c
+++ b/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c
@@ -2546,7 +2546,7 @@ static void dpaa_eth_napi_enable(struct dpaa_priv *priv)
for_each_online_cpu(i) {
percpu_priv = per_cpu_ptr(priv->percpu_priv, i);
- percpu_priv->np.down = 0;
+ percpu_priv->np.down = false;
napi_enable(&percpu_priv->np.napi);
}
}
@@ -2559,7 +2559,7 @@ static void dpaa_eth_napi_disable(struct dpaa_priv *priv)
for_each_online_cpu(i) {
percpu_priv = per_cpu_ptr(priv->percpu_priv, i);
- percpu_priv->np.down = 1;
+ percpu_priv->np.down = true;
napi_disable(&percpu_priv->np.napi);
}
}
--
2.6.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* RE: [PATCH -next] dpaa_eth: use false and true for bool variables
2020-11-03 12:05 [PATCH -next] dpaa_eth: use false and true for bool variables Zou Wei
@ 2020-11-03 12:13 ` Madalin Bucur
2020-11-05 1:25 ` Jakub Kicinski
0 siblings, 1 reply; 3+ messages in thread
From: Madalin Bucur @ 2020-11-03 12:13 UTC (permalink / raw)
To: Zou Wei, davem, kuba; +Cc: netdev, linux-kernel
> -----Original Message-----
> From: Zou Wei <zou_wei@huawei.com>
> Sent: 03 November 2020 14:05
> To: Madalin Bucur <madalin.bucur@nxp.com>; davem@davemloft.net;
> kuba@kernel.org
> Cc: netdev@vger.kernel.org; linux-kernel@vger.kernel.org; Zou Wei
> <zou_wei@huawei.com>
> Subject: [PATCH -next] dpaa_eth: use false and true for bool variables
>
> Fix coccicheck warnings:
>
> ./dpaa_eth.c:2549:2-22: WARNING: Assignment of 0/1 to bool variable
> ./dpaa_eth.c:2562:2-22: WARNING: Assignment of 0/1 to bool variable
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Zou Wei <zou_wei@huawei.com>
> ---
> drivers/net/ethernet/freescale/dpaa/dpaa_eth.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c
> b/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c
> index d9c2859..31407c1 100644
> --- a/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c
> +++ b/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c
> @@ -2546,7 +2546,7 @@ static void dpaa_eth_napi_enable(struct dpaa_priv
> *priv)
> for_each_online_cpu(i) {
> percpu_priv = per_cpu_ptr(priv->percpu_priv, i);
>
> - percpu_priv->np.down = 0;
> + percpu_priv->np.down = false;
> napi_enable(&percpu_priv->np.napi);
> }
> }
> @@ -2559,7 +2559,7 @@ static void dpaa_eth_napi_disable(struct dpaa_priv
> *priv)
> for_each_online_cpu(i) {
> percpu_priv = per_cpu_ptr(priv->percpu_priv, i);
>
> - percpu_priv->np.down = 1;
> + percpu_priv->np.down = true;
> napi_disable(&percpu_priv->np.napi);
> }
> }
> --
> 2.6.2
Acked-by: Madalin Bucur <madalin.bucur@oss.nxp.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH -next] dpaa_eth: use false and true for bool variables
2020-11-03 12:13 ` Madalin Bucur
@ 2020-11-05 1:25 ` Jakub Kicinski
0 siblings, 0 replies; 3+ messages in thread
From: Jakub Kicinski @ 2020-11-05 1:25 UTC (permalink / raw)
To: Madalin Bucur; +Cc: Zou Wei, davem, netdev, linux-kernel
On Tue, 3 Nov 2020 12:13:29 +0000 Madalin Bucur wrote:
> > Fix coccicheck warnings:
> >
> > ./dpaa_eth.c:2549:2-22: WARNING: Assignment of 0/1 to bool variable
> > ./dpaa_eth.c:2562:2-22: WARNING: Assignment of 0/1 to bool variable
> >
> > Reported-by: Hulk Robot <hulkci@huawei.com>
> > Signed-off-by: Zou Wei <zou_wei@huawei.com>
>
> Acked-by: Madalin Bucur <madalin.bucur@oss.nxp.com>
Applied, thanks!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-11-05 1:25 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-03 12:05 [PATCH -next] dpaa_eth: use false and true for bool variables Zou Wei
2020-11-03 12:13 ` Madalin Bucur
2020-11-05 1:25 ` Jakub Kicinski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).