From: Vladimir Oltean <olteanv@gmail.com>
To: Ioana Ciornei <ciorneiioana@gmail.com>
Cc: Andrew Lunn <andrew@lunn.ch>,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
Florian Fainelli <f.fainelli@gmail.com>,
Jakub Kicinski <kuba@kernel.org>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Ioana Ciornei <ioana.ciornei@nxp.com>,
Antoine Tenart <atenart@kernel.org>
Subject: Re: [PATCH net-next v2 08/19] net: phy: mscc: remove the use of .ack_interrupt()
Date: Thu, 5 Nov 2020 02:07:45 +0200 [thread overview]
Message-ID: <20201105000745.2kynhpv5x6ukjvi3@skbuf> (raw)
In-Reply-To: <20201101125114.1316879-9-ciorneiioana@gmail.com>
On Sun, Nov 01, 2020 at 02:51:03PM +0200, Ioana Ciornei wrote:
> From: Ioana Ciornei <ioana.ciornei@nxp.com>
>
> In preparation of removing the .ack_interrupt() callback, we must replace
> its occurrences (aka phy_clear_interrupt), from the 2 places where it is
> called from (phy_enable_interrupts and phy_disable_interrupts), with
> equivalent functionality.
>
> This means that clearing interrupts now becomes something that the PHY
> driver is responsible of doing, before enabling interrupts and after
> clearing them. Make this driver follow the new contract.
>
> Cc: Antoine Tenart <atenart@kernel.org>
> Signed-off-by: Ioana Ciornei <ioana.ciornei@nxp.com>
> ---
Tested-by: Vladimir Oltean <olteanv@gmail.com> # VSC8514
next prev parent reply other threads:[~2020-11-05 0:07 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-01 12:50 [PATCH net-next v2 00/19] net: phy: add support for shared interrupts (part 1) Ioana Ciornei
2020-11-01 12:50 ` [PATCH net-next v2 01/19] net: phy: export phy_error and phy_trigger_machine Ioana Ciornei
2020-11-01 12:50 ` [PATCH net-next v2 02/19] net: phy: add a shutdown procedure Ioana Ciornei
2023-08-03 18:16 ` Uwe Kleine-König
2023-08-03 18:24 ` Florian Fainelli
2023-08-03 18:49 ` Russell King (Oracle)
2020-11-01 12:50 ` [PATCH net-next v2 03/19] net: phy: make .ack_interrupt() optional Ioana Ciornei
2020-11-01 12:50 ` [PATCH net-next v2 04/19] net: phy: at803x: implement generic .handle_interrupt() callback Ioana Ciornei
2020-11-04 18:09 ` Oleksij Rempel
2020-11-01 12:51 ` [PATCH net-next v2 05/19] net: phy: at803x: remove the use of .ack_interrupt() Ioana Ciornei
2020-11-04 18:09 ` Oleksij Rempel
2020-11-01 12:51 ` [PATCH net-next v2 06/19] net: phy: mscc: use phy_trigger_machine() to notify link change Ioana Ciornei
2020-11-05 0:10 ` Vladimir Oltean
2020-11-01 12:51 ` [PATCH net-next v2 07/19] net: phy: mscc: implement generic .handle_interrupt() callback Ioana Ciornei
2020-11-05 0:08 ` Vladimir Oltean
2020-11-01 12:51 ` [PATCH net-next v2 08/19] net: phy: mscc: remove the use of .ack_interrupt() Ioana Ciornei
2020-11-05 0:07 ` Vladimir Oltean [this message]
2020-11-01 12:51 ` [PATCH net-next v2 09/19] net: phy: aquantia: implement generic .handle_interrupt() callback Ioana Ciornei
2020-11-01 12:51 ` [PATCH net-next v2 10/19] net: phy: aquantia: remove the use of .ack_interrupt() Ioana Ciornei
2020-11-01 12:51 ` [PATCH net-next v2 11/19] net: phy: broadcom: implement generic .handle_interrupt() callback Ioana Ciornei
2020-11-01 12:51 ` [PATCH net-next v2 12/19] net: phy: broadcom: remove use of ack_interrupt() Ioana Ciornei
2020-11-01 12:51 ` [PATCH net-next v2 13/19] net: phy: cicada: implement the generic .handle_interrupt() callback Ioana Ciornei
2020-11-01 12:51 ` [PATCH net-next v2 14/19] net: phy: cicada: remove the use of .ack_interrupt() Ioana Ciornei
2020-11-01 12:51 ` [PATCH net-next v2 15/19] net: phy: davicom: implement generic .handle_interrupt() calback Ioana Ciornei
2020-11-01 12:51 ` [PATCH net-next v2 16/19] net: phy: davicom: remove the use of .ack_interrupt() Ioana Ciornei
2020-11-01 12:51 ` [PATCH net-next v2 17/19] net: phy: add genphy_handle_interrupt_no_ack() Ioana Ciornei
2020-11-01 12:51 ` [PATCH net-next v2 18/19] net: phy: realtek: implement generic .handle_interrupt() callback Ioana Ciornei
2020-11-01 12:51 ` [PATCH net-next v2 19/19] net: phy: realtek: remove the use of .ack_interrupt() Ioana Ciornei
2020-11-03 16:44 ` [PATCH net-next v2 00/19] net: phy: add support for shared interrupts (part 1) Andrew Lunn
2020-11-03 22:53 ` Michael Walle
2020-11-06 0:36 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201105000745.2kynhpv5x6ukjvi3@skbuf \
--to=olteanv@gmail.com \
--cc=andrew@lunn.ch \
--cc=atenart@kernel.org \
--cc=ciorneiioana@gmail.com \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=ioana.ciornei@nxp.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).