linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Lee Jones <lee.jones@linaro.org>
To: lee.jones@linaro.org
Cc: linux-kernel@vger.kernel.org, Andrzej Hajda <a.hajda@samsung.com>,
	Neil Armstrong <narmstrong@baylibre.com>,
	Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
	Jonas Karlman <jonas@kwiboo.se>,
	Jernej Skrabec <jernej.skrabec@siol.net>,
	David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
	Jason Yan <yanaijie@huawei.com>, Sam Ravnborg <sam@ravnborg.org>,
	Jingoo Han <jg1.han@samsung.com>,
	dri-devel@lists.freedesktop.org
Subject: [PATCH 12/19] gpu: drm: bridge: analogix: analogix_dp_reg: Remove unused function 'analogix_dp_write_byte_to_dpcd'
Date: Thu,  5 Nov 2020 14:45:10 +0000	[thread overview]
Message-ID: <20201105144517.1826692-13-lee.jones@linaro.org> (raw)
In-Reply-To: <20201105144517.1826692-1-lee.jones@linaro.org>

Fixes the following W=1 kernel build warning(s):

 drivers/gpu/drm/bridge/analogix/analogix_dp_reg.c:571:5: warning: no previous prototype for ‘analogix_dp_write_byte_to_dpcd’ [-Wmissing-prototypes]

Cc: Andrzej Hajda <a.hajda@samsung.com>
Cc: Neil Armstrong <narmstrong@baylibre.com>
Cc: Laurent Pinchart <Laurent.pinchart@ideasonboard.com>
Cc: Jonas Karlman <jonas@kwiboo.se>
Cc: Jernej Skrabec <jernej.skrabec@siol.net>
Cc: David Airlie <airlied@linux.ie>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: Jason Yan <yanaijie@huawei.com>
Cc: Sam Ravnborg <sam@ravnborg.org>
Cc: Jingoo Han <jg1.han@samsung.com>
Cc: dri-devel@lists.freedesktop.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
 .../gpu/drm/bridge/analogix/analogix_dp_reg.c | 44 -------------------
 1 file changed, 44 deletions(-)

diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_reg.c b/drivers/gpu/drm/bridge/analogix/analogix_dp_reg.c
index fafb4b492ea04..9ce45c757f8c8 100644
--- a/drivers/gpu/drm/bridge/analogix/analogix_dp_reg.c
+++ b/drivers/gpu/drm/bridge/analogix/analogix_dp_reg.c
@@ -568,50 +568,6 @@ static int analogix_dp_start_aux_transaction(struct analogix_dp_device *dp)
 	return retval;
 }
 
-int analogix_dp_write_byte_to_dpcd(struct analogix_dp_device *dp,
-				   unsigned int reg_addr,
-				   unsigned char data)
-{
-	u32 reg;
-	int i;
-	int retval;
-
-	for (i = 0; i < 3; i++) {
-		/* Clear AUX CH data buffer */
-		reg = BUF_CLR;
-		writel(reg, dp->reg_base + ANALOGIX_DP_BUFFER_DATA_CTL);
-
-		/* Select DPCD device address */
-		reg = AUX_ADDR_7_0(reg_addr);
-		writel(reg, dp->reg_base + ANALOGIX_DP_AUX_ADDR_7_0);
-		reg = AUX_ADDR_15_8(reg_addr);
-		writel(reg, dp->reg_base + ANALOGIX_DP_AUX_ADDR_15_8);
-		reg = AUX_ADDR_19_16(reg_addr);
-		writel(reg, dp->reg_base + ANALOGIX_DP_AUX_ADDR_19_16);
-
-		/* Write data buffer */
-		reg = (unsigned int)data;
-		writel(reg, dp->reg_base + ANALOGIX_DP_BUF_DATA_0);
-
-		/*
-		 * Set DisplayPort transaction and write 1 byte
-		 * If bit 3 is 1, DisplayPort transaction.
-		 * If Bit 3 is 0, I2C transaction.
-		 */
-		reg = AUX_TX_COMM_DP_TRANSACTION | AUX_TX_COMM_WRITE;
-		writel(reg, dp->reg_base + ANALOGIX_DP_AUX_CH_CTL_1);
-
-		/* Start AUX transaction */
-		retval = analogix_dp_start_aux_transaction(dp);
-		if (retval == 0)
-			break;
-
-		dev_dbg(dp->dev, "%s: Aux Transaction fail!\n", __func__);
-	}
-
-	return retval;
-}
-
 void analogix_dp_set_link_bandwidth(struct analogix_dp_device *dp, u32 bwtype)
 {
 	u32 reg;
-- 
2.25.1


  parent reply	other threads:[~2020-11-05 14:52 UTC|newest]

Thread overview: 61+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-05 14:44 [PATCH 00/19] [Set 1] Rid W=1 warnings from GPU Lee Jones
2020-11-05 14:44 ` [PATCH 01/19] gpu: host1x: bus: Add missing description for 'driver' Lee Jones
2020-11-05 16:45   ` Thierry Reding
2020-11-05 21:13   ` Sam Ravnborg
2020-11-05 14:45 ` [PATCH 02/19] gpu: ipu-v3: ipu-di: Strip out 2 unused 'di_sync_config' entries Lee Jones
2020-11-05 14:45 ` [PATCH 03/19] gpu: drm: imx: ipuv3-plane: Mark 'crtc_state' as __always_unused Lee Jones
2020-11-05 19:17   ` Ahmad Fatoum
2020-11-06  7:41     ` Lee Jones
2020-11-06  8:44       ` Ahmad Fatoum
2020-11-06  8:49         ` Lee Jones
2020-11-05 14:45 ` [PATCH 04/19] gpu: drm: omapdrm: omap_irq: Fix a couple of doc-rot issues Lee Jones
2020-11-05 17:06   ` Tomi Valkeinen
2020-11-05 14:45 ` [PATCH 05/19] gpu: drm: selftests: test-drm_mm: Mark 'hole_end' as always_unused Lee Jones
2020-11-05 14:45 ` [PATCH 06/19] gpu: drm: scheduler: sched_main: Provide missing description for 'sched' paramter Lee Jones
2020-11-10 21:12   ` Alex Deucher
2020-11-05 14:45 ` [PATCH 07/19] gpu: drm: scheduler: sched_entity: Demote non-conformant kernel-doc headers Lee Jones
2020-11-10 21:13   ` Alex Deucher
2020-11-05 14:45 ` [PATCH 08/19] gpu: drm: omapdrm: dss: dsi: Rework and remove a few unused variables Lee Jones
2020-11-05 16:53   ` Tomi Valkeinen
2020-11-05 18:07     ` Lee Jones
2020-11-06 14:03       ` Tomi Valkeinen
2020-11-06 14:32         ` Lee Jones
2020-11-06  4:26   ` Laurent Pinchart
2020-11-05 14:45 ` [PATCH 09/19] gpu: drm: selftests: test-drm_framebuffer: Remove set but unused variable 'fb' Lee Jones
2020-11-05 14:45 ` [PATCH 10/19] gpu: drm: ttm: ttm_bo: Fix one function header - demote lots of kernel-doc abuses Lee Jones
2020-11-05 14:45 ` [PATCH 11/19] gpu: drm: panel: panel-simple: Fix 'struct panel_desc's header Lee Jones
2020-11-05 16:46   ` Thierry Reding
2020-11-05 21:16   ` Sam Ravnborg
2020-11-05 14:45 ` Lee Jones [this message]
2020-11-05 21:21   ` [PATCH 12/19] gpu: drm: bridge: analogix: analogix_dp_reg: Remove unused function 'analogix_dp_write_byte_to_dpcd' Sam Ravnborg
2020-11-05 14:45 ` [PATCH 13/19] gpu: drm: ttm: ttm_tt: Demote kernel-doc header format abuses Lee Jones
2020-11-05 14:45 ` [PATCH 14/19] gpu: drm: selftests: test-drm_dp_mst_helper: Place 'struct drm_dp_sideband_msg_req_body' onto the heap Lee Jones
2020-11-06 19:17   ` Lyude Paul
2020-11-06 19:25     ` Lee Jones
2020-11-09 15:19   ` Ville Syrjälä
2020-11-09 16:12     ` Lee Jones
2020-11-09 16:13       ` Lee Jones
2020-11-09 16:20       ` Ville Syrjälä
2020-11-09 16:40         ` Lee Jones
2020-11-09 17:03           ` Ville Syrjälä
2020-11-09 17:17             ` Lee Jones
2020-11-05 14:45 ` [PATCH 15/19] gpu: drm: radeon: radeon_drv: Remove unused variable 'ret' Lee Jones
2020-11-10 21:14   ` Alex Deucher
2020-11-10 21:20     ` Lee Jones
2020-11-05 14:45 ` [PATCH 16/19] gpu: drm: panel: panel-ilitek-ili9322: Demote non-conformant kernel-doc header Lee Jones
2020-11-05 16:47   ` Thierry Reding
2020-11-05 21:17   ` Sam Ravnborg
2020-11-06  7:43     ` Lee Jones
2020-11-06 16:11       ` Sam Ravnborg
2020-11-06 16:54         ` Lee Jones
2020-11-05 14:45 ` [PATCH 17/19] gpu: drm: radeon: radeon_device: Fix a bunch of kernel-doc misdemeanours Lee Jones
2020-11-10 21:50   ` Alex Deucher
2020-11-05 14:45 ` [PATCH 18/19] gpu: drm: amd: amdgpu: amdgpu: Mark global variables as __maybe_unused Lee Jones
2020-11-10 21:48   ` Alex Deucher
2020-11-05 14:45 ` [PATCH 19/19] gpu: drm: bridge: analogix: analogix_dp_reg: Remove unused function 'analogix_dp_start_aux_transaction' Lee Jones
2020-11-05 16:38 ` [PATCH 00/19] [Set 1] Rid W=1 warnings from GPU Sam Ravnborg
2020-11-05 18:12   ` Lee Jones
2020-11-05 16:48 ` Thierry Reding
2020-11-05 18:10   ` Lee Jones
2020-11-05 18:14     ` Daniel Vetter
2020-11-05 18:24       ` Lee Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201105144517.1826692-13-lee.jones@linaro.org \
    --to=lee.jones@linaro.org \
    --cc=Laurent.pinchart@ideasonboard.com \
    --cc=a.hajda@samsung.com \
    --cc=airlied@linux.ie \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jernej.skrabec@siol.net \
    --cc=jg1.han@samsung.com \
    --cc=jonas@kwiboo.se \
    --cc=linux-kernel@vger.kernel.org \
    --cc=narmstrong@baylibre.com \
    --cc=sam@ravnborg.org \
    --cc=yanaijie@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).