From: Lee Jones <lee.jones@linaro.org>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: Thierry Reding <thierry.reding@gmail.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Alex Deucher <alexander.deucher@amd.com>,
amd-gfx list <amd-gfx@lists.freedesktop.org>,
Andrzej Hajda <a.hajda@samsung.com>,
Christian Koenig <christian.koenig@amd.com>,
David Airlie <airlied@linux.ie>,
David Francis <David.Francis@amd.com>,
dri-devel <dri-devel@lists.freedesktop.org>,
Fabio Estevam <festevam@gmail.com>,
Gareth Hughes <gareth@valinux.com>, Huang Rui <ray.huang@amd.com>,
Jason Yan <yanaijie@huawei.com>,
Jernej Skrabec <jernej.skrabec@siol.net>,
Jingoo Han <jg1.han@samsung.com>, Jonas Karlman <jonas@kwiboo.se>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
"moderated list:DMA BUFFER SHARING FRAMEWORK"
<linaro-mm-sig@lists.linaro.org>,
Linus Walleij <linus.walleij@linaro.org>,
"open list:DMA BUFFER SHARING FRAMEWORK"
<linux-media@vger.kernel.org>,
linux-tegra <linux-tegra@vger.kernel.org>,
Lyude Paul <lyude@redhat.com>,
Neil Armstrong <narmstrong@baylibre.com>,
Nirmoy Das <nirmoy.aiemd@gmail.com>,
NXP Linux Team <linux-imx@nxp.com>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Philipp Zabel <p.zabel@pengutronix.de>,
Rob Clark <rob.clark@linaro.org>, Sam Ravnborg <sam@ravnborg.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Shawn Guo <shawnguo@kernel.org>,
Sumit Semwal <sumit.semwal@linaro.org>,
Tomi Valkeinen <tomi.valkeinen@ti.com>
Subject: Re: [PATCH 00/19] [Set 1] Rid W=1 warnings from GPU
Date: Thu, 5 Nov 2020 18:24:49 +0000 [thread overview]
Message-ID: <20201105182449.GR4488@dell> (raw)
In-Reply-To: <CAKMK7uEyW_KJ1qC3gLASDe4Qyk_5UMr+yCu7VVVdAq+Z0J6RwQ@mail.gmail.com>
On Thu, 05 Nov 2020, Daniel Vetter wrote:
> On Thu, Nov 5, 2020 at 7:10 PM Lee Jones <lee.jones@linaro.org> wrote:
> >
> > On Thu, 05 Nov 2020, Thierry Reding wrote:
> >
> > > On Thu, Nov 05, 2020 at 02:44:58PM +0000, Lee Jones wrote:
> > > > This set is part of a larger effort attempting to clean-up W=1
> > > > kernel builds, which are currently overwhelmingly riddled with
> > > > niggly little warnings.
> > > >
> > > > There are 5000 warnings to work through.
> > > >
> > > > It will take a couple more sets.
> > > >
> > > > Lee Jones (19):
> > > > gpu: host1x: bus: Add missing description for 'driver'
> > > > gpu: ipu-v3: ipu-di: Strip out 2 unused 'di_sync_config' entries
> > > > gpu: drm: imx: ipuv3-plane: Mark 'crtc_state' as __always_unused
> > > > gpu: drm: omapdrm: omap_irq: Fix a couple of doc-rot issues
> > > > gpu: drm: selftests: test-drm_mm: Mark 'hole_end' as always_unused
> > > > gpu: drm: scheduler: sched_main: Provide missing description for
> > > > 'sched' paramter
> > > > gpu: drm: scheduler: sched_entity: Demote non-conformant kernel-doc
> > > > headers
> > > > gpu: drm: omapdrm: dss: dsi: Rework and remove a few unused variables
> > > > gpu: drm: selftests: test-drm_framebuffer: Remove set but unused
> > > > variable 'fb'
> > > > gpu: drm: ttm: ttm_bo: Fix one function header - demote lots of
> > > > kernel-doc abuses
> > > > gpu: drm: panel: panel-simple: Fix 'struct panel_desc's header
> > > > gpu: drm: bridge: analogix: analogix_dp_reg: Remove unused function
> > > > 'analogix_dp_write_byte_to_dpcd'
> > > > gpu: drm: ttm: ttm_tt: Demote kernel-doc header format abuses
> > > > gpu: drm: selftests: test-drm_dp_mst_helper: Place 'struct
> > > > drm_dp_sideband_msg_req_body' onto the heap
> > > > gpu: drm: radeon: radeon_drv: Remove unused variable 'ret'
> > > > gpu: drm: panel: panel-ilitek-ili9322: Demote non-conformant
> > > > kernel-doc header
> > > > gpu: drm: radeon: radeon_device: Fix a bunch of kernel-doc
> > > > misdemeanours
> > > > gpu: drm: amd: amdgpu: amdgpu: Mark global variables as __maybe_unused
> > > > gpu: drm: bridge: analogix: analogix_dp_reg: Remove unused function
> > > > 'analogix_dp_start_aux_transaction'
> > >
> > > As commented on the other patches, the subject prefixes on most of these
> > > look wrong, but it's generally a nice cleanup.
> >
> > The prefixes are automated. I'll add this to my list of awkward
> > subsystems and go through them all manually again tomorrow. :D
>
> tbh for autmoation they look really good :-)
Only the prefixes are automated unfortunately. :)
> I'd say if you replace the intermediate ": " with just a / you'll be
> perfectly in style for drivers/gpu. But really I think it's ok as-is,
It's up to you. Make the call and I'll abide.
> imo no need to change since this is a giantic tree wide effort.
Yes, you're not kidding, and thanks for noticing.
Only 10,000 (from 18,000) more to go though. :D
GPU is a biggy (5,000), although one patch in [Set 2] fixes 2,000 in
one hit, which is great! I'll probably submit that tomorrow.
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
prev parent reply other threads:[~2020-11-05 18:24 UTC|newest]
Thread overview: 61+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-05 14:44 [PATCH 00/19] [Set 1] Rid W=1 warnings from GPU Lee Jones
2020-11-05 14:44 ` [PATCH 01/19] gpu: host1x: bus: Add missing description for 'driver' Lee Jones
2020-11-05 16:45 ` Thierry Reding
2020-11-05 21:13 ` Sam Ravnborg
2020-11-05 14:45 ` [PATCH 02/19] gpu: ipu-v3: ipu-di: Strip out 2 unused 'di_sync_config' entries Lee Jones
2020-11-05 14:45 ` [PATCH 03/19] gpu: drm: imx: ipuv3-plane: Mark 'crtc_state' as __always_unused Lee Jones
2020-11-05 19:17 ` Ahmad Fatoum
2020-11-06 7:41 ` Lee Jones
2020-11-06 8:44 ` Ahmad Fatoum
2020-11-06 8:49 ` Lee Jones
2020-11-05 14:45 ` [PATCH 04/19] gpu: drm: omapdrm: omap_irq: Fix a couple of doc-rot issues Lee Jones
2020-11-05 17:06 ` Tomi Valkeinen
2020-11-05 14:45 ` [PATCH 05/19] gpu: drm: selftests: test-drm_mm: Mark 'hole_end' as always_unused Lee Jones
2020-11-05 14:45 ` [PATCH 06/19] gpu: drm: scheduler: sched_main: Provide missing description for 'sched' paramter Lee Jones
2020-11-10 21:12 ` Alex Deucher
2020-11-05 14:45 ` [PATCH 07/19] gpu: drm: scheduler: sched_entity: Demote non-conformant kernel-doc headers Lee Jones
2020-11-10 21:13 ` Alex Deucher
2020-11-05 14:45 ` [PATCH 08/19] gpu: drm: omapdrm: dss: dsi: Rework and remove a few unused variables Lee Jones
2020-11-05 16:53 ` Tomi Valkeinen
2020-11-05 18:07 ` Lee Jones
2020-11-06 14:03 ` Tomi Valkeinen
2020-11-06 14:32 ` Lee Jones
2020-11-06 4:26 ` Laurent Pinchart
2020-11-05 14:45 ` [PATCH 09/19] gpu: drm: selftests: test-drm_framebuffer: Remove set but unused variable 'fb' Lee Jones
2020-11-05 14:45 ` [PATCH 10/19] gpu: drm: ttm: ttm_bo: Fix one function header - demote lots of kernel-doc abuses Lee Jones
2020-11-05 14:45 ` [PATCH 11/19] gpu: drm: panel: panel-simple: Fix 'struct panel_desc's header Lee Jones
2020-11-05 16:46 ` Thierry Reding
2020-11-05 21:16 ` Sam Ravnborg
2020-11-05 14:45 ` [PATCH 12/19] gpu: drm: bridge: analogix: analogix_dp_reg: Remove unused function 'analogix_dp_write_byte_to_dpcd' Lee Jones
2020-11-05 21:21 ` Sam Ravnborg
2020-11-05 14:45 ` [PATCH 13/19] gpu: drm: ttm: ttm_tt: Demote kernel-doc header format abuses Lee Jones
2020-11-05 14:45 ` [PATCH 14/19] gpu: drm: selftests: test-drm_dp_mst_helper: Place 'struct drm_dp_sideband_msg_req_body' onto the heap Lee Jones
2020-11-06 19:17 ` Lyude Paul
2020-11-06 19:25 ` Lee Jones
2020-11-09 15:19 ` Ville Syrjälä
2020-11-09 16:12 ` Lee Jones
2020-11-09 16:13 ` Lee Jones
2020-11-09 16:20 ` Ville Syrjälä
2020-11-09 16:40 ` Lee Jones
2020-11-09 17:03 ` Ville Syrjälä
2020-11-09 17:17 ` Lee Jones
2020-11-05 14:45 ` [PATCH 15/19] gpu: drm: radeon: radeon_drv: Remove unused variable 'ret' Lee Jones
2020-11-10 21:14 ` Alex Deucher
2020-11-10 21:20 ` Lee Jones
2020-11-05 14:45 ` [PATCH 16/19] gpu: drm: panel: panel-ilitek-ili9322: Demote non-conformant kernel-doc header Lee Jones
2020-11-05 16:47 ` Thierry Reding
2020-11-05 21:17 ` Sam Ravnborg
2020-11-06 7:43 ` Lee Jones
2020-11-06 16:11 ` Sam Ravnborg
2020-11-06 16:54 ` Lee Jones
2020-11-05 14:45 ` [PATCH 17/19] gpu: drm: radeon: radeon_device: Fix a bunch of kernel-doc misdemeanours Lee Jones
2020-11-10 21:50 ` Alex Deucher
2020-11-05 14:45 ` [PATCH 18/19] gpu: drm: amd: amdgpu: amdgpu: Mark global variables as __maybe_unused Lee Jones
2020-11-10 21:48 ` Alex Deucher
2020-11-05 14:45 ` [PATCH 19/19] gpu: drm: bridge: analogix: analogix_dp_reg: Remove unused function 'analogix_dp_start_aux_transaction' Lee Jones
2020-11-05 16:38 ` [PATCH 00/19] [Set 1] Rid W=1 warnings from GPU Sam Ravnborg
2020-11-05 18:12 ` Lee Jones
2020-11-05 16:48 ` Thierry Reding
2020-11-05 18:10 ` Lee Jones
2020-11-05 18:14 ` Daniel Vetter
2020-11-05 18:24 ` Lee Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201105182449.GR4488@dell \
--to=lee.jones@linaro.org \
--cc=David.Francis@amd.com \
--cc=a.hajda@samsung.com \
--cc=airlied@linux.ie \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=christian.koenig@amd.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=festevam@gmail.com \
--cc=gareth@valinux.com \
--cc=jernej.skrabec@siol.net \
--cc=jg1.han@samsung.com \
--cc=jonas@kwiboo.se \
--cc=kernel@pengutronix.de \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linaro-mm-sig@lists.linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=lyude@redhat.com \
--cc=narmstrong@baylibre.com \
--cc=nirmoy.aiemd@gmail.com \
--cc=p.zabel@pengutronix.de \
--cc=ray.huang@amd.com \
--cc=rob.clark@linaro.org \
--cc=s.hauer@pengutronix.de \
--cc=sam@ravnborg.org \
--cc=shawnguo@kernel.org \
--cc=sumit.semwal@linaro.org \
--cc=thierry.reding@gmail.com \
--cc=tomi.valkeinen@ti.com \
--cc=yanaijie@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).