* [PATCH] arm64: dts: allwinner: pinephone: Use generic sensor node names
@ 2020-11-06 3:20 Samuel Holland
2020-11-06 11:24 ` Maxime Ripard
0 siblings, 1 reply; 2+ messages in thread
From: Samuel Holland @ 2020-11-06 3:20 UTC (permalink / raw)
To: Maxime Ripard, Chen-Yu Tsai, Jernej Skrabec, linux-arm-kernel
Cc: Rob Herring, devicetree, linux-kernel, linux-sunxi,
Samuel Holland, Maxime Ripard
Instead of duplicating part of the compatible string in the node name,
use generic names as recommended by (and listed in) section 2.2.2 of the
Devicetree Specification.
Suggested-by: Maxime Ripard <maxime@cerno.tech>
Signed-off-by: Samuel Holland <samuel@sholland.org>
---
arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi
index 2da69450eec1..2dfe9bae8c67 100644
--- a/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi
+++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi
@@ -161,7 +161,7 @@ &i2c1 {
status = "okay";
/* Magnetometer */
- lis3mdl: lis3mdl@1e {
+ lis3mdl: magnetometer@1e {
compatible = "st,lis3mdl-magn";
reg = <0x1e>;
vdd-supply = <®_dldo1>;
@@ -169,7 +169,7 @@ lis3mdl: lis3mdl@1e {
};
/* Light/proximity sensor */
- stk3311@48 {
+ light-sensor@48 {
compatible = "sensortek,stk3311";
reg = <0x48>;
interrupt-parent = <&pio>;
@@ -179,7 +179,7 @@ stk3311@48 {
};
/* Accelerometer/gyroscope */
- mpu6050@68 {
+ accelerometer@68 {
compatible = "invensense,mpu6050";
reg = <0x68>;
interrupt-parent = <&pio>;
--
2.26.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] arm64: dts: allwinner: pinephone: Use generic sensor node names
2020-11-06 3:20 [PATCH] arm64: dts: allwinner: pinephone: Use generic sensor node names Samuel Holland
@ 2020-11-06 11:24 ` Maxime Ripard
0 siblings, 0 replies; 2+ messages in thread
From: Maxime Ripard @ 2020-11-06 11:24 UTC (permalink / raw)
To: Samuel Holland
Cc: Chen-Yu Tsai, Jernej Skrabec, linux-arm-kernel, Rob Herring,
devicetree, linux-kernel, linux-sunxi
[-- Attachment #1: Type: text/plain, Size: 382 bytes --]
On Thu, Nov 05, 2020 at 09:20:55PM -0600, Samuel Holland wrote:
> Instead of duplicating part of the compatible string in the node name,
> use generic names as recommended by (and listed in) section 2.2.2 of the
> Devicetree Specification.
>
> Suggested-by: Maxime Ripard <maxime@cerno.tech>
> Signed-off-by: Samuel Holland <samuel@sholland.org>
Applied, thanks!
Maxime
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-11-06 11:24 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-06 3:20 [PATCH] arm64: dts: allwinner: pinephone: Use generic sensor node names Samuel Holland
2020-11-06 11:24 ` Maxime Ripard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).