From: Jonathan Cameron <jic23@kernel.org>
To: Necip Fazil Yildiran <fazilyildiran@gmail.com>
Cc: pn@denx.de, linux-iio@vger.kernel.org,
linux-kernel@vger.kernel.org, paul@pgazz.com, jeho@cs.utexas.edu
Subject: Re: [PATCH] iio: light: fix kconfig dependency bug for VCNL4035
Date: Sun, 8 Nov 2020 15:44:20 +0000 [thread overview]
Message-ID: <20201108154420.4982d232@archlinux> (raw)
In-Reply-To: <20201102223523.572461-1-fazilyildiran@gmail.com>
On Tue, 3 Nov 2020 01:35:24 +0300
Necip Fazil Yildiran <fazilyildiran@gmail.com> wrote:
> When VCNL4035 is enabled and IIO_BUFFER is disabled, it results in the
> following Kbuild warning:
>
> WARNING: unmet direct dependencies detected for IIO_TRIGGERED_BUFFER
> Depends on [n]: IIO [=y] && IIO_BUFFER [=n]
> Selected by [y]:
> - VCNL4035 [=y] && IIO [=y] && I2C [=y]
>
> The reason is that VCNL4035 selects IIO_TRIGGERED_BUFFER without depending
> on or selecting IIO_BUFFER while IIO_TRIGGERED_BUFFER depends on
> IIO_BUFFER. This can also fail building the kernel.
>
> Honor the kconfig dependency to remove unmet direct dependency warnings
> and avoid any potential build failures.
>
> Fixes: 55707294c4eb ("iio: light: Add support for vishay vcnl4035")
> Link: https://bugzilla.kernel.org/show_bug.cgi?id=209883
> Signed-off-by: Necip Fazil Yildiran <fazilyildiran@gmail.com>
Applied to the fixes-togreg branch of iio.git and marked for stable.
Thanks,
Jonathan
> ---
> drivers/iio/light/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/iio/light/Kconfig b/drivers/iio/light/Kconfig
> index cade6dc0305b..33ad4dd0b5c7 100644
> --- a/drivers/iio/light/Kconfig
> +++ b/drivers/iio/light/Kconfig
> @@ -544,6 +544,7 @@ config VCNL4000
>
> config VCNL4035
> tristate "VCNL4035 combined ALS and proximity sensor"
> + select IIO_BUFFER
> select IIO_TRIGGERED_BUFFER
> select REGMAP_I2C
> depends on I2C
prev parent reply other threads:[~2020-11-08 15:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-02 22:35 [PATCH] iio: light: fix kconfig dependency bug for VCNL4035 Necip Fazil Yildiran
2020-11-08 15:44 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201108154420.4982d232@archlinux \
--to=jic23@kernel.org \
--cc=fazilyildiran@gmail.com \
--cc=jeho@cs.utexas.edu \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paul@pgazz.com \
--cc=pn@denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).