* [PATCH] iio: light: fix kconfig dependency bug for VCNL4035
@ 2020-11-02 22:35 Necip Fazil Yildiran
2020-11-08 15:44 ` Jonathan Cameron
0 siblings, 1 reply; 2+ messages in thread
From: Necip Fazil Yildiran @ 2020-11-02 22:35 UTC (permalink / raw)
To: jic23; +Cc: pn, linux-iio, linux-kernel, paul, jeho, Necip Fazil Yildiran
When VCNL4035 is enabled and IIO_BUFFER is disabled, it results in the
following Kbuild warning:
WARNING: unmet direct dependencies detected for IIO_TRIGGERED_BUFFER
Depends on [n]: IIO [=y] && IIO_BUFFER [=n]
Selected by [y]:
- VCNL4035 [=y] && IIO [=y] && I2C [=y]
The reason is that VCNL4035 selects IIO_TRIGGERED_BUFFER without depending
on or selecting IIO_BUFFER while IIO_TRIGGERED_BUFFER depends on
IIO_BUFFER. This can also fail building the kernel.
Honor the kconfig dependency to remove unmet direct dependency warnings
and avoid any potential build failures.
Fixes: 55707294c4eb ("iio: light: Add support for vishay vcnl4035")
Link: https://bugzilla.kernel.org/show_bug.cgi?id=209883
Signed-off-by: Necip Fazil Yildiran <fazilyildiran@gmail.com>
---
drivers/iio/light/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/iio/light/Kconfig b/drivers/iio/light/Kconfig
index cade6dc0305b..33ad4dd0b5c7 100644
--- a/drivers/iio/light/Kconfig
+++ b/drivers/iio/light/Kconfig
@@ -544,6 +544,7 @@ config VCNL4000
config VCNL4035
tristate "VCNL4035 combined ALS and proximity sensor"
+ select IIO_BUFFER
select IIO_TRIGGERED_BUFFER
select REGMAP_I2C
depends on I2C
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] iio: light: fix kconfig dependency bug for VCNL4035
2020-11-02 22:35 [PATCH] iio: light: fix kconfig dependency bug for VCNL4035 Necip Fazil Yildiran
@ 2020-11-08 15:44 ` Jonathan Cameron
0 siblings, 0 replies; 2+ messages in thread
From: Jonathan Cameron @ 2020-11-08 15:44 UTC (permalink / raw)
To: Necip Fazil Yildiran; +Cc: pn, linux-iio, linux-kernel, paul, jeho
On Tue, 3 Nov 2020 01:35:24 +0300
Necip Fazil Yildiran <fazilyildiran@gmail.com> wrote:
> When VCNL4035 is enabled and IIO_BUFFER is disabled, it results in the
> following Kbuild warning:
>
> WARNING: unmet direct dependencies detected for IIO_TRIGGERED_BUFFER
> Depends on [n]: IIO [=y] && IIO_BUFFER [=n]
> Selected by [y]:
> - VCNL4035 [=y] && IIO [=y] && I2C [=y]
>
> The reason is that VCNL4035 selects IIO_TRIGGERED_BUFFER without depending
> on or selecting IIO_BUFFER while IIO_TRIGGERED_BUFFER depends on
> IIO_BUFFER. This can also fail building the kernel.
>
> Honor the kconfig dependency to remove unmet direct dependency warnings
> and avoid any potential build failures.
>
> Fixes: 55707294c4eb ("iio: light: Add support for vishay vcnl4035")
> Link: https://bugzilla.kernel.org/show_bug.cgi?id=209883
> Signed-off-by: Necip Fazil Yildiran <fazilyildiran@gmail.com>
Applied to the fixes-togreg branch of iio.git and marked for stable.
Thanks,
Jonathan
> ---
> drivers/iio/light/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/iio/light/Kconfig b/drivers/iio/light/Kconfig
> index cade6dc0305b..33ad4dd0b5c7 100644
> --- a/drivers/iio/light/Kconfig
> +++ b/drivers/iio/light/Kconfig
> @@ -544,6 +544,7 @@ config VCNL4000
>
> config VCNL4035
> tristate "VCNL4035 combined ALS and proximity sensor"
> + select IIO_BUFFER
> select IIO_TRIGGERED_BUFFER
> select REGMAP_I2C
> depends on I2C
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-11-08 15:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-02 22:35 [PATCH] iio: light: fix kconfig dependency bug for VCNL4035 Necip Fazil Yildiran
2020-11-08 15:44 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).