From: Nathan Chancellor <natechancellor@gmail.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Shawn Guo <shawnguo@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Frieder Schrempf <frieder.schrempf@kontron.de>,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] arm64: dts: imx: Fix imx8mm-kontron-n801x-s.dtb target
Date: Sun, 8 Nov 2020 12:13:46 -0700 [thread overview]
Message-ID: <20201108191346.GA4061631@ubuntu-m3-large-x86> (raw)
In-Reply-To: <CAJKOXPdVVgRMaCPfq3nPR232KQyKVVewm5LveUSuyfqE8sScQg@mail.gmail.com>
Hi Krzysztof,
On Sun, Nov 08, 2020 at 10:31:10AM +0100, Krzysztof Kozlowski wrote:
> On Sun, 8 Nov 2020 at 03:23, Nathan Chancellor <natechancellor@gmail.com> wrote:
>
> Hi,
>
> Thanks for the fixes.
>
> Please mark patches with versions, this should be v2. Otherwise
> maintainer might apply the older one,
> You also need to add versioning changelog after ---.
I have only sent this one patch. It looks like Anders Roxell sent an
identical patch though:
https://lore.kernel.org/linux-devicetree/20201105111823.1613337-1-anders.roxell@linaro.org/
> > $ make -skj"$(nproc)" ARCH=arm64 CROSS_COMPILE=aarch64-linux- \
> > INSTALL_DTBS_PATH=rootfs distclean defconfig dtbs dtbs_install
>
> All this is still irrelevant. Just: "make dtbs". Don't add unrelated
> details like how many processes you spawn, where do you want to
> install DTBS or even all other make targets.
> Everyone should know how to cross compile so simple: make dtbs
Sure, I will update it, my apologies.
> > ...
> > make[3]: *** No rule to make target
> > 'rootfs/freescale/imx8mm-kontron-n801x-s.dts', needed by
> > '__dtbs_install'
>
> This should be joined with previous line. I mentioned it in your previous patch.
Sure, I usually just let my editor do the auto wrapping but I will put
it all onto one line!
> > ...
>
> Also not needed dots. This is small change and should go with small
> and accurate description. Blowing the description does not help.
>
> Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>
>
> Best regards,
> Krzysztof
Thank you for the review, I will sent v2 along shortly.
Cheers,
Nathan
next prev parent reply other threads:[~2020-11-08 19:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-08 2:23 [PATCH] arm64: dts: imx: Fix imx8mm-kontron-n801x-s.dtb target Nathan Chancellor
2020-11-08 9:31 ` Krzysztof Kozlowski
2020-11-08 19:13 ` Nathan Chancellor [this message]
2020-11-08 19:16 ` Krzysztof Kozlowski
2020-11-08 19:16 ` [PATCH v2] " Nathan Chancellor
2020-11-09 8:05 ` Frieder Schrempf
2020-11-10 3:03 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201108191346.GA4061631@ubuntu-m3-large-x86 \
--to=natechancellor@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=frieder.schrempf@kontron.de \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).