linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Nathan Chancellor <natechancellor@gmail.com>
Cc: Shawn Guo <shawnguo@kernel.org>, Rob Herring <robh+dt@kernel.org>,
	Frieder Schrempf <frieder.schrempf@kontron.de>,
	linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] arm64: dts: imx: Fix imx8mm-kontron-n801x-s.dtb target
Date: Sun, 8 Nov 2020 10:31:10 +0100	[thread overview]
Message-ID: <CAJKOXPdVVgRMaCPfq3nPR232KQyKVVewm5LveUSuyfqE8sScQg@mail.gmail.com> (raw)
In-Reply-To: <20201108022321.2114430-1-natechancellor@gmail.com>

On Sun, 8 Nov 2020 at 03:23, Nathan Chancellor <natechancellor@gmail.com> wrote:

Hi,

Thanks for the fixes.

Please mark patches with versions, this should be v2. Otherwise
maintainer might apply the older one,
You also need to add versioning changelog after ---.

> $ make -skj"$(nproc)" ARCH=arm64 CROSS_COMPILE=aarch64-linux- \
> INSTALL_DTBS_PATH=rootfs distclean defconfig dtbs dtbs_install

All this is still irrelevant. Just: "make dtbs". Don't add unrelated
details like how many processes you spawn, where do you want to
install DTBS or even all other make targets.
Everyone should know how to cross compile so simple: make dtbs

> ...
> make[3]: *** No rule to make target
> 'rootfs/freescale/imx8mm-kontron-n801x-s.dts', needed by
> '__dtbs_install'

This should be joined with previous line. I mentioned it in your previous patch.

> ...

Also not needed dots. This is small change and should go with small
and accurate description. Blowing the description does not help.

Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>

Best regards,
Krzysztof

  reply	other threads:[~2020-11-08  9:31 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-08  2:23 [PATCH] arm64: dts: imx: Fix imx8mm-kontron-n801x-s.dtb target Nathan Chancellor
2020-11-08  9:31 ` Krzysztof Kozlowski [this message]
2020-11-08 19:13   ` Nathan Chancellor
2020-11-08 19:16     ` Krzysztof Kozlowski
2020-11-08 19:16 ` [PATCH v2] " Nathan Chancellor
2020-11-09  8:05   ` Frieder Schrempf
2020-11-10  3:03   ` Shawn Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAJKOXPdVVgRMaCPfq3nPR232KQyKVVewm5LveUSuyfqE8sScQg@mail.gmail.com \
    --to=krzk@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=frieder.schrempf@kontron.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=natechancellor@gmail.com \
    --cc=robh+dt@kernel.org \
    --cc=shawnguo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).