* [RESEND PATCH v2] net/x25: Fix null-ptr-deref in x25_connect
@ 2020-11-09 6:54 Martin Schiller
2020-11-11 11:38 ` Xie He
2020-11-11 11:59 ` Xie He
0 siblings, 2 replies; 4+ messages in thread
From: Martin Schiller @ 2020-11-09 6:54 UTC (permalink / raw)
To: andrew.hendry, davem, kuba, edumazet, xiyuyang19
Cc: linux-x25, netdev, linux-kernel, Martin Schiller
This fixes a regression for blocking connects introduced by commit
4becb7ee5b3d ("net/x25: Fix x25_neigh refcnt leak when x25 disconnect").
The x25->neighbour is already set to "NULL" by x25_disconnect() now,
while a blocking connect is waiting in
x25_wait_for_connection_establishment(). Therefore x25->neighbour must
not be accessed here again and x25->state is also already set to
X25_STATE_0 by x25_disconnect().
Fixes: 4becb7ee5b3d ("net/x25: Fix x25_neigh refcnt leak when x25 disconnect")
Signed-off-by: Martin Schiller <ms@dev.tdt.de>
---
Change from v1:
also handle interrupting signals correctly
---
net/x25/af_x25.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/x25/af_x25.c b/net/x25/af_x25.c
index 0bbb283f23c9..046d3fee66a9 100644
--- a/net/x25/af_x25.c
+++ b/net/x25/af_x25.c
@@ -825,7 +825,7 @@ static int x25_connect(struct socket *sock, struct sockaddr *uaddr,
sock->state = SS_CONNECTED;
rc = 0;
out_put_neigh:
- if (rc) {
+ if (rc && x25->neighbour) {
read_lock_bh(&x25_list_lock);
x25_neigh_put(x25->neighbour);
x25->neighbour = NULL;
--
2.20.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [RESEND PATCH v2] net/x25: Fix null-ptr-deref in x25_connect
2020-11-09 6:54 [RESEND PATCH v2] net/x25: Fix null-ptr-deref in x25_connect Martin Schiller
@ 2020-11-11 11:38 ` Xie He
2020-11-11 11:59 ` Xie He
1 sibling, 0 replies; 4+ messages in thread
From: Xie He @ 2020-11-11 11:38 UTC (permalink / raw)
To: Martin Schiller
Cc: andrew.hendry, davem, kuba, edumazet, xiyuyang19, linux-x25,
netdev, linux-kernel
> This fixes a regression for blocking connects introduced by commit
> 4becb7ee5b3d ("net/x25: Fix x25_neigh refcnt leak when x25 disconnect").
> The x25->neighbour is already set to "NULL" by x25_disconnect() now,
> while a blocking connect is waiting in
> x25_wait_for_connection_establishment(). Therefore x25->neighbour must
> not be accessed here again and x25->state is also already set to
> X25_STATE_0 by x25_disconnect().
> Fixes: 4becb7ee5b3d ("net/x25: Fix x25_neigh refcnt leak when x25 disconnect")
> Signed-off-by: Martin Schiller <ms@dev.tdt.de>
Oh. Sorry, I didn't see your patch. I just submitted another patch to fix
the same problem.
I also found another problem introduced by the same regression commit,
which I was also trying to fix in my patch.
See:
http://patchwork.ozlabs.org/project/netdev/patch/20201111100424.3989-1-xie.he.0141@gmail.com/
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [RESEND PATCH v2] net/x25: Fix null-ptr-deref in x25_connect
2020-11-09 6:54 [RESEND PATCH v2] net/x25: Fix null-ptr-deref in x25_connect Martin Schiller
2020-11-11 11:38 ` Xie He
@ 2020-11-11 11:59 ` Xie He
2020-11-11 22:57 ` Jakub Kicinski
1 sibling, 1 reply; 4+ messages in thread
From: Xie He @ 2020-11-11 11:59 UTC (permalink / raw)
To: Martin Schiller
Cc: andrew.hendry, davem, kuba, edumazet, xiyuyang19, linux-x25,
netdev, linux-kernel, Xie He
> @@ -825,7 +825,7 @@ static int x25_connect(struct socket *sock, struct sockaddr *uaddr,
> sock->state = SS_CONNECTED;
> rc = 0;
> out_put_neigh:
> - if (rc) {
> + if (rc && x25->neighbour) {
> read_lock_bh(&x25_list_lock);
> x25_neigh_put(x25->neighbour);
> x25->neighbour = NULL;
Thanks! It's amazing to see we are trying to fix the same issue.
Reviewed-by: Xie He <xie.he.0141@gmail.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [RESEND PATCH v2] net/x25: Fix null-ptr-deref in x25_connect
2020-11-11 11:59 ` Xie He
@ 2020-11-11 22:57 ` Jakub Kicinski
0 siblings, 0 replies; 4+ messages in thread
From: Jakub Kicinski @ 2020-11-11 22:57 UTC (permalink / raw)
To: Xie He
Cc: Martin Schiller, andrew.hendry, davem, edumazet, xiyuyang19,
linux-x25, netdev, linux-kernel
On Wed, 11 Nov 2020 03:59:47 -0800 Xie He wrote:
> > @@ -825,7 +825,7 @@ static int x25_connect(struct socket *sock, struct sockaddr *uaddr,
> > sock->state = SS_CONNECTED;
> > rc = 0;
> > out_put_neigh:
> > - if (rc) {
> > + if (rc && x25->neighbour) {
> > read_lock_bh(&x25_list_lock);
> > x25_neigh_put(x25->neighbour);
> > x25->neighbour = NULL;
>
> Reviewed-by: Xie He <xie.he.0141@gmail.com>
Applied, thanks!
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-11-12 1:45 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-09 6:54 [RESEND PATCH v2] net/x25: Fix null-ptr-deref in x25_connect Martin Schiller
2020-11-11 11:38 ` Xie He
2020-11-11 11:59 ` Xie He
2020-11-11 22:57 ` Jakub Kicinski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).