* [PATCH] x86/platform/uv: drop last traces of uv_flush_tlb_others
@ 2020-11-09 9:36 Jiri Slaby
2020-11-09 15:07 ` Mike Travis
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Jiri Slaby @ 2020-11-09 9:36 UTC (permalink / raw)
To: bp
Cc: linux-kernel, Jiri Slaby, Mike Travis, Dimitri Sivanich,
Steve Wahl, Russ Anderson, Thomas Gleixner, Ingo Molnar, x86,
H. Peter Anvin
Commit 39297dde7390 ("x86/platform/uv: Remove UV BAU TLB Shootdown
Handler") removed uv_flush_tlb_others. Its declaration was removed also
from asm/uv/uv.h. But only for the CONFIG_X86_UV=y case. The inline
definition (!X86_UV case) is still in place.
So remove this implementation with everything what was added to support
uv_flush_tlb_others:
* include of asm/tlbflush.h
* forward declarations of struct cpumask, mm_struct, and flush_tlb_info
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
Cc: Mike Travis <mike.travis@hpe.com>
Cc: Dimitri Sivanich <dimitri.sivanich@hpe.com>
Cc: Steve Wahl <steve.wahl@hpe.com>
Cc: Russ Anderson <russ.anderson@hpe.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Borislav Petkov <bp@alien8.de>
Cc: x86@kernel.org
Cc: "H. Peter Anvin" <hpa@zytor.com>
---
arch/x86/include/asm/uv/uv.h | 10 ----------
1 file changed, 10 deletions(-)
diff --git a/arch/x86/include/asm/uv/uv.h b/arch/x86/include/asm/uv/uv.h
index 172d3e4a9e4b..648eb23fe7f0 100644
--- a/arch/x86/include/asm/uv/uv.h
+++ b/arch/x86/include/asm/uv/uv.h
@@ -2,14 +2,8 @@
#ifndef _ASM_X86_UV_UV_H
#define _ASM_X86_UV_UV_H
-#include <asm/tlbflush.h>
-
enum uv_system_type {UV_NONE, UV_LEGACY_APIC, UV_X2APIC};
-struct cpumask;
-struct mm_struct;
-struct flush_tlb_info;
-
#ifdef CONFIG_X86_UV
#include <linux/efi.h>
@@ -44,10 +38,6 @@ static inline int is_uv_system(void) { return 0; }
static inline int is_uv_hubbed(int uv) { return 0; }
static inline void uv_cpu_init(void) { }
static inline void uv_system_init(void) { }
-static inline const struct cpumask *
-uv_flush_tlb_others(const struct cpumask *cpumask,
- const struct flush_tlb_info *info)
-{ return cpumask; }
#endif /* X86_UV */
--
2.29.2
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] x86/platform/uv: drop last traces of uv_flush_tlb_others
2020-11-09 9:36 [PATCH] x86/platform/uv: drop last traces of uv_flush_tlb_others Jiri Slaby
@ 2020-11-09 15:07 ` Mike Travis
2020-11-09 16:00 ` Steve Wahl
2020-11-11 12:22 ` [tip: x86/urgent] x86/platform/uv: Drop " tip-bot2 for Jiri Slaby
2 siblings, 0 replies; 4+ messages in thread
From: Mike Travis @ 2020-11-09 15:07 UTC (permalink / raw)
To: Jiri Slaby, bp
Cc: linux-kernel, Dimitri Sivanich, Steve Wahl, Russ Anderson,
Thomas Gleixner, Ingo Molnar, x86, H. Peter Anvin
Thanks Jiri for catching that.
Acked-By: Mike Travis <mike.travis@hpe.com>
On 11/9/2020 1:36 AM, Jiri Slaby wrote:
> Commit 39297dde7390 ("x86/platform/uv: Remove UV BAU TLB Shootdown
> Handler") removed uv_flush_tlb_others. Its declaration was removed also
> from asm/uv/uv.h. But only for the CONFIG_X86_UV=y case. The inline
> definition (!X86_UV case) is still in place.
>
> So remove this implementation with everything what was added to support
> uv_flush_tlb_others:
> * include of asm/tlbflush.h
> * forward declarations of struct cpumask, mm_struct, and flush_tlb_info
>
> Signed-off-by: Jiri Slaby <jslaby@suse.cz>
> Cc: Mike Travis <mike.travis@hpe.com>
> Cc: Dimitri Sivanich <dimitri.sivanich@hpe.com>
> Cc: Steve Wahl <steve.wahl@hpe.com>
> Cc: Russ Anderson <russ.anderson@hpe.com>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: Ingo Molnar <mingo@redhat.com>
> Cc: Borislav Petkov <bp@alien8.de>
> Cc: x86@kernel.org
> Cc: "H. Peter Anvin" <hpa@zytor.com>
> ---
> arch/x86/include/asm/uv/uv.h | 10 ----------
> 1 file changed, 10 deletions(-)
>
> diff --git a/arch/x86/include/asm/uv/uv.h b/arch/x86/include/asm/uv/uv.h
> index 172d3e4a9e4b..648eb23fe7f0 100644
> --- a/arch/x86/include/asm/uv/uv.h
> +++ b/arch/x86/include/asm/uv/uv.h
> @@ -2,14 +2,8 @@
> #ifndef _ASM_X86_UV_UV_H
> #define _ASM_X86_UV_UV_H
>
> -#include <asm/tlbflush.h>
> -
> enum uv_system_type {UV_NONE, UV_LEGACY_APIC, UV_X2APIC};
>
> -struct cpumask;
> -struct mm_struct;
> -struct flush_tlb_info;
> -
> #ifdef CONFIG_X86_UV
> #include <linux/efi.h>
>
> @@ -44,10 +38,6 @@ static inline int is_uv_system(void) { return 0; }
> static inline int is_uv_hubbed(int uv) { return 0; }
> static inline void uv_cpu_init(void) { }
> static inline void uv_system_init(void) { }
> -static inline const struct cpumask *
> -uv_flush_tlb_others(const struct cpumask *cpumask,
> - const struct flush_tlb_info *info)
> -{ return cpumask; }
>
> #endif /* X86_UV */
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] x86/platform/uv: drop last traces of uv_flush_tlb_others
2020-11-09 9:36 [PATCH] x86/platform/uv: drop last traces of uv_flush_tlb_others Jiri Slaby
2020-11-09 15:07 ` Mike Travis
@ 2020-11-09 16:00 ` Steve Wahl
2020-11-11 12:22 ` [tip: x86/urgent] x86/platform/uv: Drop " tip-bot2 for Jiri Slaby
2 siblings, 0 replies; 4+ messages in thread
From: Steve Wahl @ 2020-11-09 16:00 UTC (permalink / raw)
To: Jiri Slaby
Cc: bp, linux-kernel, Mike Travis, Dimitri Sivanich, Steve Wahl,
Russ Anderson, Thomas Gleixner, Ingo Molnar, x86, H. Peter Anvin
Acked-by: Steve Wahl <steve.wahl@hpe.com>
On Mon, Nov 09, 2020 at 10:36:53AM +0100, Jiri Slaby wrote:
> Commit 39297dde7390 ("x86/platform/uv: Remove UV BAU TLB Shootdown
> Handler") removed uv_flush_tlb_others. Its declaration was removed also
> from asm/uv/uv.h. But only for the CONFIG_X86_UV=y case. The inline
> definition (!X86_UV case) is still in place.
>
> So remove this implementation with everything what was added to support
> uv_flush_tlb_others:
> * include of asm/tlbflush.h
> * forward declarations of struct cpumask, mm_struct, and flush_tlb_info
>
> Signed-off-by: Jiri Slaby <jslaby@suse.cz>
> Cc: Mike Travis <mike.travis@hpe.com>
> Cc: Dimitri Sivanich <dimitri.sivanich@hpe.com>
> Cc: Steve Wahl <steve.wahl@hpe.com>
> Cc: Russ Anderson <russ.anderson@hpe.com>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: Ingo Molnar <mingo@redhat.com>
> Cc: Borislav Petkov <bp@alien8.de>
> Cc: x86@kernel.org
> Cc: "H. Peter Anvin" <hpa@zytor.com>
> ---
> arch/x86/include/asm/uv/uv.h | 10 ----------
> 1 file changed, 10 deletions(-)
>
> diff --git a/arch/x86/include/asm/uv/uv.h b/arch/x86/include/asm/uv/uv.h
> index 172d3e4a9e4b..648eb23fe7f0 100644
> --- a/arch/x86/include/asm/uv/uv.h
> +++ b/arch/x86/include/asm/uv/uv.h
> @@ -2,14 +2,8 @@
> #ifndef _ASM_X86_UV_UV_H
> #define _ASM_X86_UV_UV_H
>
> -#include <asm/tlbflush.h>
> -
> enum uv_system_type {UV_NONE, UV_LEGACY_APIC, UV_X2APIC};
>
> -struct cpumask;
> -struct mm_struct;
> -struct flush_tlb_info;
> -
> #ifdef CONFIG_X86_UV
> #include <linux/efi.h>
>
> @@ -44,10 +38,6 @@ static inline int is_uv_system(void) { return 0; }
> static inline int is_uv_hubbed(int uv) { return 0; }
> static inline void uv_cpu_init(void) { }
> static inline void uv_system_init(void) { }
> -static inline const struct cpumask *
> -uv_flush_tlb_others(const struct cpumask *cpumask,
> - const struct flush_tlb_info *info)
> -{ return cpumask; }
>
> #endif /* X86_UV */
>
> --
> 2.29.2
>
--
Steve Wahl, Hewlett Packard Enterprise
^ permalink raw reply [flat|nested] 4+ messages in thread* [tip: x86/urgent] x86/platform/uv: Drop last traces of uv_flush_tlb_others
2020-11-09 9:36 [PATCH] x86/platform/uv: drop last traces of uv_flush_tlb_others Jiri Slaby
2020-11-09 15:07 ` Mike Travis
2020-11-09 16:00 ` Steve Wahl
@ 2020-11-11 12:22 ` tip-bot2 for Jiri Slaby
2 siblings, 0 replies; 4+ messages in thread
From: tip-bot2 for Jiri Slaby @ 2020-11-11 12:22 UTC (permalink / raw)
To: linux-tip-commits
Cc: Jiri Slaby, Thomas Gleixner, Mike Travis, Steve Wahl, x86, linux-kernel
The following commit has been merged into the x86/urgent branch of tip:
Commit-ID: b2896458b850ec7cb69b054b195b4b399f7e1f22
Gitweb: https://git.kernel.org/tip/b2896458b850ec7cb69b054b195b4b399f7e1f22
Author: Jiri Slaby <jslaby@suse.cz>
AuthorDate: Mon, 09 Nov 2020 10:36:53 +01:00
Committer: Thomas Gleixner <tglx@linutronix.de>
CommitterDate: Wed, 11 Nov 2020 13:16:51 +01:00
x86/platform/uv: Drop last traces of uv_flush_tlb_others
Commit 39297dde7390 ("x86/platform/uv: Remove UV BAU TLB Shootdown
Handler") removed uv_flush_tlb_others. Its declaration was removed also
from asm/uv/uv.h. But only for the CONFIG_X86_UV=y case. The inline
definition (!X86_UV case) is still in place.
So remove this implementation with everything what was added to support
uv_flush_tlb_others:
* include of asm/tlbflush.h
* forward declarations of struct cpumask, mm_struct, and flush_tlb_info
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Acked-by: Mike Travis <mike.travis@hpe.com>
Acked-by: Steve Wahl <steve.wahl@hpe.com>
Link: https://lore.kernel.org/r/20201109093653.2042-1-jslaby@suse.cz
---
arch/x86/include/asm/uv/uv.h | 10 ----------
1 file changed, 10 deletions(-)
diff --git a/arch/x86/include/asm/uv/uv.h b/arch/x86/include/asm/uv/uv.h
index 172d3e4..648eb23 100644
--- a/arch/x86/include/asm/uv/uv.h
+++ b/arch/x86/include/asm/uv/uv.h
@@ -2,14 +2,8 @@
#ifndef _ASM_X86_UV_UV_H
#define _ASM_X86_UV_UV_H
-#include <asm/tlbflush.h>
-
enum uv_system_type {UV_NONE, UV_LEGACY_APIC, UV_X2APIC};
-struct cpumask;
-struct mm_struct;
-struct flush_tlb_info;
-
#ifdef CONFIG_X86_UV
#include <linux/efi.h>
@@ -44,10 +38,6 @@ static inline int is_uv_system(void) { return 0; }
static inline int is_uv_hubbed(int uv) { return 0; }
static inline void uv_cpu_init(void) { }
static inline void uv_system_init(void) { }
-static inline const struct cpumask *
-uv_flush_tlb_others(const struct cpumask *cpumask,
- const struct flush_tlb_info *info)
-{ return cpumask; }
#endif /* X86_UV */
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-11-11 12:23 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-09 9:36 [PATCH] x86/platform/uv: drop last traces of uv_flush_tlb_others Jiri Slaby
2020-11-09 15:07 ` Mike Travis
2020-11-09 16:00 ` Steve Wahl
2020-11-11 12:22 ` [tip: x86/urgent] x86/platform/uv: Drop " tip-bot2 for Jiri Slaby
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).