* [PATCH] amd/display/amdgpu_dm: delete same check in if condition
@ 2020-11-10 8:03 Bernard Zhao
2020-11-10 14:13 ` Harry Wentland
0 siblings, 1 reply; 3+ messages in thread
From: Bernard Zhao @ 2020-11-10 8:03 UTC (permalink / raw)
To: Harry Wentland, Leo Li, Alex Deucher, Christian König,
David Airlie, Daniel Vetter, Nicholas Kazlauskas,
Rodrigo Siqueira, Mikita Lipski, Stylon Wang, Bhawanpreet Lakha,
Roman Li, hersen wu, Aurabindo Pillai, Alexander Monakov,
amd-gfx, dri-devel, linux-kernel
Cc: opensource.kernel, Bernard Zhao
In function amdgpu_dm_connector_get_modes, drm_edid_is_valid
will check weather (!edid), no need to check again in the if
branch.
Signed-off-by: Bernard Zhao <bernard@vivo.com>
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
index e93e18c06c0e..0a283d07fe10 100644
--- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
+++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
@@ -6352,7 +6352,7 @@ static int amdgpu_dm_connector_get_modes(struct drm_connector *connector)
encoder = amdgpu_dm_connector_to_encoder(connector);
- if (!edid || !drm_edid_is_valid(edid)) {
+ if (!drm_edid_is_valid(edid)) {
amdgpu_dm_connector->num_modes =
drm_add_modes_noedid(connector, 640, 480);
} else {
--
2.29.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] amd/display/amdgpu_dm: delete same check in if condition
2020-11-10 8:03 [PATCH] amd/display/amdgpu_dm: delete same check in if condition Bernard Zhao
@ 2020-11-10 14:13 ` Harry Wentland
2020-11-10 18:35 ` Alex Deucher
0 siblings, 1 reply; 3+ messages in thread
From: Harry Wentland @ 2020-11-10 14:13 UTC (permalink / raw)
To: Bernard Zhao, Leo Li, Alex Deucher, Christian König,
David Airlie, Daniel Vetter, Nicholas Kazlauskas,
Rodrigo Siqueira, Mikita Lipski, Stylon Wang, Bhawanpreet Lakha,
Roman Li, hersen wu, Aurabindo Pillai, Alexander Monakov,
amd-gfx, dri-devel, linux-kernel
Cc: opensource.kernel
On 2020-11-10 3:03 a.m., Bernard Zhao wrote:
> In function amdgpu_dm_connector_get_modes, drm_edid_is_valid
> will check weather (!edid), no need to check again in the if
> branch.
>
> Signed-off-by: Bernard Zhao <bernard@vivo.com>
Reviewed-by: Harry Wentland <harry.wentland@amd.com>
Harry
> ---
> drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> index e93e18c06c0e..0a283d07fe10 100644
> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> @@ -6352,7 +6352,7 @@ static int amdgpu_dm_connector_get_modes(struct drm_connector *connector)
>
> encoder = amdgpu_dm_connector_to_encoder(connector);
>
> - if (!edid || !drm_edid_is_valid(edid)) {
> + if (!drm_edid_is_valid(edid)) {
> amdgpu_dm_connector->num_modes =
> drm_add_modes_noedid(connector, 640, 480);
> } else {
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] amd/display/amdgpu_dm: delete same check in if condition
2020-11-10 14:13 ` Harry Wentland
@ 2020-11-10 18:35 ` Alex Deucher
0 siblings, 0 replies; 3+ messages in thread
From: Alex Deucher @ 2020-11-10 18:35 UTC (permalink / raw)
To: Harry Wentland
Cc: Bernard Zhao, Leo Li, Alex Deucher, Christian König,
David Airlie, Daniel Vetter, Nicholas Kazlauskas,
Rodrigo Siqueira, Mikita Lipski, Stylon Wang, Bhawanpreet Lakha,
Roman Li, hersen wu, Aurabindo Pillai, Alexander Monakov,
amd-gfx list, Maling list - DRI developers, LKML,
opensource.kernel
Applied. Thanks!
Alex
On Tue, Nov 10, 2020 at 9:13 AM Harry Wentland <harry.wentland@amd.com> wrote:
>
> On 2020-11-10 3:03 a.m., Bernard Zhao wrote:
> > In function amdgpu_dm_connector_get_modes, drm_edid_is_valid
> > will check weather (!edid), no need to check again in the if
> > branch.
> >
> > Signed-off-by: Bernard Zhao <bernard@vivo.com>
>
> Reviewed-by: Harry Wentland <harry.wentland@amd.com>
>
> Harry
>
> > ---
> > drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> > index e93e18c06c0e..0a283d07fe10 100644
> > --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> > +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> > @@ -6352,7 +6352,7 @@ static int amdgpu_dm_connector_get_modes(struct drm_connector *connector)
> >
> > encoder = amdgpu_dm_connector_to_encoder(connector);
> >
> > - if (!edid || !drm_edid_is_valid(edid)) {
> > + if (!drm_edid_is_valid(edid)) {
> > amdgpu_dm_connector->num_modes =
> > drm_add_modes_noedid(connector, 640, 480);
> > } else {
> >
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-11-10 18:35 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-10 8:03 [PATCH] amd/display/amdgpu_dm: delete same check in if condition Bernard Zhao
2020-11-10 14:13 ` Harry Wentland
2020-11-10 18:35 ` Alex Deucher
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).