* [PATCH 1/2] phy: stm32: don't print an error on probe deferral
@ 2020-11-10 10:23 Amelie Delaunay
2020-11-10 10:23 ` [PATCH 2/2] phy: stm32: defer probe for reset controller Amelie Delaunay
2020-11-16 7:37 ` [PATCH 1/2] phy: stm32: don't print an error on probe deferral Vinod Koul
0 siblings, 2 replies; 6+ messages in thread
From: Amelie Delaunay @ 2020-11-10 10:23 UTC (permalink / raw)
To: Kishon Vijay Abraham I, Vinod Koul, Alexandre Torgue,
Maxime Coquelin, Etienne Carriere
Cc: linux-kernel, linux-arm-kernel, linux-stm32, Amelie Delaunay
Change stm32-usbphyc driver to not print an error message when the device
probe operation is deferred.
Signed-off-by: Etienne Carriere <etienne.carriere@st.com>
Signed-off-by: Amelie Delaunay <amelie.delaunay@st.com>
---
drivers/phy/st/phy-stm32-usbphyc.c | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/phy/st/phy-stm32-usbphyc.c b/drivers/phy/st/phy-stm32-usbphyc.c
index 2b3639cba51a..fe3085eec201 100644
--- a/drivers/phy/st/phy-stm32-usbphyc.c
+++ b/drivers/phy/st/phy-stm32-usbphyc.c
@@ -328,11 +328,8 @@ static int stm32_usbphyc_probe(struct platform_device *pdev)
return PTR_ERR(usbphyc->base);
usbphyc->clk = devm_clk_get(dev, NULL);
- if (IS_ERR(usbphyc->clk)) {
- ret = PTR_ERR(usbphyc->clk);
- dev_err(dev, "clk get failed: %d\n", ret);
- return ret;
- }
+ if (IS_ERR(usbphyc->clk))
+ dev_err_probe(dev, PTR_ERR(usbphyc->clk), "clk get_failed\n");
ret = clk_prepare_enable(usbphyc->clk);
if (ret) {
--
2.17.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 2/2] phy: stm32: defer probe for reset controller
2020-11-10 10:23 [PATCH 1/2] phy: stm32: don't print an error on probe deferral Amelie Delaunay
@ 2020-11-10 10:23 ` Amelie Delaunay
2020-11-16 7:37 ` [PATCH 1/2] phy: stm32: don't print an error on probe deferral Vinod Koul
1 sibling, 0 replies; 6+ messages in thread
From: Amelie Delaunay @ 2020-11-10 10:23 UTC (permalink / raw)
To: Kishon Vijay Abraham I, Vinod Koul, Alexandre Torgue,
Maxime Coquelin, Etienne Carriere
Cc: linux-kernel, linux-arm-kernel, linux-stm32, Amelie Delaunay
Change stm32-usbphyc driver to defer its probe when the expected reset
control has its probe operation deferred.
Signed-off-by: Etienne Carriere <etienne.carriere@st.com>
Signed-off-by: Amelie Delaunay <amelie.delaunay@st.com>
---
drivers/phy/st/phy-stm32-usbphyc.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/phy/st/phy-stm32-usbphyc.c b/drivers/phy/st/phy-stm32-usbphyc.c
index fe3085eec201..f3f582a3ccdb 100644
--- a/drivers/phy/st/phy-stm32-usbphyc.c
+++ b/drivers/phy/st/phy-stm32-usbphyc.c
@@ -342,6 +342,10 @@ static int stm32_usbphyc_probe(struct platform_device *pdev)
reset_control_assert(usbphyc->rst);
udelay(2);
reset_control_deassert(usbphyc->rst);
+ } else {
+ ret = PTR_ERR(usbphyc->rst);
+ if (ret == -EPROBE_DEFER)
+ goto clk_disable;
}
usbphyc->switch_setup = -EINVAL;
--
2.17.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] phy: stm32: don't print an error on probe deferral
2020-11-10 10:23 [PATCH 1/2] phy: stm32: don't print an error on probe deferral Amelie Delaunay
2020-11-10 10:23 ` [PATCH 2/2] phy: stm32: defer probe for reset controller Amelie Delaunay
@ 2020-11-16 7:37 ` Vinod Koul
2020-11-16 8:02 ` Amelie DELAUNAY
1 sibling, 1 reply; 6+ messages in thread
From: Vinod Koul @ 2020-11-16 7:37 UTC (permalink / raw)
To: Amelie Delaunay
Cc: Kishon Vijay Abraham I, Alexandre Torgue, Maxime Coquelin,
Etienne Carriere, linux-kernel, linux-arm-kernel, linux-stm32
On 10-11-20, 11:23, Amelie Delaunay wrote:
> Change stm32-usbphyc driver to not print an error message when the device
> probe operation is deferred.
Applied all, thanks
--
~Vinod
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] phy: stm32: don't print an error on probe deferral
2020-11-16 7:37 ` [PATCH 1/2] phy: stm32: don't print an error on probe deferral Vinod Koul
@ 2020-11-16 8:02 ` Amelie DELAUNAY
2020-11-16 9:50 ` Vinod Koul
0 siblings, 1 reply; 6+ messages in thread
From: Amelie DELAUNAY @ 2020-11-16 8:02 UTC (permalink / raw)
To: Vinod Koul
Cc: Kishon Vijay Abraham I, Alexandre Torgue, Maxime Coquelin,
Etienne Carriere, linux-kernel, linux-arm-kernel, linux-stm32
Hi Vinod,
On 11/16/20 8:37 AM, Vinod Koul wrote:
> On 10-11-20, 11:23, Amelie Delaunay wrote:
>> Change stm32-usbphyc driver to not print an error message when the device
>> probe operation is deferred.
>
> Applied all, thanks
>
I'm sorry for the mess, I sent a v2 for the patch 1/2:
https://lore.kernel.org/patchwork/patch/1336206/
Indeed, I forgot the "return" before dev_err_probe.
Do you want me to send a fix?
Regards,
Amelie
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] phy: stm32: don't print an error on probe deferral
2020-11-16 8:02 ` Amelie DELAUNAY
@ 2020-11-16 9:50 ` Vinod Koul
2020-11-16 10:18 ` Amelie DELAUNAY
0 siblings, 1 reply; 6+ messages in thread
From: Vinod Koul @ 2020-11-16 9:50 UTC (permalink / raw)
To: Amelie DELAUNAY
Cc: Kishon Vijay Abraham I, Alexandre Torgue, Maxime Coquelin,
Etienne Carriere, linux-kernel, linux-arm-kernel, linux-stm32
On 16-11-20, 09:02, Amelie DELAUNAY wrote:
> Hi Vinod,
>
> On 11/16/20 8:37 AM, Vinod Koul wrote:
> > On 10-11-20, 11:23, Amelie Delaunay wrote:
> > > Change stm32-usbphyc driver to not print an error message when the device
> > > probe operation is deferred.
> >
> > Applied all, thanks
> >
>
> I'm sorry for the mess, I sent a v2 for the patch 1/2:
> https://lore.kernel.org/patchwork/patch/1336206/
> Indeed, I forgot the "return" before dev_err_probe.
No worries, I have dropped this and picked v2.
Do check if the patches are fine.
Thanks for letting me know
--
~Vinod
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] phy: stm32: don't print an error on probe deferral
2020-11-16 9:50 ` Vinod Koul
@ 2020-11-16 10:18 ` Amelie DELAUNAY
0 siblings, 0 replies; 6+ messages in thread
From: Amelie DELAUNAY @ 2020-11-16 10:18 UTC (permalink / raw)
To: Vinod Koul
Cc: Kishon Vijay Abraham I, Alexandre Torgue, Maxime Coquelin,
Etienne Carriere, linux-kernel, linux-arm-kernel, linux-stm32
On 11/16/20 10:50 AM, Vinod Koul wrote:
> On 16-11-20, 09:02, Amelie DELAUNAY wrote:
>> Hi Vinod,
>>
>> On 11/16/20 8:37 AM, Vinod Koul wrote:
>>> On 10-11-20, 11:23, Amelie Delaunay wrote:
>>>> Change stm32-usbphyc driver to not print an error message when the device
>>>> probe operation is deferred.
>>>
>>> Applied all, thanks
>>>
>>
>> I'm sorry for the mess, I sent a v2 for the patch 1/2:
>> https://lore.kernel.org/patchwork/patch/1336206/
>> Indeed, I forgot the "return" before dev_err_probe.
>
> No worries, I have dropped this and picked v2.
> Do check if the patches are fine.
>
> Thanks for letting me know
>
All is fine now :) Thank you!
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-11-16 11:00 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-10 10:23 [PATCH 1/2] phy: stm32: don't print an error on probe deferral Amelie Delaunay
2020-11-10 10:23 ` [PATCH 2/2] phy: stm32: defer probe for reset controller Amelie Delaunay
2020-11-16 7:37 ` [PATCH 1/2] phy: stm32: don't print an error on probe deferral Vinod Koul
2020-11-16 8:02 ` Amelie DELAUNAY
2020-11-16 9:50 ` Vinod Koul
2020-11-16 10:18 ` Amelie DELAUNAY
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).