* [PATCH] RDMA/pvrdma: fix missing kfree in pvrdma_register_device
@ 2020-11-11 3:22 Qinglang Miao
2020-11-11 22:20 ` Adit Ranadive
2020-11-12 17:06 ` Jason Gunthorpe
0 siblings, 2 replies; 3+ messages in thread
From: Qinglang Miao @ 2020-11-11 3:22 UTC (permalink / raw)
To: Adit Ranadive, VMware PV-Drivers, Doug Ledford, Jason Gunthorpe
Cc: linux-rdma, linux-kernel, Qinglang Miao
Fix missing kfree in pvrdma_register_device() when fails
to do ib_device_set_netdev.
Fixes: 4b38da75e089 ("RDMA/drivers: Convert easy drivers to use ib_device_set_netdev()")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Qinglang Miao <miaoqinglang@huawei.com>
---
drivers/infiniband/hw/vmw_pvrdma/pvrdma_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/infiniband/hw/vmw_pvrdma/pvrdma_main.c b/drivers/infiniband/hw/vmw_pvrdma/pvrdma_main.c
index fa2a3fa0c3e4..f71d99946bed 100644
--- a/drivers/infiniband/hw/vmw_pvrdma/pvrdma_main.c
+++ b/drivers/infiniband/hw/vmw_pvrdma/pvrdma_main.c
@@ -266,7 +266,7 @@ static int pvrdma_register_device(struct pvrdma_dev *dev)
}
ret = ib_device_set_netdev(&dev->ib_dev, dev->netdev, 1);
if (ret)
- return ret;
+ goto err_qp_free;
spin_lock_init(&dev->srq_tbl_lock);
rdma_set_device_sysfs_group(&dev->ib_dev, &pvrdma_attr_group);
--
2.23.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] RDMA/pvrdma: fix missing kfree in pvrdma_register_device
2020-11-11 3:22 [PATCH] RDMA/pvrdma: fix missing kfree in pvrdma_register_device Qinglang Miao
@ 2020-11-11 22:20 ` Adit Ranadive
2020-11-12 17:06 ` Jason Gunthorpe
1 sibling, 0 replies; 3+ messages in thread
From: Adit Ranadive @ 2020-11-11 22:20 UTC (permalink / raw)
To: Qinglang Miao, VMware PV-Drivers, Doug Ledford, Jason Gunthorpe
Cc: linux-rdma, linux-kernel
On 11/10/20 7:22 PM, Qinglang Miao wrote:
> Fix missing kfree in pvrdma_register_device() when fails
> to do ib_device_set_netdev.
>
> Fixes: 4b38da75e089 ("RDMA/drivers: Convert easy drivers to use ib_device_set_netdev()")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Qinglang Miao <miaoqinglang@huawei.com>
> ---
> drivers/infiniband/hw/vmw_pvrdma/pvrdma_main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/infiniband/hw/vmw_pvrdma/pvrdma_main.c b/drivers/infiniband/hw/vmw_pvrdma/pvrdma_main.c
> index fa2a3fa0c3e4..f71d99946bed 100644
> --- a/drivers/infiniband/hw/vmw_pvrdma/pvrdma_main.c
> +++ b/drivers/infiniband/hw/vmw_pvrdma/pvrdma_main.c
> @@ -266,7 +266,7 @@ static int pvrdma_register_device(struct pvrdma_dev *dev)
> }
> ret = ib_device_set_netdev(&dev->ib_dev, dev->netdev, 1);
> if (ret)
> - return ret;
> + goto err_qp_free;
Thanks. This should be 'goto err_srq_free'.
> spin_lock_init(&dev->srq_tbl_lock);
> rdma_set_device_sysfs_group(&dev->ib_dev, &pvrdma_attr_group);
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] RDMA/pvrdma: fix missing kfree in pvrdma_register_device
2020-11-11 3:22 [PATCH] RDMA/pvrdma: fix missing kfree in pvrdma_register_device Qinglang Miao
2020-11-11 22:20 ` Adit Ranadive
@ 2020-11-12 17:06 ` Jason Gunthorpe
1 sibling, 0 replies; 3+ messages in thread
From: Jason Gunthorpe @ 2020-11-12 17:06 UTC (permalink / raw)
To: Qinglang Miao
Cc: Adit Ranadive, VMware PV-Drivers, Doug Ledford, linux-rdma, linux-kernel
On Wed, Nov 11, 2020 at 11:22:02AM +0800, Qinglang Miao wrote:
> Fix missing kfree in pvrdma_register_device() when fails
> to do ib_device_set_netdev.
>
> Fixes: 4b38da75e089 ("RDMA/drivers: Convert easy drivers to use ib_device_set_netdev()")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Qinglang Miao <miaoqinglang@huawei.com>
> ---
> drivers/infiniband/hw/vmw_pvrdma/pvrdma_main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied to for-rc with the 'goto err_srq_free' from Adit
Thanks,
Jason
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-11-12 17:07 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-11 3:22 [PATCH] RDMA/pvrdma: fix missing kfree in pvrdma_register_device Qinglang Miao
2020-11-11 22:20 ` Adit Ranadive
2020-11-12 17:06 ` Jason Gunthorpe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).