* [PATCH] net: dsa: sja1105: Fix return value check in sja1105_ptp_clock_register()
@ 2020-11-12 14:55 YueHaibing
2020-11-13 7:10 ` Kurt Kanzenbach
0 siblings, 1 reply; 2+ messages in thread
From: YueHaibing @ 2020-11-12 14:55 UTC (permalink / raw)
To: olteanv, andrew, vivien.didelot, f.fainelli, davem, kuba
Cc: linux-kernel, netdev, YueHaibing
drivers/net/dsa/sja1105/sja1105_ptp.c:869 sja1105_ptp_clock_register() warn: passing zero to 'PTR_ERR'
ptp_clock_register() returns ERR_PTR() and never returns
NULL. The NULL test should be removed.
Fixes: bb77f36ac21d ("net: dsa: sja1105: Add support for the PTP clock")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/net/dsa/sja1105/sja1105_ptp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/dsa/sja1105/sja1105_ptp.c b/drivers/net/dsa/sja1105/sja1105_ptp.c
index 1b90570b257b..1e41d491c854 100644
--- a/drivers/net/dsa/sja1105/sja1105_ptp.c
+++ b/drivers/net/dsa/sja1105/sja1105_ptp.c
@@ -865,7 +865,7 @@ int sja1105_ptp_clock_register(struct dsa_switch *ds)
spin_lock_init(&tagger_data->meta_lock);
ptp_data->clock = ptp_clock_register(&ptp_data->caps, ds->dev);
- if (IS_ERR_OR_NULL(ptp_data->clock))
+ if (IS_ERR(ptp_data->clock))
return PTR_ERR(ptp_data->clock);
ptp_data->cmd.corrclk4ts = true;
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] net: dsa: sja1105: Fix return value check in sja1105_ptp_clock_register()
2020-11-12 14:55 [PATCH] net: dsa: sja1105: Fix return value check in sja1105_ptp_clock_register() YueHaibing
@ 2020-11-13 7:10 ` Kurt Kanzenbach
0 siblings, 0 replies; 2+ messages in thread
From: Kurt Kanzenbach @ 2020-11-13 7:10 UTC (permalink / raw)
To: YueHaibing, olteanv, andrew, vivien.didelot, f.fainelli, davem, kuba
Cc: linux-kernel, netdev, YueHaibing, Richard Cochran
[-- Attachment #1: Type: text/plain, Size: 1576 bytes --]
On Thu Nov 12 2020, YueHaibing wrote:
> drivers/net/dsa/sja1105/sja1105_ptp.c:869 sja1105_ptp_clock_register() warn: passing zero to 'PTR_ERR'
>
> ptp_clock_register() returns ERR_PTR() and never returns
> NULL. The NULL test should be removed.
Which is not true. From the documentation:
* Returns a valid pointer on success or PTR_ERR on failure. If PHC
* support is missing at the configuration level, this function
* returns NULL, and drivers are expected to gracefully handle that
* case separately.
Please, always Cc Richard for PTP patches.
Actually you can have a look at this discussion here:
https://lkml.kernel.org/netdev/1605086686-5140-1-git-send-email-wangqing@vivo.com/
>
> Fixes: bb77f36ac21d ("net: dsa: sja1105: Add support for the PTP clock")
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> drivers/net/dsa/sja1105/sja1105_ptp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/dsa/sja1105/sja1105_ptp.c b/drivers/net/dsa/sja1105/sja1105_ptp.c
> index 1b90570b257b..1e41d491c854 100644
> --- a/drivers/net/dsa/sja1105/sja1105_ptp.c
> +++ b/drivers/net/dsa/sja1105/sja1105_ptp.c
> @@ -865,7 +865,7 @@ int sja1105_ptp_clock_register(struct dsa_switch *ds)
> spin_lock_init(&tagger_data->meta_lock);
>
> ptp_data->clock = ptp_clock_register(&ptp_data->caps, ds->dev);
> - if (IS_ERR_OR_NULL(ptp_data->clock))
> + if (IS_ERR(ptp_data->clock))
When you do this, you'll have to make sure that the driver handles the
NULL case "gracefully".
Thanks,
Kurt
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-11-13 7:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-12 14:55 [PATCH] net: dsa: sja1105: Fix return value check in sja1105_ptp_clock_register() YueHaibing
2020-11-13 7:10 ` Kurt Kanzenbach
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).