From: Lee Jones <lee.jones@linaro.org>
To: Enric Balletbo i Serra <enric.balletbo@collabora.com>
Cc: linux-kernel@vger.kernel.org,
Collabora Kernel ML <kernel@collabora.com>,
Nicolas Boichat <drinkcat@chromium.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH v2] mfd: syscon: Add syscon_regmap_lookup_by_phandle_optional() function.
Date: Fri, 13 Nov 2020 10:19:40 +0000 [thread overview]
Message-ID: <20201113101940.GH3718728@dell> (raw)
In-Reply-To: <20201110161338.18198-1-enric.balletbo@collabora.com>
On Tue, 10 Nov 2020, Enric Balletbo i Serra wrote:
> This adds syscon_regmap_lookup_by_phandle_optional() function to get an
> optional regmap.
>
> It behaves the same as syscon_regmap_lookup_by_phandle() except where
> there is no regmap phandle. In this case, instead of returning -ENODEV,
> the function returns NULL. This makes error checking simpler when the
> regmap phandle is optional.
>
> Suggested-by: Nicolas Boichat <drinkcat@chromium.org>
> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
> Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
> ---
>
> Changes in v2:
> - Add Matthias r-b tag.
> - Add the explanation from the patch description to the code.
> - Return NULL instead of -ENOTSUPP when regmap helpers are not enabled.
>
> drivers/mfd/syscon.c | 18 ++++++++++++++++++
> include/linux/mfd/syscon.h | 11 +++++++++++
> 2 files changed, 29 insertions(+)
Applied, thanks.
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2020-11-13 10:19 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-10 16:13 [PATCH v2] mfd: syscon: Add syscon_regmap_lookup_by_phandle_optional() function Enric Balletbo i Serra
2020-11-11 10:15 ` Arnd Bergmann
2020-11-13 10:19 ` Lee Jones [this message]
2020-11-17 12:05 ` Matthias Brugger
2020-11-17 12:37 ` Lee Jones
2020-11-17 15:17 ` Matthias Brugger
2020-11-17 16:05 ` Lee Jones
2020-11-17 16:40 ` Arnd Bergmann
2020-11-18 14:56 ` Matthias Brugger
2020-11-19 8:32 ` Lee Jones
2020-11-19 16:57 ` Matthias Brugger
2020-11-19 8:33 ` [GIT PULL] Immutable branch between MFD and MediaTek due for the v5.11 merge window Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201113101940.GH3718728@dell \
--to=lee.jones@linaro.org \
--cc=arnd@arndb.de \
--cc=drinkcat@chromium.org \
--cc=enric.balletbo@collabora.com \
--cc=kernel@collabora.com \
--cc=linux-kernel@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).