From: Matthias Brugger <matthias.bgg@gmail.com>
To: Lee Jones <lee.jones@linaro.org>
Cc: Enric Balletbo i Serra <enric.balletbo@collabora.com>,
linux-kernel@vger.kernel.org,
Collabora Kernel ML <kernel@collabora.com>,
Nicolas Boichat <drinkcat@chromium.org>,
Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH v2] mfd: syscon: Add syscon_regmap_lookup_by_phandle_optional() function.
Date: Tue, 17 Nov 2020 16:17:51 +0100 [thread overview]
Message-ID: <d4424323-25a9-9f70-b2c8-ce464180f788@gmail.com> (raw)
In-Reply-To: <20201117123741.GH1869941@dell>
On 17/11/2020 13:37, Lee Jones wrote:
> On Tue, 17 Nov 2020, Matthias Brugger wrote:
>
>> Hi Lee,
>>
>> On 13/11/2020 11:19, Lee Jones wrote:
>>> On Tue, 10 Nov 2020, Enric Balletbo i Serra wrote:
>>>
>>>> This adds syscon_regmap_lookup_by_phandle_optional() function to get an
>>>> optional regmap.
>>>>
>>>> It behaves the same as syscon_regmap_lookup_by_phandle() except where
>>>> there is no regmap phandle. In this case, instead of returning -ENODEV,
>>>> the function returns NULL. This makes error checking simpler when the
>>>> regmap phandle is optional.
>>>>
>>>> Suggested-by: Nicolas Boichat <drinkcat@chromium.org>
>>>> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
>>>> Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
>>>> ---
>>>>
>>>> Changes in v2:
>>>> - Add Matthias r-b tag.
>>>> - Add the explanation from the patch description to the code.
>>>> - Return NULL instead of -ENOTSUPP when regmap helpers are not enabled.
>>>>
>>>> drivers/mfd/syscon.c | 18 ++++++++++++++++++
>>>> include/linux/mfd/syscon.h | 11 +++++++++++
>>>> 2 files changed, 29 insertions(+)
>>>
>>> Applied, thanks.
>>>
>>
>> I've a series [1] that's based on this patch, could you provide a stable
>> branch for it, so that I can take the series.
>
> Why can't you base it off of for-mfd-next?
>
> https://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git/log/?h=for-mfd-next
>
I can do that, if you are willing to not overwrite the commit history. In my
case it can happen that I drop a patch from my for-next branch as I realize that
it e.g. breaks something. I think that's the reason why normally a stable branch
get's created, as the commit ID won't change although you change the commit
history of your for-mfd-next branch.
If you want to go the route for me rebasing my tree on top of for-mfd-next then
I'd like to have at least a stable tag, so that it will be easier to provide the
pull-request later on. Would that be a compromise?
Regards,
Matthias
next prev parent reply other threads:[~2020-11-17 15:18 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-10 16:13 [PATCH v2] mfd: syscon: Add syscon_regmap_lookup_by_phandle_optional() function Enric Balletbo i Serra
2020-11-11 10:15 ` Arnd Bergmann
2020-11-13 10:19 ` Lee Jones
2020-11-17 12:05 ` Matthias Brugger
2020-11-17 12:37 ` Lee Jones
2020-11-17 15:17 ` Matthias Brugger [this message]
2020-11-17 16:05 ` Lee Jones
2020-11-17 16:40 ` Arnd Bergmann
2020-11-18 14:56 ` Matthias Brugger
2020-11-19 8:32 ` Lee Jones
2020-11-19 16:57 ` Matthias Brugger
2020-11-19 8:33 ` [GIT PULL] Immutable branch between MFD and MediaTek due for the v5.11 merge window Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d4424323-25a9-9f70-b2c8-ce464180f788@gmail.com \
--to=matthias.bgg@gmail.com \
--cc=arnd@arndb.de \
--cc=drinkcat@chromium.org \
--cc=enric.balletbo@collabora.com \
--cc=kernel@collabora.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).