Re: [PATCH 2/2] dmaengine: dma: Add Hiedma Controller v310 Device Driver

From: kernel test robot <lkp@intel.com>
To: Dongjiu Geng <gengdongjiu@huawei.com>,
	vkoul@kernel.org, robh+dt@kernel.org, dan.j.williams@intel.com,
	p.zabel@pengutronix.de, dmaengine@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: kbuild-all@lists.01.org
Subject: Re: [PATCH 2/2] dmaengine: dma: Add Hiedma Controller v310 Device Driver
Date: Mon, 16 Nov 2020 04:10:00 +0800	[thread overview]
Message-ID: <202011160422.hs0ud34q-lkp@intel.com> (raw)
In-Reply-To: <20201114003440.36458-2-gengdongjiu@huawei.com>

[-- Attachment #1: Type: text/plain, Size: 3001 bytes --]

Hi Dongjiu,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on vkoul-dmaengine/next]
[also build test WARNING on robh/for-next pza/reset/next v5.10-rc3 next-20201113]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Dongjiu-Geng/dt-bindings-dma-Add-DT-bindings-for-HiSilicon-Hiedma-Controller/20201114-001353
base:   https://git.kernel.org/pub/scm/linux/kernel/git/vkoul/dmaengine.git next
config: arm64-allyesconfig (attached as .config)
compiler: aarch64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/bafd07a67a5daf6eefedcd050312e9ee307c255a
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Dongjiu-Geng/dt-bindings-dma-Add-DT-bindings-for-HiSilicon-Hiedma-Controller/20201114-001353
        git checkout bafd07a67a5daf6eefedcd050312e9ee307c255a
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arm64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> drivers/dma/hiedmacv310.c:144:6: warning: no previous prototype for 'dump_lli' [-Wmissing-prototypes]
     144 | void dump_lli(u64 *llis_vaddr, unsigned int num)
         |      ^~~~~~~~
   drivers/dma/hiedmacv310.c: In function 'hiedmac_pause_phy_chan':
>> drivers/dma/hiedmacv310.c:527:28: warning: suggest braces around empty body in an 'if' statement [-Wempty-body]
     527 |       phychan->id, timeout);
         |                            ^
   drivers/dma/hiedmacv310.c: At top level:
>> drivers/dma/hiedmacv310.c:650:23: warning: no previous prototype for 'hiedmac_init_tsf_desc' [-Wmissing-prototypes]
     650 | struct transfer_desc *hiedmac_init_tsf_desc(struct dma_chan *chan,
         |                       ^~~~~~~~~~~~~~~~~~~~~
>> drivers/dma/hiedmacv310.c:1088:6: warning: no previous prototype for 'handle_irq' [-Wmissing-prototypes]
    1088 | bool handle_irq(struct hiedmacv310_driver_data *hiedmac, int chan_id)
         |      ^~~~~~~~~~
>> drivers/dma/hiedmacv310.c:1210:6: warning: no previous prototype for 'hiedmac_free_virt_channels' [-Wmissing-prototypes]
    1210 | void hiedmac_free_virt_channels(struct dma_device *dmadev)
         |      ^~~~~~~~~~~~~~~~~~~~~~~~~~

vim +/dump_lli +144 drivers/dma/hiedmacv310.c

   142	
   143	#else
 > 144	void dump_lli(u64 *llis_vaddr, unsigned int num)
   145	{
   146	}
   147	#endif
   148	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 75391 bytes --]