From: Dongjiu Geng <gengdongjiu@huawei.com>
To: Rob Herring <robh@kernel.org>
Cc: <dmaengine@vger.kernel.org>, <robh+dt@kernel.org>,
<dan.j.williams@intel.com>, <devicetree@vger.kernel.org>,
<p.zabel@pengutronix.de>, <vkoul@kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] dt: bindings: dma: Add DT bindings for HiSilicon Hiedma Controller
Date: Thu, 19 Nov 2020 19:40:42 +0800 [thread overview]
Message-ID: <230b73c0-3240-13ce-a115-6c3bdc1e476a@huawei.com> (raw)
In-Reply-To: <20201116152725.GB1646380@bogus>
On 2020/11/16 23:27, Rob Herring wrote:
> On Sat, 14 Nov 2020 00:34:39 +0000, Dongjiu Geng wrote:
>> The Hiedma Controller v310 Provides eight DMA channels, each
>> channel can be configured for one-way transfer. The data can
>> be transferred in 8-bit, 16-bit, 32-bit, or 64-bit mode. This
>> documentation describes DT bindings of this controller.
>>
>> Signed-off-by: Dongjiu Geng <gengdongjiu@huawei.com>
>> ---
>> .../bindings/dma/hisilicon,hiedmacv310.yaml | 80 +++++++++++++++++++
>> 1 file changed, 80 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/dma/hisilicon,hiedmacv310.yaml
>>
>
>
> My bot found errors running 'make dt_binding_check' on your patch:
>
> yamllint warnings/errors:
>
> dtschema/dtc warnings/errors:
> Documentation/devicetree/bindings/dma/hisilicon,hiedmacv310.example.dts:20:18: fatal error: dt-bindings/clock/hi3559av100-clock.h: No such file or directory
> 20 | #include <dt-bindings/clock/hi3559av100-clock.h>
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> compilation terminated.
> make[1]: *** [scripts/Makefile.lib:342: Documentation/devicetree/bindings/dma/hisilicon,hiedmacv310.example.dt.yaml] Error 1
> make[1]: *** Waiting for unfinished jobs....
> make: *** [Makefile:1364: dt_binding_check] Error 2
Rob,
Because it needs to include“#include <dt-bindings/clock/hi3559av100-clock.h>”, so I combine the new modified series patches to this series "[PATCH v4 0/4] Enable Hi3559A SOC clock and HiSilicon Hiedma Controller"
See https://lore.kernel.org/patchwork/cover/1341544/
>
>
> See https://patchwork.ozlabs.org/patch/1399915
>
> The base for the patch is generally the last rc1. Any dependencies
> should be noted.
>
> If you already ran 'make dt_binding_check' and didn't see the above
> error(s), then make sure 'yamllint' is installed and dt-schema is up to
> date:
>
> pip3 install dtschema --upgrade
>
> Please check and re-submit.
>
> .
>
next prev parent reply other threads:[~2020-11-19 11:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-14 0:34 [PATCH 1/2] dt: bindings: dma: Add DT bindings for HiSilicon Hiedma Controller Dongjiu Geng
2020-11-14 0:34 ` [PATCH 2/2] dmaengine: dma: Add Hiedma Controller v310 Device Driver Dongjiu Geng
2020-11-15 20:10 ` kernel test robot
2020-11-16 15:27 ` [PATCH 1/2] dt: bindings: dma: Add DT bindings for HiSilicon Hiedma Controller Rob Herring
2020-11-16 15:27 ` Rob Herring
2020-11-19 11:40 ` Dongjiu Geng [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-11-14 0:34 Dongjiu Geng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=230b73c0-3240-13ce-a115-6c3bdc1e476a@huawei.com \
--to=gengdongjiu@huawei.com \
--cc=dan.j.williams@intel.com \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).