* [PATCH] Bluetooth: btmtksdio: Add the missed release_firmware() in mtk_setup_firmware()
@ 2020-11-17 2:43 Jing Xiangfeng
2020-11-23 11:51 ` Marcel Holtmann
0 siblings, 1 reply; 2+ messages in thread
From: Jing Xiangfeng @ 2020-11-17 2:43 UTC (permalink / raw)
To: marcel, johan.hedberg, matthias.bgg, Mark-YW.Chen, sean.wang
Cc: linux-bluetooth, linux-arm-kernel, linux-mediatek, linux-kernel,
jingxiangfeng
mtk_setup_firmware() misses to call release_firmware() in an error
path. Jump to free_fw to fix it.
Fixes: 737cd06072a7 ("Bluetooth: btmtksdio: fix up firmware download sequence")
Signed-off-by: Jing Xiangfeng <jingxiangfeng@huawei.com>
---
drivers/bluetooth/btmtksdio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/bluetooth/btmtksdio.c b/drivers/bluetooth/btmtksdio.c
index c7ab7a23bd67..c2677ffbd3c0 100644
--- a/drivers/bluetooth/btmtksdio.c
+++ b/drivers/bluetooth/btmtksdio.c
@@ -704,7 +704,7 @@ static int mtk_setup_firmware(struct hci_dev *hdev, const char *fwname)
err = mtk_hci_wmt_sync(hdev, &wmt_params);
if (err < 0) {
bt_dev_err(hdev, "Failed to power on data RAM (%d)", err);
- return err;
+ goto free_fw;
}
fw_ptr = fw->data;
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Bluetooth: btmtksdio: Add the missed release_firmware() in mtk_setup_firmware()
2020-11-17 2:43 [PATCH] Bluetooth: btmtksdio: Add the missed release_firmware() in mtk_setup_firmware() Jing Xiangfeng
@ 2020-11-23 11:51 ` Marcel Holtmann
0 siblings, 0 replies; 2+ messages in thread
From: Marcel Holtmann @ 2020-11-23 11:51 UTC (permalink / raw)
To: Jing Xiangfeng
Cc: Johan Hedberg, matthias.bgg, Mark-YW.Chen, sean.wang,
linux-bluetooth, linux-arm-kernel, linux-mediatek, linux-kernel
Hi Jing,
> mtk_setup_firmware() misses to call release_firmware() in an error
> path. Jump to free_fw to fix it.
>
> Fixes: 737cd06072a7 ("Bluetooth: btmtksdio: fix up firmware download sequence")
> Signed-off-by: Jing Xiangfeng <jingxiangfeng@huawei.com>
> ---
> drivers/bluetooth/btmtksdio.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
patch has been applied to bluetooth-next tree.
Regards
Marcel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-11-23 11:51 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-17 2:43 [PATCH] Bluetooth: btmtksdio: Add the missed release_firmware() in mtk_setup_firmware() Jing Xiangfeng
2020-11-23 11:51 ` Marcel Holtmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).