* [PATCH] ipmi/watchdog: replace atomic_add() and atomic_sub()
@ 2020-11-16 7:30 Yejune Deng
2020-11-17 13:14 ` Corey Minyard
0 siblings, 1 reply; 2+ messages in thread
From: Yejune Deng @ 2020-11-16 7:30 UTC (permalink / raw)
To: minyard; +Cc: openipmi-developer, linux-kernel, yejune.deng
atomic_inc() and atomic_dec() looks better
Signed-off-by: Yejune Deng <yejune.deng@gmail.com>
---
drivers/char/ipmi/ipmi_watchdog.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/char/ipmi/ipmi_watchdog.c b/drivers/char/ipmi/ipmi_watchdog.c
index f78156d..32c334e 100644
--- a/drivers/char/ipmi/ipmi_watchdog.c
+++ b/drivers/char/ipmi/ipmi_watchdog.c
@@ -495,7 +495,7 @@ static void panic_halt_ipmi_heartbeat(void)
msg.cmd = IPMI_WDOG_RESET_TIMER;
msg.data = NULL;
msg.data_len = 0;
- atomic_add(1, &panic_done_count);
+ atomic_inc(&panic_done_count);
rv = ipmi_request_supply_msgs(watchdog_user,
(struct ipmi_addr *) &addr,
0,
@@ -505,7 +505,7 @@ static void panic_halt_ipmi_heartbeat(void)
&panic_halt_heartbeat_recv_msg,
1);
if (rv)
- atomic_sub(1, &panic_done_count);
+ atomic_dec(&panic_done_count);
}
static struct ipmi_smi_msg panic_halt_smi_msg = {
@@ -529,12 +529,12 @@ static void panic_halt_ipmi_set_timeout(void)
/* Wait for the messages to be free. */
while (atomic_read(&panic_done_count) != 0)
ipmi_poll_interface(watchdog_user);
- atomic_add(1, &panic_done_count);
+ atomic_inc(&panic_done_count);
rv = __ipmi_set_timeout(&panic_halt_smi_msg,
&panic_halt_recv_msg,
&send_heartbeat_now);
if (rv) {
- atomic_sub(1, &panic_done_count);
+ atomic_dec(&panic_done_count);
pr_warn("Unable to extend the watchdog timeout\n");
} else {
if (send_heartbeat_now)
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ipmi/watchdog: replace atomic_add() and atomic_sub()
2020-11-16 7:30 [PATCH] ipmi/watchdog: replace atomic_add() and atomic_sub() Yejune Deng
@ 2020-11-17 13:14 ` Corey Minyard
0 siblings, 0 replies; 2+ messages in thread
From: Corey Minyard @ 2020-11-17 13:14 UTC (permalink / raw)
To: Yejune Deng; +Cc: openipmi-developer, linux-kernel
On Mon, Nov 16, 2020 at 03:30:07PM +0800, Yejune Deng wrote:
> atomic_inc() and atomic_dec() looks better
Yes, that's a little neater. Queued for next release.
Thanks,
-corey
>
> Signed-off-by: Yejune Deng <yejune.deng@gmail.com>
> ---
> drivers/char/ipmi/ipmi_watchdog.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/char/ipmi/ipmi_watchdog.c b/drivers/char/ipmi/ipmi_watchdog.c
> index f78156d..32c334e 100644
> --- a/drivers/char/ipmi/ipmi_watchdog.c
> +++ b/drivers/char/ipmi/ipmi_watchdog.c
> @@ -495,7 +495,7 @@ static void panic_halt_ipmi_heartbeat(void)
> msg.cmd = IPMI_WDOG_RESET_TIMER;
> msg.data = NULL;
> msg.data_len = 0;
> - atomic_add(1, &panic_done_count);
> + atomic_inc(&panic_done_count);
> rv = ipmi_request_supply_msgs(watchdog_user,
> (struct ipmi_addr *) &addr,
> 0,
> @@ -505,7 +505,7 @@ static void panic_halt_ipmi_heartbeat(void)
> &panic_halt_heartbeat_recv_msg,
> 1);
> if (rv)
> - atomic_sub(1, &panic_done_count);
> + atomic_dec(&panic_done_count);
> }
>
> static struct ipmi_smi_msg panic_halt_smi_msg = {
> @@ -529,12 +529,12 @@ static void panic_halt_ipmi_set_timeout(void)
> /* Wait for the messages to be free. */
> while (atomic_read(&panic_done_count) != 0)
> ipmi_poll_interface(watchdog_user);
> - atomic_add(1, &panic_done_count);
> + atomic_inc(&panic_done_count);
> rv = __ipmi_set_timeout(&panic_halt_smi_msg,
> &panic_halt_recv_msg,
> &send_heartbeat_now);
> if (rv) {
> - atomic_sub(1, &panic_done_count);
> + atomic_dec(&panic_done_count);
> pr_warn("Unable to extend the watchdog timeout\n");
> } else {
> if (send_heartbeat_now)
> --
> 1.9.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-11-17 14:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-16 7:30 [PATCH] ipmi/watchdog: replace atomic_add() and atomic_sub() Yejune Deng
2020-11-17 13:14 ` Corey Minyard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).