From: Jakub Kicinski <kuba@kernel.org>
To: Simon Horman <simon.horman@netronome.com>
Cc: "Gustavo A. R. Silva" <gustavoars@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
oss-drivers@netronome.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH][next] nfp: tls: Fix unreachable code issue
Date: Wed, 18 Nov 2020 10:48:58 -0800 [thread overview]
Message-ID: <20201118104858.283cfd87@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net> (raw)
In-Reply-To: <20201117200646.GA10136@netronome.com>
On Tue, 17 Nov 2020 21:06:47 +0100 Simon Horman wrote:
> On Tue, Nov 17, 2020 at 11:13:47AM -0600, Gustavo A. R. Silva wrote:
> > Fix the following unreachable code issue:
> >
> > drivers/net/ethernet/netronome/nfp/crypto/tls.c: In function 'nfp_net_tls_add':
> > include/linux/compiler_attributes.h:208:41: warning: statement will never be executed [-Wswitch-unreachable]
> > 208 | # define fallthrough __attribute__((__fallthrough__))
> > | ^~~~~~~~~~~~~
> > drivers/net/ethernet/netronome/nfp/crypto/tls.c:299:3: note: in expansion of macro 'fallthrough'
> > 299 | fallthrough;
> > | ^~~~~~~~~~~
> >
> > Reported-by: kernel test robot <lkp@intel.com>
> > Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
>
> Reviewed-by: Simon Horman <simon.horman@netronome.com>
Applied, thanks!
prev parent reply other threads:[~2020-11-18 18:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-17 17:13 [PATCH][next] nfp: tls: Fix unreachable code issue Gustavo A. R. Silva
2020-11-17 20:06 ` Simon Horman
2020-11-18 18:48 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201118104858.283cfd87@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=gustavoars@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=oss-drivers@netronome.com \
--cc=simon.horman@netronome.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).