linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] net: usb: qmi_wwan: Set DTR quirk for MR400
@ 2020-11-17 17:36 Filip Moc
  2020-11-17 19:22 ` Bjørn Mork
  0 siblings, 1 reply; 3+ messages in thread
From: Filip Moc @ 2020-11-17 17:36 UTC (permalink / raw)
  To: linux-kernel
  Cc: Bjørn Mork, David S. Miller, Jakub Kicinski, netdev,
	linux-usb, Filip Moc

LTE module MR400 embedded in TL-MR6400 v4 requires DTR to be set.

Signed-off-by: Filip Moc <dev@moc6.cz>
---
 drivers/net/usb/qmi_wwan.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/usb/qmi_wwan.c b/drivers/net/usb/qmi_wwan.c
index afeb09b9624e..d166c321ee9b 100644
--- a/drivers/net/usb/qmi_wwan.c
+++ b/drivers/net/usb/qmi_wwan.c
@@ -1047,7 +1047,7 @@ static const struct usb_device_id products[] = {
 	{QMI_FIXED_INTF(0x05c6, 0x9011, 4)},
 	{QMI_FIXED_INTF(0x05c6, 0x9021, 1)},
 	{QMI_FIXED_INTF(0x05c6, 0x9022, 2)},
-	{QMI_FIXED_INTF(0x05c6, 0x9025, 4)},	/* Alcatel-sbell ASB TL131 TDD LTE  (China Mobile) */
+	{QMI_QUIRK_SET_DTR(0x05c6, 0x9025, 4)},	/* Alcatel-sbell ASB TL131 TDD LTE (China Mobile) */
 	{QMI_FIXED_INTF(0x05c6, 0x9026, 3)},
 	{QMI_FIXED_INTF(0x05c6, 0x902e, 5)},
 	{QMI_FIXED_INTF(0x05c6, 0x9031, 5)},
-- 
2.28.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] net: usb: qmi_wwan: Set DTR quirk for MR400
  2020-11-17 17:36 [PATCH] net: usb: qmi_wwan: Set DTR quirk for MR400 Filip Moc
@ 2020-11-17 19:22 ` Bjørn Mork
  2020-11-18 18:49   ` Jakub Kicinski
  0 siblings, 1 reply; 3+ messages in thread
From: Bjørn Mork @ 2020-11-17 19:22 UTC (permalink / raw)
  To: Filip Moc
  Cc: linux-kernel, David S. Miller, Jakub Kicinski, netdev, linux-usb

Filip Moc <dev@moc6.cz> writes:

> LTE module MR400 embedded in TL-MR6400 v4 requires DTR to be set.
>
> Signed-off-by: Filip Moc <dev@moc6.cz>
> ---
>  drivers/net/usb/qmi_wwan.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/usb/qmi_wwan.c b/drivers/net/usb/qmi_wwan.c
> index afeb09b9624e..d166c321ee9b 100644
> --- a/drivers/net/usb/qmi_wwan.c
> +++ b/drivers/net/usb/qmi_wwan.c
> @@ -1047,7 +1047,7 @@ static const struct usb_device_id products[] = {
>  	{QMI_FIXED_INTF(0x05c6, 0x9011, 4)},
>  	{QMI_FIXED_INTF(0x05c6, 0x9021, 1)},
>  	{QMI_FIXED_INTF(0x05c6, 0x9022, 2)},
> -	{QMI_FIXED_INTF(0x05c6, 0x9025, 4)},	/* Alcatel-sbell ASB TL131 TDD LTE  (China Mobile) */
> +	{QMI_QUIRK_SET_DTR(0x05c6, 0x9025, 4)},	/* Alcatel-sbell ASB TL131 TDD LTE (China Mobile) */
>  	{QMI_FIXED_INTF(0x05c6, 0x9026, 3)},
>  	{QMI_FIXED_INTF(0x05c6, 0x902e, 5)},
>  	{QMI_FIXED_INTF(0x05c6, 0x9031, 5)},

Acked-by: Bjørn Mork <bjorn@mork.no>

This fix should probably go to net+stable.


Thanks,
Bjørn

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] net: usb: qmi_wwan: Set DTR quirk for MR400
  2020-11-17 19:22 ` Bjørn Mork
@ 2020-11-18 18:49   ` Jakub Kicinski
  0 siblings, 0 replies; 3+ messages in thread
From: Jakub Kicinski @ 2020-11-18 18:49 UTC (permalink / raw)
  To: Bjørn Mork
  Cc: Filip Moc, linux-kernel, David S. Miller, netdev, linux-usb

On Tue, 17 Nov 2020 20:22:03 +0100 Bjørn Mork wrote:
> Filip Moc <dev@moc6.cz> writes:
> 
> > LTE module MR400 embedded in TL-MR6400 v4 requires DTR to be set.
> >
> > Signed-off-by: Filip Moc <dev@moc6.cz>
> > ---
> >  drivers/net/usb/qmi_wwan.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/net/usb/qmi_wwan.c b/drivers/net/usb/qmi_wwan.c
> > index afeb09b9624e..d166c321ee9b 100644
> > --- a/drivers/net/usb/qmi_wwan.c
> > +++ b/drivers/net/usb/qmi_wwan.c
> > @@ -1047,7 +1047,7 @@ static const struct usb_device_id products[] = {
> >  	{QMI_FIXED_INTF(0x05c6, 0x9011, 4)},
> >  	{QMI_FIXED_INTF(0x05c6, 0x9021, 1)},
> >  	{QMI_FIXED_INTF(0x05c6, 0x9022, 2)},
> > -	{QMI_FIXED_INTF(0x05c6, 0x9025, 4)},	/* Alcatel-sbell ASB TL131 TDD LTE  (China Mobile) */
> > +	{QMI_QUIRK_SET_DTR(0x05c6, 0x9025, 4)},	/* Alcatel-sbell ASB TL131 TDD LTE (China Mobile) */
> >  	{QMI_FIXED_INTF(0x05c6, 0x9026, 3)},
> >  	{QMI_FIXED_INTF(0x05c6, 0x902e, 5)},
> >  	{QMI_FIXED_INTF(0x05c6, 0x9031, 5)},  
> 
> Acked-by: Bjørn Mork <bjorn@mork.no>
> 
> This fix should probably go to net+stable.

Done, thanks!

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-11-18 18:50 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-17 17:36 [PATCH] net: usb: qmi_wwan: Set DTR quirk for MR400 Filip Moc
2020-11-17 19:22 ` Bjørn Mork
2020-11-18 18:49   ` Jakub Kicinski

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).