* [PATCH v2] interconnect: qcom: qcs404: Remove GPU and display RPM IDs
@ 2020-11-18 11:10 Georgi Djakov
2020-11-18 21:07 ` Mike Tipton
2020-11-19 5:45 ` Bjorn Andersson
0 siblings, 2 replies; 3+ messages in thread
From: Georgi Djakov @ 2020-11-18 11:10 UTC (permalink / raw)
To: mdtipton, bjorn.andersson, linux-pm
Cc: linux-arm-msm, linux-kernel, georgi.djakov
The following errors are noticed during boot on a QCS404 board:
[ 2.926647] qcom_icc_rpm_smd_send mas 6 error -6
[ 2.934573] qcom_icc_rpm_smd_send mas 8 error -6
These errors show when we try to configure the GPU and display nodes.
Since these particular nodes aren't supported on RPM and are purely
local, we should just change their mas_rpm_id to -1 to avoid any
requests being sent for these master IDs.
Signed-off-by: Georgi Djakov <georgi.djakov@linaro.org>
---
v2:
* Keep the nodes and just set the IDs to -1, as suggested by Mike.
v1: http://lore.kernel.org/r/20201111100734.307-1-georgi.djakov@linaro.org
drivers/interconnect/qcom/qcs404.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/interconnect/qcom/qcs404.c b/drivers/interconnect/qcom/qcs404.c
index d4769a5ea182..9820709b43db 100644
--- a/drivers/interconnect/qcom/qcs404.c
+++ b/drivers/interconnect/qcom/qcs404.c
@@ -157,8 +157,8 @@ struct qcom_icc_desc {
}
DEFINE_QNODE(mas_apps_proc, QCS404_MASTER_AMPSS_M0, 8, 0, -1, QCS404_SLAVE_EBI_CH0, QCS404_BIMC_SNOC_SLV);
-DEFINE_QNODE(mas_oxili, QCS404_MASTER_GRAPHICS_3D, 8, 6, -1, QCS404_SLAVE_EBI_CH0, QCS404_BIMC_SNOC_SLV);
-DEFINE_QNODE(mas_mdp, QCS404_MASTER_MDP_PORT0, 8, 8, -1, QCS404_SLAVE_EBI_CH0, QCS404_BIMC_SNOC_SLV);
+DEFINE_QNODE(mas_oxili, QCS404_MASTER_GRAPHICS_3D, 8, -1, -1, QCS404_SLAVE_EBI_CH0, QCS404_BIMC_SNOC_SLV);
+DEFINE_QNODE(mas_mdp, QCS404_MASTER_MDP_PORT0, 8, -1, -1, QCS404_SLAVE_EBI_CH0, QCS404_BIMC_SNOC_SLV);
DEFINE_QNODE(mas_snoc_bimc_1, QCS404_SNOC_BIMC_1_MAS, 8, 76, -1, QCS404_SLAVE_EBI_CH0);
DEFINE_QNODE(mas_tcu_0, QCS404_MASTER_TCU_0, 8, -1, -1, QCS404_SLAVE_EBI_CH0, QCS404_BIMC_SNOC_SLV);
DEFINE_QNODE(mas_spdm, QCS404_MASTER_SPDM, 4, -1, -1, QCS404_PNOC_INT_3);
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] interconnect: qcom: qcs404: Remove GPU and display RPM IDs
2020-11-18 11:10 [PATCH v2] interconnect: qcom: qcs404: Remove GPU and display RPM IDs Georgi Djakov
@ 2020-11-18 21:07 ` Mike Tipton
2020-11-19 5:45 ` Bjorn Andersson
1 sibling, 0 replies; 3+ messages in thread
From: Mike Tipton @ 2020-11-18 21:07 UTC (permalink / raw)
To: Georgi Djakov, bjorn.andersson, linux-pm; +Cc: linux-arm-msm, linux-kernel
On 11/18/2020 3:10 AM, Georgi Djakov wrote:
> The following errors are noticed during boot on a QCS404 board:
> [ 2.926647] qcom_icc_rpm_smd_send mas 6 error -6
> [ 2.934573] qcom_icc_rpm_smd_send mas 8 error -6
>
> These errors show when we try to configure the GPU and display nodes.
> Since these particular nodes aren't supported on RPM and are purely
> local, we should just change their mas_rpm_id to -1 to avoid any
> requests being sent for these master IDs.
>
> Signed-off-by: Georgi Djakov <georgi.djakov@linaro.org>
Reviewed-by: Mike Tipton <mdtipton@codeaurora.org>
> ---
>
> v2:
> * Keep the nodes and just set the IDs to -1, as suggested by Mike.
>
> v1: http://lore.kernel.org/r/20201111100734.307-1-georgi.djakov@linaro.org
>
> drivers/interconnect/qcom/qcs404.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/interconnect/qcom/qcs404.c b/drivers/interconnect/qcom/qcs404.c
> index d4769a5ea182..9820709b43db 100644
> --- a/drivers/interconnect/qcom/qcs404.c
> +++ b/drivers/interconnect/qcom/qcs404.c
> @@ -157,8 +157,8 @@ struct qcom_icc_desc {
> }
>
> DEFINE_QNODE(mas_apps_proc, QCS404_MASTER_AMPSS_M0, 8, 0, -1, QCS404_SLAVE_EBI_CH0, QCS404_BIMC_SNOC_SLV);
> -DEFINE_QNODE(mas_oxili, QCS404_MASTER_GRAPHICS_3D, 8, 6, -1, QCS404_SLAVE_EBI_CH0, QCS404_BIMC_SNOC_SLV);
> -DEFINE_QNODE(mas_mdp, QCS404_MASTER_MDP_PORT0, 8, 8, -1, QCS404_SLAVE_EBI_CH0, QCS404_BIMC_SNOC_SLV);
> +DEFINE_QNODE(mas_oxili, QCS404_MASTER_GRAPHICS_3D, 8, -1, -1, QCS404_SLAVE_EBI_CH0, QCS404_BIMC_SNOC_SLV);
> +DEFINE_QNODE(mas_mdp, QCS404_MASTER_MDP_PORT0, 8, -1, -1, QCS404_SLAVE_EBI_CH0, QCS404_BIMC_SNOC_SLV);
> DEFINE_QNODE(mas_snoc_bimc_1, QCS404_SNOC_BIMC_1_MAS, 8, 76, -1, QCS404_SLAVE_EBI_CH0);
> DEFINE_QNODE(mas_tcu_0, QCS404_MASTER_TCU_0, 8, -1, -1, QCS404_SLAVE_EBI_CH0, QCS404_BIMC_SNOC_SLV);
> DEFINE_QNODE(mas_spdm, QCS404_MASTER_SPDM, 4, -1, -1, QCS404_PNOC_INT_3);
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] interconnect: qcom: qcs404: Remove GPU and display RPM IDs
2020-11-18 11:10 [PATCH v2] interconnect: qcom: qcs404: Remove GPU and display RPM IDs Georgi Djakov
2020-11-18 21:07 ` Mike Tipton
@ 2020-11-19 5:45 ` Bjorn Andersson
1 sibling, 0 replies; 3+ messages in thread
From: Bjorn Andersson @ 2020-11-19 5:45 UTC (permalink / raw)
To: Georgi Djakov; +Cc: mdtipton, linux-pm, linux-arm-msm, linux-kernel
On Wed 18 Nov 05:10 CST 2020, Georgi Djakov wrote:
> The following errors are noticed during boot on a QCS404 board:
> [ 2.926647] qcom_icc_rpm_smd_send mas 6 error -6
> [ 2.934573] qcom_icc_rpm_smd_send mas 8 error -6
>
> These errors show when we try to configure the GPU and display nodes.
> Since these particular nodes aren't supported on RPM and are purely
> local, we should just change their mas_rpm_id to -1 to avoid any
> requests being sent for these master IDs.
>
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Regards,
Bjorn
> Signed-off-by: Georgi Djakov <georgi.djakov@linaro.org>
> ---
>
> v2:
> * Keep the nodes and just set the IDs to -1, as suggested by Mike.
>
> v1: http://lore.kernel.org/r/20201111100734.307-1-georgi.djakov@linaro.org
>
> drivers/interconnect/qcom/qcs404.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/interconnect/qcom/qcs404.c b/drivers/interconnect/qcom/qcs404.c
> index d4769a5ea182..9820709b43db 100644
> --- a/drivers/interconnect/qcom/qcs404.c
> +++ b/drivers/interconnect/qcom/qcs404.c
> @@ -157,8 +157,8 @@ struct qcom_icc_desc {
> }
>
> DEFINE_QNODE(mas_apps_proc, QCS404_MASTER_AMPSS_M0, 8, 0, -1, QCS404_SLAVE_EBI_CH0, QCS404_BIMC_SNOC_SLV);
> -DEFINE_QNODE(mas_oxili, QCS404_MASTER_GRAPHICS_3D, 8, 6, -1, QCS404_SLAVE_EBI_CH0, QCS404_BIMC_SNOC_SLV);
> -DEFINE_QNODE(mas_mdp, QCS404_MASTER_MDP_PORT0, 8, 8, -1, QCS404_SLAVE_EBI_CH0, QCS404_BIMC_SNOC_SLV);
> +DEFINE_QNODE(mas_oxili, QCS404_MASTER_GRAPHICS_3D, 8, -1, -1, QCS404_SLAVE_EBI_CH0, QCS404_BIMC_SNOC_SLV);
> +DEFINE_QNODE(mas_mdp, QCS404_MASTER_MDP_PORT0, 8, -1, -1, QCS404_SLAVE_EBI_CH0, QCS404_BIMC_SNOC_SLV);
> DEFINE_QNODE(mas_snoc_bimc_1, QCS404_SNOC_BIMC_1_MAS, 8, 76, -1, QCS404_SLAVE_EBI_CH0);
> DEFINE_QNODE(mas_tcu_0, QCS404_MASTER_TCU_0, 8, -1, -1, QCS404_SLAVE_EBI_CH0, QCS404_BIMC_SNOC_SLV);
> DEFINE_QNODE(mas_spdm, QCS404_MASTER_SPDM, 4, -1, -1, QCS404_PNOC_INT_3);
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-11-19 5:45 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-18 11:10 [PATCH v2] interconnect: qcom: qcs404: Remove GPU and display RPM IDs Georgi Djakov
2020-11-18 21:07 ` Mike Tipton
2020-11-19 5:45 ` Bjorn Andersson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).