* [PATCH v2 0/1] mmc: sdhci-of-arasan: Fix clock registration fail for Keem Bay SOC @ 2020-11-18 12:01 muhammad.husaini.zulkifli 2020-11-18 12:01 ` [PATCH v2 1/1] " muhammad.husaini.zulkifli 0 siblings, 1 reply; 4+ messages in thread From: muhammad.husaini.zulkifli @ 2020-11-18 12:01 UTC (permalink / raw) To: ulf.hansson, linux-mmc, linux-arm-kernel, linux-kernel Cc: adrian.hunter, lakshmi.bai.raja.subramanian, wan.ahmad.zainie.wan.mohamad, muhammad.husaini.zulkifli, david.e.box From: Muhammad Husaini Zulkifli <muhammad.husaini.zulkifli@intel.com> Hi. This patch specify clock operations handlers for Keem Bay SOC devices due to the introduction of new clock operations handling. Tested with Keem Bay evaluation module board. Kindly help to review it. Thank you. Changes since v1: - Update the commit message to better reflect what goes on Muhammad Husaini Zulkifli (1): mmc: sdhci-of-arasan: Fix clock registration fail for Keem Bay SOC drivers/mmc/host/sdhci-of-arasan.c | 3 +++ 1 file changed, 3 insertions(+) -- 2.17.1 ^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH v2 1/1] mmc: sdhci-of-arasan: Fix clock registration fail for Keem Bay SOC 2020-11-18 12:01 [PATCH v2 0/1] mmc: sdhci-of-arasan: Fix clock registration fail for Keem Bay SOC muhammad.husaini.zulkifli @ 2020-11-18 12:01 ` muhammad.husaini.zulkifli 2020-11-23 16:07 ` Ulf Hansson 0 siblings, 1 reply; 4+ messages in thread From: muhammad.husaini.zulkifli @ 2020-11-18 12:01 UTC (permalink / raw) To: ulf.hansson, linux-mmc, linux-arm-kernel, linux-kernel Cc: adrian.hunter, lakshmi.bai.raja.subramanian, wan.ahmad.zainie.wan.mohamad, muhammad.husaini.zulkifli, david.e.box From: Muhammad Husaini Zulkifli <muhammad.husaini.zulkifli@intel.com> Commit 16ada730a759 ("mmc: sdhci-of-arasan: Modify clock operations handling") introduces platform specific SDHCI clock operation. Each platform should specify clock operations handlers. Commit 16ada730a759 ("mmc: sdhci-of-arasan: Modify clock operations handling") and Commit 36c6aadaae86 ("mmc: sdhci-of-arasan: Add support for Intel Keem Bay") are merged about the same time. When doing rebasing during the upstream process, Commit 16ada730a759 ("mmc: sdhci-of-arasan: Modify clock operations handling") was not included. This will result in sd clock registration failure for Keem Bay SOC Devices as clock operations handlers are not defined. This patch declares the clock operation for Keem Bay SOC Devices. Add clk_ops for SD, EMMC and SDIO operations. Fixes: 36c6aadaae86 ("mmc: sdhci-of-arasan: Add support for Intel Keem Bay") Signed-off-by: Muhammad Husaini Zulkifli <muhammad.husaini.zulkifli@intel.com> Reviewed-by: Adrian Hunter <adrian.hunter@intel.com> --- drivers/mmc/host/sdhci-of-arasan.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/mmc/host/sdhci-of-arasan.c b/drivers/mmc/host/sdhci-of-arasan.c index 829ccef87426..012d52e1abee 100644 --- a/drivers/mmc/host/sdhci-of-arasan.c +++ b/drivers/mmc/host/sdhci-of-arasan.c @@ -1199,16 +1199,19 @@ static struct sdhci_arasan_of_data sdhci_arasan_versal_data = { static struct sdhci_arasan_of_data intel_keembay_emmc_data = { .soc_ctl_map = &intel_keembay_soc_ctl_map, .pdata = &sdhci_keembay_emmc_pdata, + .clk_ops = &arasan_clk_ops, }; static struct sdhci_arasan_of_data intel_keembay_sd_data = { .soc_ctl_map = &intel_keembay_soc_ctl_map, .pdata = &sdhci_keembay_sd_pdata, + .clk_ops = &arasan_clk_ops, }; static struct sdhci_arasan_of_data intel_keembay_sdio_data = { .soc_ctl_map = &intel_keembay_soc_ctl_map, .pdata = &sdhci_keembay_sdio_pdata, + .clk_ops = &arasan_clk_ops, }; static const struct of_device_id sdhci_arasan_of_match[] = { -- 2.17.1 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v2 1/1] mmc: sdhci-of-arasan: Fix clock registration fail for Keem Bay SOC 2020-11-18 12:01 ` [PATCH v2 1/1] " muhammad.husaini.zulkifli @ 2020-11-23 16:07 ` Ulf Hansson 2020-11-24 4:02 ` Zulkifli, Muhammad Husaini 0 siblings, 1 reply; 4+ messages in thread From: Ulf Hansson @ 2020-11-23 16:07 UTC (permalink / raw) To: Zulkifli, Muhammad Husaini Cc: linux-mmc, Linux ARM, Linux Kernel Mailing List, Adrian Hunter, Raja Subramanian, Lakshmi Bai, Wan Ahmad Zainie, David E. Box On Wed, 18 Nov 2020 at 05:01, <muhammad.husaini.zulkifli@intel.com> wrote: > > From: Muhammad Husaini Zulkifli <muhammad.husaini.zulkifli@intel.com> > > Commit 16ada730a759 ("mmc: sdhci-of-arasan: Modify clock operations handling") > introduces platform specific SDHCI clock operation. Each platform should > specify clock operations handlers. > > Commit 16ada730a759 ("mmc: sdhci-of-arasan: Modify clock operations handling") > and Commit 36c6aadaae86 ("mmc: sdhci-of-arasan: Add support for Intel Keem Bay") > are merged about the same time. When doing rebasing during the upstream process, > Commit 16ada730a759 ("mmc: sdhci-of-arasan: Modify clock operations handling") > was not included. This will result in sd clock registration failure for > Keem Bay SOC Devices as clock operations handlers are not defined. > > This patch declares the clock operation for Keem Bay SOC Devices. > Add clk_ops for SD, EMMC and SDIO operations. > > Fixes: 36c6aadaae86 ("mmc: sdhci-of-arasan: Add support for Intel Keem Bay") > > Signed-off-by: Muhammad Husaini Zulkifli <muhammad.husaini.zulkifli@intel.com> > Reviewed-by: Adrian Hunter <adrian.hunter@intel.com> Applied for fixes and by adding a stable tag, thanks! Kind regards Uffe > --- > drivers/mmc/host/sdhci-of-arasan.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/mmc/host/sdhci-of-arasan.c b/drivers/mmc/host/sdhci-of-arasan.c > index 829ccef87426..012d52e1abee 100644 > --- a/drivers/mmc/host/sdhci-of-arasan.c > +++ b/drivers/mmc/host/sdhci-of-arasan.c > @@ -1199,16 +1199,19 @@ static struct sdhci_arasan_of_data sdhci_arasan_versal_data = { > static struct sdhci_arasan_of_data intel_keembay_emmc_data = { > .soc_ctl_map = &intel_keembay_soc_ctl_map, > .pdata = &sdhci_keembay_emmc_pdata, > + .clk_ops = &arasan_clk_ops, > }; > > static struct sdhci_arasan_of_data intel_keembay_sd_data = { > .soc_ctl_map = &intel_keembay_soc_ctl_map, > .pdata = &sdhci_keembay_sd_pdata, > + .clk_ops = &arasan_clk_ops, > }; > > static struct sdhci_arasan_of_data intel_keembay_sdio_data = { > .soc_ctl_map = &intel_keembay_soc_ctl_map, > .pdata = &sdhci_keembay_sdio_pdata, > + .clk_ops = &arasan_clk_ops, > }; > > static const struct of_device_id sdhci_arasan_of_match[] = { > -- > 2.17.1 > ^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [PATCH v2 1/1] mmc: sdhci-of-arasan: Fix clock registration fail for Keem Bay SOC 2020-11-23 16:07 ` Ulf Hansson @ 2020-11-24 4:02 ` Zulkifli, Muhammad Husaini 0 siblings, 0 replies; 4+ messages in thread From: Zulkifli, Muhammad Husaini @ 2020-11-24 4:02 UTC (permalink / raw) To: Ulf Hansson Cc: linux-mmc, Linux ARM, Linux Kernel Mailing List, Hunter, Adrian, Raja Subramanian, Lakshmi Bai, Wan Mohamad, Wan Ahmad Zainie, David E. Box Hi Ulf, Thanks >-----Original Message----- >From: Ulf Hansson <ulf.hansson@linaro.org> >Sent: Tuesday, November 24, 2020 12:07 AM >To: Zulkifli, Muhammad Husaini <muhammad.husaini.zulkifli@intel.com> >Cc: linux-mmc@vger.kernel.org; Linux ARM <linux-arm- >kernel@lists.infradead.org>; Linux Kernel Mailing List <linux- >kernel@vger.kernel.org>; Hunter, Adrian <adrian.hunter@intel.com>; Raja >Subramanian, Lakshmi Bai <lakshmi.bai.raja.subramanian@intel.com>; Wan >Mohamad, Wan Ahmad Zainie ><wan.ahmad.zainie.wan.mohamad@intel.com>; David E. Box ><david.e.box@linux.intel.com> >Subject: Re: [PATCH v2 1/1] mmc: sdhci-of-arasan: Fix clock registration fail >for Keem Bay SOC > >On Wed, 18 Nov 2020 at 05:01, <muhammad.husaini.zulkifli@intel.com> >wrote: >> >> From: Muhammad Husaini Zulkifli <muhammad.husaini.zulkifli@intel.com> >> >> Commit 16ada730a759 ("mmc: sdhci-of-arasan: Modify clock operations >> handling") introduces platform specific SDHCI clock operation. Each >> platform should specify clock operations handlers. >> >> Commit 16ada730a759 ("mmc: sdhci-of-arasan: Modify clock operations >> handling") and Commit 36c6aadaae86 ("mmc: sdhci-of-arasan: Add support >> for Intel Keem Bay") are merged about the same time. When doing >> rebasing during the upstream process, Commit 16ada730a759 ("mmc: >> sdhci-of-arasan: Modify clock operations handling") was not included. >> This will result in sd clock registration failure for Keem Bay SOC Devices as >clock operations handlers are not defined. >> >> This patch declares the clock operation for Keem Bay SOC Devices. >> Add clk_ops for SD, EMMC and SDIO operations. >> >> Fixes: 36c6aadaae86 ("mmc: sdhci-of-arasan: Add support for Intel Keem >> Bay") >> >> Signed-off-by: Muhammad Husaini Zulkifli >> <muhammad.husaini.zulkifli@intel.com> >> Reviewed-by: Adrian Hunter <adrian.hunter@intel.com> > >Applied for fixes and by adding a stable tag, thanks! > >Kind regards >Uffe > > >> --- >> drivers/mmc/host/sdhci-of-arasan.c | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/drivers/mmc/host/sdhci-of-arasan.c >> b/drivers/mmc/host/sdhci-of-arasan.c >> index 829ccef87426..012d52e1abee 100644 >> --- a/drivers/mmc/host/sdhci-of-arasan.c >> +++ b/drivers/mmc/host/sdhci-of-arasan.c >> @@ -1199,16 +1199,19 @@ static struct sdhci_arasan_of_data >> sdhci_arasan_versal_data = { static struct sdhci_arasan_of_data >intel_keembay_emmc_data = { >> .soc_ctl_map = &intel_keembay_soc_ctl_map, >> .pdata = &sdhci_keembay_emmc_pdata, >> + .clk_ops = &arasan_clk_ops, >> }; >> >> static struct sdhci_arasan_of_data intel_keembay_sd_data = { >> .soc_ctl_map = &intel_keembay_soc_ctl_map, >> .pdata = &sdhci_keembay_sd_pdata, >> + .clk_ops = &arasan_clk_ops, >> }; >> >> static struct sdhci_arasan_of_data intel_keembay_sdio_data = { >> .soc_ctl_map = &intel_keembay_soc_ctl_map, >> .pdata = &sdhci_keembay_sdio_pdata, >> + .clk_ops = &arasan_clk_ops, >> }; >> >> static const struct of_device_id sdhci_arasan_of_match[] = { >> -- >> 2.17.1 >> ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-11-24 4:03 UTC | newest] Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2020-11-18 12:01 [PATCH v2 0/1] mmc: sdhci-of-arasan: Fix clock registration fail for Keem Bay SOC muhammad.husaini.zulkifli 2020-11-18 12:01 ` [PATCH v2 1/1] " muhammad.husaini.zulkifli 2020-11-23 16:07 ` Ulf Hansson 2020-11-24 4:02 ` Zulkifli, Muhammad Husaini
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).