* [PATCH] net: cw1200: fix missing destroy_workqueue() on error in cw1200_init_common
@ 2020-11-19 7:08 Qinglang Miao
2020-11-19 7:57 ` Kalle Valo
2020-11-24 15:08 ` Kalle Valo
0 siblings, 2 replies; 3+ messages in thread
From: Qinglang Miao @ 2020-11-19 7:08 UTC (permalink / raw)
To: Solomon Peachy, Kalle Valo, David S. Miller, Jakub Kicinski
Cc: linux-wireless, netdev, linux-kernel, Qinglang Miao
Add the missing destroy_workqueue() before return from
cw1200_init_common in the error handling case.
Fixes:a910e4a94f69 ("cw1200: add driver for the ST-E CW1100 & CW1200 WLAN chipsets")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Qinglang Miao <miaoqinglang@huawei.com>
---
drivers/net/wireless/st/cw1200/main.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/wireless/st/cw1200/main.c b/drivers/net/wireless/st/cw1200/main.c
index f7fe56aff..326b1cc1d 100644
--- a/drivers/net/wireless/st/cw1200/main.c
+++ b/drivers/net/wireless/st/cw1200/main.c
@@ -381,6 +381,7 @@ static struct ieee80211_hw *cw1200_init_common(const u8 *macaddr,
CW1200_LINK_ID_MAX,
cw1200_skb_dtor,
priv)) {
+ destroy_workqueue(priv->workqueue);
ieee80211_free_hw(hw);
return NULL;
}
@@ -392,6 +393,7 @@ static struct ieee80211_hw *cw1200_init_common(const u8 *macaddr,
for (; i > 0; i--)
cw1200_queue_deinit(&priv->tx_queue[i - 1]);
cw1200_queue_stats_deinit(&priv->tx_queue_stats);
+ destroy_workqueue(priv->workqueue);
ieee80211_free_hw(hw);
return NULL;
}
--
2.23.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] net: cw1200: fix missing destroy_workqueue() on error in cw1200_init_common
2020-11-19 7:08 [PATCH] net: cw1200: fix missing destroy_workqueue() on error in cw1200_init_common Qinglang Miao
@ 2020-11-19 7:57 ` Kalle Valo
2020-11-24 15:08 ` Kalle Valo
1 sibling, 0 replies; 3+ messages in thread
From: Kalle Valo @ 2020-11-19 7:57 UTC (permalink / raw)
To: Qinglang Miao
Cc: Solomon Peachy, David S. Miller, Jakub Kicinski, linux-wireless,
netdev, linux-kernel
Qinglang Miao <miaoqinglang@huawei.com> writes:
> Add the missing destroy_workqueue() before return from
> cw1200_init_common in the error handling case.
>
> Fixes:a910e4a94f69 ("cw1200: add driver for the ST-E CW1100 & CW1200 WLAN chipsets")
This should be:
Fixes: a910e4a94f69 ("cw1200: add driver for the ST-E CW1100 & CW1200 WLAN chipsets")
I can fix that.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: cw1200: fix missing destroy_workqueue() on error in cw1200_init_common
2020-11-19 7:08 [PATCH] net: cw1200: fix missing destroy_workqueue() on error in cw1200_init_common Qinglang Miao
2020-11-19 7:57 ` Kalle Valo
@ 2020-11-24 15:08 ` Kalle Valo
1 sibling, 0 replies; 3+ messages in thread
From: Kalle Valo @ 2020-11-24 15:08 UTC (permalink / raw)
To: Qinglang Miao
Cc: Solomon Peachy, David S. Miller, Jakub Kicinski, linux-wireless,
netdev, linux-kernel, Qinglang Miao
Qinglang Miao <miaoqinglang@huawei.com> wrote:
> Add the missing destroy_workqueue() before return from
> cw1200_init_common in the error handling case.
>
> Fixes: a910e4a94f69 ("cw1200: add driver for the ST-E CW1100 & CW1200 WLAN chipsets")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Qinglang Miao <miaoqinglang@huawei.com>
Patch applied to wireless-drivers-next.git, thanks.
7ec8a926188e cw1200: fix missing destroy_workqueue() on error in cw1200_init_common
--
https://patchwork.kernel.org/project/linux-wireless/patch/20201119070842.1011-1-miaoqinglang@huawei.com/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-11-24 15:08 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-19 7:08 [PATCH] net: cw1200: fix missing destroy_workqueue() on error in cw1200_init_common Qinglang Miao
2020-11-19 7:57 ` Kalle Valo
2020-11-24 15:08 ` Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).