linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v3] arm64: tegra: jetson-tx1: Fix USB_VBUS_EN0 regulator
@ 2020-11-19  7:23 JC Kuo
  2020-11-19 10:41 ` Thierry Reding
  0 siblings, 1 reply; 2+ messages in thread
From: JC Kuo @ 2020-11-19  7:23 UTC (permalink / raw)
  To: gregkh, thierry.reding, jonathanh, robh+dt
  Cc: linux-kernel, linux-tegra, devicetree, stable, JC Kuo

USB Host mode is broken at OTG port of Jetson-TX1 platform because
USB_VBUS_EN0 regulator (regulator@11) is being overwritten by vdd-cam-1v2
regulator. This commit rearrange USB_VBUS_EN0 to be regulator@14.

Fixes: 257c8047be44 ("arm64: tegra: jetson-tx1: Add camera supplies")
Cc: stable@vger.kernel.org
Signed-off-by: JC Kuo <jckuo@nvidia.com>
Reviewed-by: Jon Hunter <jonathanh@nvidia.com>
---
v3:
    add 'Cc: stable@vger.kernel.org' tag
v2:
    add 'Fixes:' tag
    add Reviewed-by: Jon Hunter <jonathanh@nvidia.com>

 .../arm64/boot/dts/nvidia/tegra210-p2597.dtsi | 20 +++++++++----------
 1 file changed, 10 insertions(+), 10 deletions(-)

diff --git a/arch/arm64/boot/dts/nvidia/tegra210-p2597.dtsi b/arch/arm64/boot/dts/nvidia/tegra210-p2597.dtsi
index e18e1a9a3011..a9caaf7c0d67 100644
--- a/arch/arm64/boot/dts/nvidia/tegra210-p2597.dtsi
+++ b/arch/arm64/boot/dts/nvidia/tegra210-p2597.dtsi
@@ -1663,16 +1663,6 @@ vdd_usb_vbus: regulator@9 {
 		vin-supply = <&vdd_5v0_sys>;
 	};
 
-	vdd_usb_vbus_otg: regulator@11 {
-		compatible = "regulator-fixed";
-		regulator-name = "USB_VBUS_EN0";
-		regulator-min-microvolt = <5000000>;
-		regulator-max-microvolt = <5000000>;
-		gpio = <&gpio TEGRA_GPIO(CC, 4) GPIO_ACTIVE_HIGH>;
-		enable-active-high;
-		vin-supply = <&vdd_5v0_sys>;
-	};
-
 	vdd_hdmi: regulator@10 {
 		compatible = "regulator-fixed";
 		regulator-name = "VDD_HDMI_5V0";
@@ -1712,4 +1702,14 @@ vdd_cam_1v8: regulator@13 {
 		enable-active-high;
 		vin-supply = <&vdd_3v3_sys>;
 	};
+
+	vdd_usb_vbus_otg: regulator@14 {
+		compatible = "regulator-fixed";
+		regulator-name = "USB_VBUS_EN0";
+		regulator-min-microvolt = <5000000>;
+		regulator-max-microvolt = <5000000>;
+		gpio = <&gpio TEGRA_GPIO(CC, 4) GPIO_ACTIVE_HIGH>;
+		enable-active-high;
+		vin-supply = <&vdd_5v0_sys>;
+	};
 };
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH v3] arm64: tegra: jetson-tx1: Fix USB_VBUS_EN0 regulator
  2020-11-19  7:23 [PATCH v3] arm64: tegra: jetson-tx1: Fix USB_VBUS_EN0 regulator JC Kuo
@ 2020-11-19 10:41 ` Thierry Reding
  0 siblings, 0 replies; 2+ messages in thread
From: Thierry Reding @ 2020-11-19 10:41 UTC (permalink / raw)
  To: JC Kuo
  Cc: gregkh, jonathanh, robh+dt, linux-kernel, linux-tegra,
	devicetree, stable

[-- Attachment #1: Type: text/plain, Size: 785 bytes --]

On Thu, Nov 19, 2020 at 03:23:45PM +0800, JC Kuo wrote:
> USB Host mode is broken at OTG port of Jetson-TX1 platform because
> USB_VBUS_EN0 regulator (regulator@11) is being overwritten by vdd-cam-1v2
> regulator. This commit rearrange USB_VBUS_EN0 to be regulator@14.
> 
> Fixes: 257c8047be44 ("arm64: tegra: jetson-tx1: Add camera supplies")
> Cc: stable@vger.kernel.org
> Signed-off-by: JC Kuo <jckuo@nvidia.com>
> Reviewed-by: Jon Hunter <jonathanh@nvidia.com>
> ---
> v3:
>     add 'Cc: stable@vger.kernel.org' tag
> v2:
>     add 'Fixes:' tag
>     add Reviewed-by: Jon Hunter <jonathanh@nvidia.com>
> 
>  .../arm64/boot/dts/nvidia/tegra210-p2597.dtsi | 20 +++++++++----------
>  1 file changed, 10 insertions(+), 10 deletions(-)

Applied, thanks.

Thierry

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-11-19 10:42 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-19  7:23 [PATCH v3] arm64: tegra: jetson-tx1: Fix USB_VBUS_EN0 regulator JC Kuo
2020-11-19 10:41 ` Thierry Reding

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).