linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: JC Kuo <jckuo@nvidia.com>
To: <gregkh@linuxfoundation.org>, <thierry.reding@gmail.com>,
	<robh@kernel.org>, <jonathanh@nvidia.com>, <kishon@ti.com>
Cc: <linux-tegra@vger.kernel.org>, <linux-usb@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>,
	<nkristam@nvidia.com>, JC Kuo <jckuo@nvidia.com>
Subject: [PATCH v5 04/16] phy: tegra: xusb: tegra210: Do not reset UPHY PLL
Date: Thu, 19 Nov 2020 16:53:53 +0800	[thread overview]
Message-ID: <20201119085405.556138-5-jckuo@nvidia.com> (raw)
In-Reply-To: <20201119085405.556138-1-jckuo@nvidia.com>

Once UPHY PLL hardware power sequencer is enabled, do not assert
reset to PEX/SATA PLLs, otherwise UPHY PLL operation will be broken.
This commit removes reset_control_assert(pcie->rst) and
reset_control_assert(sata->rst) from PEX/SATA UPHY disable procedure.

Signed-off-by: JC Kuo <jckuo@nvidia.com>
---
v5:
   no change
v4:
   no change
v3:
   new, was a part of "phy: tegra: xusb: Rearrange UPHY init on Tegra210"

 drivers/phy/tegra/xusb-tegra210.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/phy/tegra/xusb-tegra210.c b/drivers/phy/tegra/xusb-tegra210.c
index 4dc9286ec1b8..9bfecdfecf35 100644
--- a/drivers/phy/tegra/xusb-tegra210.c
+++ b/drivers/phy/tegra/xusb-tegra210.c
@@ -502,7 +502,6 @@ static void tegra210_pex_uphy_disable(struct tegra_xusb_padctl *padctl)
 	if (--pcie->enable > 0)
 		return;
 
-	reset_control_assert(pcie->rst);
 	clk_disable_unprepare(pcie->pll);
 }
 
@@ -739,7 +738,6 @@ static void tegra210_sata_uphy_disable(struct tegra_xusb_padctl *padctl)
 	if (--sata->enable > 0)
 		return;
 
-	reset_control_assert(sata->rst);
 	clk_disable_unprepare(sata->pll);
 }
 
-- 
2.25.1


  parent reply	other threads:[~2020-11-19  8:54 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-19  8:53 [PATCH v5 00/16] Tegra XHCI controller ELPG support JC Kuo
2020-11-19  8:53 ` [PATCH v5 01/16] clk: tegra: Add PLLE HW power sequencer control JC Kuo
2020-11-19  8:53 ` [PATCH v5 02/16] clk: tegra: Don't enable PLLE HW sequencer at init JC Kuo
2020-11-19  8:53 ` [PATCH v5 03/16] phy: tegra: xusb: Move usb3 port init for Tegra210 JC Kuo
2020-11-19  8:53 ` JC Kuo [this message]
2020-11-19  8:53 ` [PATCH v5 05/16] phy: tegra: xusb: Rearrange UPHY init on Tegra210 JC Kuo
2020-11-19  8:53 ` [PATCH v5 06/16] phy: tegra: xusb: Add Tegra210 lane_iddq operation JC Kuo
2020-11-19  8:53 ` [PATCH v5 07/16] phy: tegra: xusb: Add sleepwalk and suspend/resume JC Kuo
2020-11-19  8:53 ` [PATCH v5 08/16] soc/tegra: pmc: Provide USB sleepwalk register map JC Kuo
2020-11-19  8:53 ` [PATCH v5 09/16] arm64: tegra210: XUSB PADCTL add "nvidia,pmc" prop JC Kuo
2020-11-19  8:53 ` [PATCH v5 10/16] dt-bindings: phy: tegra-xusb: Add nvidia,pmc prop JC Kuo
2020-11-30 22:03   ` Rob Herring
2020-11-19  8:54 ` [PATCH v5 11/16] phy: tegra: xusb: Add wake/sleepwalk for Tegra210 JC Kuo
2020-11-19  8:54 ` [PATCH v5 12/16] phy: tegra: xusb: Tegra210 host mode VBUS control JC Kuo
2020-11-19  8:54 ` [PATCH v5 13/16] phy: tegra: xusb: Add wake/sleepwalk for Tegra186 JC Kuo
2020-11-19  8:54 ` [PATCH v5 14/16] arm64: tegra210/tegra186/tegra194: XUSB PADCTL irq JC Kuo
2020-11-19  8:54 ` [PATCH v5 15/16] usb: host: xhci-tegra: Unlink power domain devices JC Kuo
2020-11-19  8:54 ` [PATCH v5 16/16] xhci: tegra: Enable ELPG for runtime/system PM JC Kuo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201119085405.556138-5-jckuo@nvidia.com \
    --to=jckuo@nvidia.com \
    --cc=devicetree@vger.kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=jonathanh@nvidia.com \
    --cc=kishon@ti.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=nkristam@nvidia.com \
    --cc=robh@kernel.org \
    --cc=thierry.reding@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).