* [PATCH] mm,hugetlb: Remove unneded initialization
@ 2020-11-19 11:21 Oscar Salvador
2020-11-19 18:28 ` Mike Kravetz
2020-11-20 9:28 ` David Hildenbrand
0 siblings, 2 replies; 3+ messages in thread
From: Oscar Salvador @ 2020-11-19 11:21 UTC (permalink / raw)
To: akpm; +Cc: mike.kravetz, linux-mm, linux-kernel, Oscar Salvador
hugetlb_add_hstate initializes nr_huge_pages and free_huge_pages to 0,
but since hstates[] is a global variable, all its fields are defined to
0 already.
Signed-off-by: Oscar Salvador <osalvador@suse.de>
---
mm/hugetlb.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/mm/hugetlb.c b/mm/hugetlb.c
index 37f15c3c24dc..1c69e9044887 100644
--- a/mm/hugetlb.c
+++ b/mm/hugetlb.c
@@ -3197,8 +3197,6 @@ void __init hugetlb_add_hstate(unsigned int order)
h = &hstates[hugetlb_max_hstate++];
h->order = order;
h->mask = ~((1ULL << (order + PAGE_SHIFT)) - 1);
- h->nr_huge_pages = 0;
- h->free_huge_pages = 0;
for (i = 0; i < MAX_NUMNODES; ++i)
INIT_LIST_HEAD(&h->hugepage_freelists[i]);
INIT_LIST_HEAD(&h->hugepage_activelist);
--
2.26.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] mm,hugetlb: Remove unneded initialization
2020-11-19 11:21 [PATCH] mm,hugetlb: Remove unneded initialization Oscar Salvador
@ 2020-11-19 18:28 ` Mike Kravetz
2020-11-20 9:28 ` David Hildenbrand
1 sibling, 0 replies; 3+ messages in thread
From: Mike Kravetz @ 2020-11-19 18:28 UTC (permalink / raw)
To: Oscar Salvador, akpm; +Cc: linux-mm, linux-kernel
On 11/19/20 3:21 AM, Oscar Salvador wrote:
> hugetlb_add_hstate initializes nr_huge_pages and free_huge_pages to 0,
> but since hstates[] is a global variable, all its fields are defined to
> 0 already.
>
> Signed-off-by: Oscar Salvador <osalvador@suse.de>
> ---
> mm/hugetlb.c | 2 --
> 1 file changed, 2 deletions(-)
Thanks,
Reviewed-by: Mike Kravetz <mike.kravetz@oracle.com>
--
Mike Kravetz
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mm,hugetlb: Remove unneded initialization
2020-11-19 11:21 [PATCH] mm,hugetlb: Remove unneded initialization Oscar Salvador
2020-11-19 18:28 ` Mike Kravetz
@ 2020-11-20 9:28 ` David Hildenbrand
1 sibling, 0 replies; 3+ messages in thread
From: David Hildenbrand @ 2020-11-20 9:28 UTC (permalink / raw)
To: Oscar Salvador, akpm; +Cc: mike.kravetz, linux-mm, linux-kernel
On 19.11.20 12:21, Oscar Salvador wrote:
> hugetlb_add_hstate initializes nr_huge_pages and free_huge_pages to 0,
> but since hstates[] is a global variable, all its fields are defined to
> 0 already.
>
> Signed-off-by: Oscar Salvador <osalvador@suse.de>
> ---
> mm/hugetlb.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/mm/hugetlb.c b/mm/hugetlb.c
> index 37f15c3c24dc..1c69e9044887 100644
> --- a/mm/hugetlb.c
> +++ b/mm/hugetlb.c
> @@ -3197,8 +3197,6 @@ void __init hugetlb_add_hstate(unsigned int order)
> h = &hstates[hugetlb_max_hstate++];
> h->order = order;
> h->mask = ~((1ULL << (order + PAGE_SHIFT)) - 1);
> - h->nr_huge_pages = 0;
> - h->free_huge_pages = 0;
> for (i = 0; i < MAX_NUMNODES; ++i)
> INIT_LIST_HEAD(&h->hugepage_freelists[i]);
> INIT_LIST_HEAD(&h->hugepage_activelist);
>
Reviewed-by: David Hildenbrand <david@redhat.com>
--
Thanks,
David / dhildenb
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-11-20 9:29 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-19 11:21 [PATCH] mm,hugetlb: Remove unneded initialization Oscar Salvador
2020-11-19 18:28 ` Mike Kravetz
2020-11-20 9:28 ` David Hildenbrand
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).