* [PATCH 0/1] Mediatek pinctrl patch
@ 2020-11-20 9:30 Zhiyong Tao
2020-11-20 9:30 ` [PATCH] pinctrl: fix low level output voltage issue Zhiyong Tao
0 siblings, 1 reply; 5+ messages in thread
From: Zhiyong Tao @ 2020-11-20 9:30 UTC (permalink / raw)
To: robh+dt, linus.walleij, mark.rutland, matthias.bgg, sean.wang
Cc: srv_heupstream, zhiyong.tao, hui.liu, eddie.huang, jg_poxu,
biao.huang, hongzhou.yang, erin.lo, sean.wang, seiya.wang,
sj.huang, devicetree, linux-kernel, linux-arm-kernel,
linux-mediatek, linux-gpio
This series includes 1 patches:
1.fix low level output voltage issue.
Zhiyong Tao (1):
pinctrl: fix low level output voltage issue
drivers/pinctrl/mediatek/pinctrl-paris.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
--
2.18.0
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] pinctrl: fix low level output voltage issue
2020-11-20 9:30 [PATCH 0/1] Mediatek pinctrl patch Zhiyong Tao
@ 2020-11-20 9:30 ` Zhiyong Tao
2020-12-04 8:43 ` Linus Walleij
0 siblings, 1 reply; 5+ messages in thread
From: Zhiyong Tao @ 2020-11-20 9:30 UTC (permalink / raw)
To: robh+dt, linus.walleij, mark.rutland, matthias.bgg, sean.wang
Cc: srv_heupstream, zhiyong.tao, hui.liu, eddie.huang, jg_poxu,
biao.huang, hongzhou.yang, erin.lo, sean.wang, seiya.wang,
sj.huang, devicetree, linux-kernel, linux-arm-kernel,
linux-mediatek, linux-gpio
This patch is used to fix low level output voltage issue.
A pin is changed from input pull-up to output high.
The Dout value of the pin is default as 0.
If we change the direction of the pin before the dout value of the pin,
It maybe produce a low level output voltage between "input pull-up" and
"output high".
Signed-off-by: Zhiyong Tao <zhiyong.tao@mediatek.com>
---
drivers/pinctrl/mediatek/pinctrl-paris.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/pinctrl/mediatek/pinctrl-paris.c b/drivers/pinctrl/mediatek/pinctrl-paris.c
index 623af4410b07..039ce9be19c5 100644
--- a/drivers/pinctrl/mediatek/pinctrl-paris.c
+++ b/drivers/pinctrl/mediatek/pinctrl-paris.c
@@ -247,13 +247,13 @@ static int mtk_pinconf_set(struct pinctrl_dev *pctldev, unsigned int pin,
err = mtk_hw_set_value(hw, desc, PINCTRL_PIN_REG_SR, !!arg);
break;
case PIN_CONFIG_OUTPUT:
- err = mtk_hw_set_value(hw, desc, PINCTRL_PIN_REG_DIR,
- MTK_OUTPUT);
+ err = mtk_hw_set_value(hw, desc, PINCTRL_PIN_REG_DO,
+ arg);
if (err)
goto err;
- err = mtk_hw_set_value(hw, desc, PINCTRL_PIN_REG_DO,
- arg);
+ err = mtk_hw_set_value(hw, desc, PINCTRL_PIN_REG_DIR,
+ MTK_OUTPUT);
break;
case PIN_CONFIG_INPUT_SCHMITT:
case PIN_CONFIG_INPUT_SCHMITT_ENABLE:
--
2.18.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] pinctrl: fix low level output voltage issue
2020-11-20 9:30 ` [PATCH] pinctrl: fix low level output voltage issue Zhiyong Tao
@ 2020-12-04 8:43 ` Linus Walleij
0 siblings, 0 replies; 5+ messages in thread
From: Linus Walleij @ 2020-12-04 8:43 UTC (permalink / raw)
To: Zhiyong Tao
Cc: Rob Herring, Mark Rutland, Matthias Brugger, Sean Wang,
srv_heupstream, hui.liu, huang eddie, jg_poxu, Biao Huang,
Hongzhou Yang, Erin Lo, Sean Wang, seiya.wang, sj.huang,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
linux-kernel, Linux ARM, moderated list:ARM/Mediatek SoC support,
open list:GPIO SUBSYSTEM
On Fri, Nov 20, 2020 at 10:31 AM Zhiyong Tao <zhiyong.tao@mediatek.com> wrote:
> This patch is used to fix low level output voltage issue.
> A pin is changed from input pull-up to output high.
> The Dout value of the pin is default as 0.
> If we change the direction of the pin before the dout value of the pin,
> It maybe produce a low level output voltage between "input pull-up" and
> "output high".
>
> Signed-off-by: Zhiyong Tao <zhiyong.tao@mediatek.com>
Patch applied!
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH 0/1] Mediatek pinctrl patch
@ 2021-11-04 1:40 Zhiyong Tao
0 siblings, 0 replies; 5+ messages in thread
From: Zhiyong Tao @ 2021-11-04 1:40 UTC (permalink / raw)
To: robh+dt, linus.walleij, mark.rutland, matthias.bgg, sean.wang
Cc: srv_heupstream, zhiyong.tao, hui.liu, light.hsieh, sean.wang,
seiya.wang, rex-bc.chen, devicetree, linux-kernel,
linux-arm-kernel, linux-mediatek, linux-gpio
This series includes 1 patches:
1. fix global-out-of-bounds issue.
Zhiyong Tao (1):
pinctrl: mediatek: fix global-out-of-bounds issue
drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
--
2.18.0
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH 0/1] Mediatek pinctrl patch
@ 2021-03-12 6:35 Zhiyong Tao
0 siblings, 0 replies; 5+ messages in thread
From: Zhiyong Tao @ 2021-03-12 6:35 UTC (permalink / raw)
To: robh+dt, linus.walleij, mark.rutland, matthias.bgg, sean.wang
Cc: srv_heupstream, zhiyong.tao, hui.liu, eddie.huang, jg_poxu,
biao.huang, hongzhou.yang, erin.lo, sean.wang, seiya.wang,
sj.huang, devicetree, linux-kernel, linux-arm-kernel,
linux-mediatek, linux-gpio
This series includes 1 patches:
1.add lock in mtk_rmw function.
Zhiyong Tao (1):
pinctrl: add lock in mtk_rmw function.
drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c | 4 ++++
drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.h | 2 ++
drivers/pinctrl/mediatek/pinctrl-paris.c | 2 ++
3 files changed, 8 insertions(+)
--
2.25.1
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-11-04 1:40 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-20 9:30 [PATCH 0/1] Mediatek pinctrl patch Zhiyong Tao
2020-11-20 9:30 ` [PATCH] pinctrl: fix low level output voltage issue Zhiyong Tao
2020-12-04 8:43 ` Linus Walleij
2021-03-12 6:35 [PATCH 0/1] Mediatek pinctrl patch Zhiyong Tao
2021-11-04 1:40 Zhiyong Tao
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).