* [PATCH] phy: amlogic: meson-axg-mipi-pcie-analog: replace DSI_LANE definitions with BIT() macro
@ 2020-11-20 15:03 Neil Armstrong
2020-11-30 11:00 ` Vinod Koul
0 siblings, 1 reply; 2+ messages in thread
From: Neil Armstrong @ 2020-11-20 15:03 UTC (permalink / raw)
To: kishon, vkoul
Cc: linux-amlogic, linux-kernel, linux-arm-kernel, repk, Neil Armstrong
For consistency, replace DSI_LANE definitions with BIT() macro and remove the unused
DSI_LANE_MASK definition.
Suggested-by: Vinod Koul <vkoul@kernel.org>
Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
---
drivers/phy/amlogic/phy-meson-axg-mipi-pcie-analog.c | 11 +++++------
1 file changed, 5 insertions(+), 6 deletions(-)
diff --git a/drivers/phy/amlogic/phy-meson-axg-mipi-pcie-analog.c b/drivers/phy/amlogic/phy-meson-axg-mipi-pcie-analog.c
index 6eb21551bdd9..1027ece6ca12 100644
--- a/drivers/phy/amlogic/phy-meson-axg-mipi-pcie-analog.c
+++ b/drivers/phy/amlogic/phy-meson-axg-mipi-pcie-analog.c
@@ -38,12 +38,11 @@
#define HHI_MIPI_CNTL2_CH_EN GENMASK(15, 11)
#define HHI_MIPI_CNTL2_CH0_LP_CTL GENMASK(10, 1)
-#define DSI_LANE_0 (1 << 4)
-#define DSI_LANE_1 (1 << 3)
-#define DSI_LANE_CLK (1 << 2)
-#define DSI_LANE_2 (1 << 1)
-#define DSI_LANE_3 (1 << 0)
-#define DSI_LANE_MASK (0x1F)
+#define DSI_LANE_0 BIT(4)
+#define DSI_LANE_1 BIT(3)
+#define DSI_LANE_CLK BIT(2)
+#define DSI_LANE_2 BIT(1)
+#define DSI_LANE_3 BIT(0)
struct phy_axg_mipi_pcie_analog_priv {
struct phy *phy;
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] phy: amlogic: meson-axg-mipi-pcie-analog: replace DSI_LANE definitions with BIT() macro
2020-11-20 15:03 [PATCH] phy: amlogic: meson-axg-mipi-pcie-analog: replace DSI_LANE definitions with BIT() macro Neil Armstrong
@ 2020-11-30 11:00 ` Vinod Koul
0 siblings, 0 replies; 2+ messages in thread
From: Vinod Koul @ 2020-11-30 11:00 UTC (permalink / raw)
To: Neil Armstrong
Cc: kishon, linux-amlogic, linux-kernel, linux-arm-kernel, repk
On 20-11-20, 16:03, Neil Armstrong wrote:
> For consistency, replace DSI_LANE definitions with BIT() macro and remove the unused
> DSI_LANE_MASK definition.
Applied, thanks
--
~Vinod
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-11-30 11:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-20 15:03 [PATCH] phy: amlogic: meson-axg-mipi-pcie-analog: replace DSI_LANE definitions with BIT() macro Neil Armstrong
2020-11-30 11:00 ` Vinod Koul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).