* [PATCH 1/2] mmc: sdhci-sprd: drop of_match_ptr from of_device_id table
@ 2020-11-20 16:23 Krzysztof Kozlowski
2020-11-20 16:23 ` [PATCH 2/2] mmc: sdhci-st: " Krzysztof Kozlowski
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Krzysztof Kozlowski @ 2020-11-20 16:23 UTC (permalink / raw)
To: Adrian Hunter, Ulf Hansson, Orson Zhai, Baolin Wang,
Chunyan Zhang, Patrice Chotard, linux-mmc, linux-kernel,
linux-arm-kernel
Cc: Krzysztof Kozlowski, kernel test robot
The driver can match only via the DT table so the table should be always
used and the of_match_ptr does not have any sense (this also allows ACPI
matching via PRP0001, even though it is not relevant here). This fixes
compile warning (!CONFIG_OF on x86_64):
drivers/mmc/host/sdhci-sprd.c:723:34: warning:
‘sdhci_sprd_of_match’ defined but not used [-Wunused-const-variable=]
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
drivers/mmc/host/sdhci-sprd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mmc/host/sdhci-sprd.c b/drivers/mmc/host/sdhci-sprd.c
index 58109c5b53e2..f85171edabeb 100644
--- a/drivers/mmc/host/sdhci-sprd.c
+++ b/drivers/mmc/host/sdhci-sprd.c
@@ -788,7 +788,7 @@ static struct platform_driver sdhci_sprd_driver = {
.driver = {
.name = "sdhci_sprd_r11",
.probe_type = PROBE_PREFER_ASYNCHRONOUS,
- .of_match_table = of_match_ptr(sdhci_sprd_of_match),
+ .of_match_table = sdhci_sprd_of_match,
.pm = &sdhci_sprd_pm_ops,
},
};
--
2.25.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* [PATCH 2/2] mmc: sdhci-st: drop of_match_ptr from of_device_id table
2020-11-20 16:23 [PATCH 1/2] mmc: sdhci-sprd: drop of_match_ptr from of_device_id table Krzysztof Kozlowski
@ 2020-11-20 16:23 ` Krzysztof Kozlowski
2020-11-23 16:07 ` Ulf Hansson
2020-11-23 5:36 ` [PATCH 1/2] mmc: sdhci-sprd: " Chunyan Zhang
2020-11-23 16:07 ` Ulf Hansson
2 siblings, 1 reply; 5+ messages in thread
From: Krzysztof Kozlowski @ 2020-11-20 16:23 UTC (permalink / raw)
To: Adrian Hunter, Ulf Hansson, Orson Zhai, Baolin Wang,
Chunyan Zhang, Patrice Chotard, linux-mmc, linux-kernel,
linux-arm-kernel
Cc: Krzysztof Kozlowski
The driver can match only via the DT table so the table should be always
used and the of_match_ptr does not have any sense (this also allows ACPI
matching via PRP0001, even though it is not relevant here). This fixes
compile warning (!CONFIG_OF on x86_64):
drivers/mmc/host/sdhci-st.c:512:34: warning:
‘st_sdhci_match’ defined but not used [-Wunused-const-variable=]
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
drivers/mmc/host/sdhci-st.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mmc/host/sdhci-st.c b/drivers/mmc/host/sdhci-st.c
index 4e9ff3e828ba..962872aec164 100644
--- a/drivers/mmc/host/sdhci-st.c
+++ b/drivers/mmc/host/sdhci-st.c
@@ -523,7 +523,7 @@ static struct platform_driver sdhci_st_driver = {
.name = "sdhci-st",
.probe_type = PROBE_PREFER_ASYNCHRONOUS,
.pm = &sdhci_st_pmops,
- .of_match_table = of_match_ptr(st_sdhci_match),
+ .of_match_table = st_sdhci_match,
},
};
--
2.25.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH 2/2] mmc: sdhci-st: drop of_match_ptr from of_device_id table
2020-11-20 16:23 ` [PATCH 2/2] mmc: sdhci-st: " Krzysztof Kozlowski
@ 2020-11-23 16:07 ` Ulf Hansson
0 siblings, 0 replies; 5+ messages in thread
From: Ulf Hansson @ 2020-11-23 16:07 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Adrian Hunter, Orson Zhai, Baolin Wang, Chunyan Zhang,
Patrice Chotard, linux-mmc, Linux Kernel Mailing List, Linux ARM
On Fri, 20 Nov 2020 at 17:23, Krzysztof Kozlowski <krzk@kernel.org> wrote:
>
> The driver can match only via the DT table so the table should be always
> used and the of_match_ptr does not have any sense (this also allows ACPI
> matching via PRP0001, even though it is not relevant here). This fixes
> compile warning (!CONFIG_OF on x86_64):
>
> drivers/mmc/host/sdhci-st.c:512:34: warning:
> ‘st_sdhci_match’ defined but not used [-Wunused-const-variable=]
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Applied for next, thanks!
Kind regards
Uffe
> ---
> drivers/mmc/host/sdhci-st.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/sdhci-st.c b/drivers/mmc/host/sdhci-st.c
> index 4e9ff3e828ba..962872aec164 100644
> --- a/drivers/mmc/host/sdhci-st.c
> +++ b/drivers/mmc/host/sdhci-st.c
> @@ -523,7 +523,7 @@ static struct platform_driver sdhci_st_driver = {
> .name = "sdhci-st",
> .probe_type = PROBE_PREFER_ASYNCHRONOUS,
> .pm = &sdhci_st_pmops,
> - .of_match_table = of_match_ptr(st_sdhci_match),
> + .of_match_table = st_sdhci_match,
> },
> };
>
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] mmc: sdhci-sprd: drop of_match_ptr from of_device_id table
2020-11-20 16:23 [PATCH 1/2] mmc: sdhci-sprd: drop of_match_ptr from of_device_id table Krzysztof Kozlowski
2020-11-20 16:23 ` [PATCH 2/2] mmc: sdhci-st: " Krzysztof Kozlowski
@ 2020-11-23 5:36 ` Chunyan Zhang
2020-11-23 16:07 ` Ulf Hansson
2 siblings, 0 replies; 5+ messages in thread
From: Chunyan Zhang @ 2020-11-23 5:36 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Adrian Hunter, Ulf Hansson, Orson Zhai, Baolin Wang,
Patrice Chotard, linux-mmc, Linux Kernel Mailing List, Linux ARM,
kernel test robot
On Sat, 21 Nov 2020 at 00:23, Krzysztof Kozlowski <krzk@kernel.org> wrote:
>
> The driver can match only via the DT table so the table should be always
> used and the of_match_ptr does not have any sense (this also allows ACPI
> matching via PRP0001, even though it is not relevant here). This fixes
> compile warning (!CONFIG_OF on x86_64):
>
> drivers/mmc/host/sdhci-sprd.c:723:34: warning:
> ‘sdhci_sprd_of_match’ defined but not used [-Wunused-const-variable=]
>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Acked-by: Chunyan Zhang <zhang.lyra@gmail.com>
> ---
> drivers/mmc/host/sdhci-sprd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/sdhci-sprd.c b/drivers/mmc/host/sdhci-sprd.c
> index 58109c5b53e2..f85171edabeb 100644
> --- a/drivers/mmc/host/sdhci-sprd.c
> +++ b/drivers/mmc/host/sdhci-sprd.c
> @@ -788,7 +788,7 @@ static struct platform_driver sdhci_sprd_driver = {
> .driver = {
> .name = "sdhci_sprd_r11",
> .probe_type = PROBE_PREFER_ASYNCHRONOUS,
> - .of_match_table = of_match_ptr(sdhci_sprd_of_match),
> + .of_match_table = sdhci_sprd_of_match,
> .pm = &sdhci_sprd_pm_ops,
> },
> };
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH 1/2] mmc: sdhci-sprd: drop of_match_ptr from of_device_id table
2020-11-20 16:23 [PATCH 1/2] mmc: sdhci-sprd: drop of_match_ptr from of_device_id table Krzysztof Kozlowski
2020-11-20 16:23 ` [PATCH 2/2] mmc: sdhci-st: " Krzysztof Kozlowski
2020-11-23 5:36 ` [PATCH 1/2] mmc: sdhci-sprd: " Chunyan Zhang
@ 2020-11-23 16:07 ` Ulf Hansson
2 siblings, 0 replies; 5+ messages in thread
From: Ulf Hansson @ 2020-11-23 16:07 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Adrian Hunter, Orson Zhai, Baolin Wang, Chunyan Zhang,
Patrice Chotard, linux-mmc, Linux Kernel Mailing List, Linux ARM,
kernel test robot
On Fri, 20 Nov 2020 at 17:23, Krzysztof Kozlowski <krzk@kernel.org> wrote:
>
> The driver can match only via the DT table so the table should be always
> used and the of_match_ptr does not have any sense (this also allows ACPI
> matching via PRP0001, even though it is not relevant here). This fixes
> compile warning (!CONFIG_OF on x86_64):
>
> drivers/mmc/host/sdhci-sprd.c:723:34: warning:
> ‘sdhci_sprd_of_match’ defined but not used [-Wunused-const-variable=]
>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Applied for next, thanks!
Kind regards
Uffe
> ---
> drivers/mmc/host/sdhci-sprd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/sdhci-sprd.c b/drivers/mmc/host/sdhci-sprd.c
> index 58109c5b53e2..f85171edabeb 100644
> --- a/drivers/mmc/host/sdhci-sprd.c
> +++ b/drivers/mmc/host/sdhci-sprd.c
> @@ -788,7 +788,7 @@ static struct platform_driver sdhci_sprd_driver = {
> .driver = {
> .name = "sdhci_sprd_r11",
> .probe_type = PROBE_PREFER_ASYNCHRONOUS,
> - .of_match_table = of_match_ptr(sdhci_sprd_of_match),
> + .of_match_table = sdhci_sprd_of_match,
> .pm = &sdhci_sprd_pm_ops,
> },
> };
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-11-23 16:08 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-20 16:23 [PATCH 1/2] mmc: sdhci-sprd: drop of_match_ptr from of_device_id table Krzysztof Kozlowski
2020-11-20 16:23 ` [PATCH 2/2] mmc: sdhci-st: " Krzysztof Kozlowski
2020-11-23 16:07 ` Ulf Hansson
2020-11-23 5:36 ` [PATCH 1/2] mmc: sdhci-sprd: " Chunyan Zhang
2020-11-23 16:07 ` Ulf Hansson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).