* [PATCH] IB/qib: Use dma_set_mask_and_coherent to simplify code
@ 2020-11-21 9:51 Christophe JAILLET
2020-11-23 15:17 ` Mike Marciniszyn
2020-11-24 12:55 ` Jason Gunthorpe
0 siblings, 2 replies; 3+ messages in thread
From: Christophe JAILLET @ 2020-11-21 9:51 UTC (permalink / raw)
To: dennis.dalessandro, mike.marciniszyn, dledford, jgg
Cc: linux-rdma, linux-kernel, kernel-janitors, Christophe JAILLET
'pci_set_dma_mask()' + 'pci_set_consistent_dma_mask()' can be replaced by
an equivalent 'dma_set_mask_and_coherent()' which is much less verbose.
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
drivers/infiniband/hw/qib/qib_pcie.c | 11 ++---------
1 file changed, 2 insertions(+), 9 deletions(-)
diff --git a/drivers/infiniband/hw/qib/qib_pcie.c b/drivers/infiniband/hw/qib/qib_pcie.c
index 3dc6ce033319..2e07b3749b88 100644
--- a/drivers/infiniband/hw/qib/qib_pcie.c
+++ b/drivers/infiniband/hw/qib/qib_pcie.c
@@ -90,25 +90,18 @@ int qib_pcie_init(struct pci_dev *pdev, const struct pci_device_id *ent)
goto bail;
}
- ret = pci_set_dma_mask(pdev, DMA_BIT_MASK(64));
+ ret = dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(64));
if (ret) {
/*
* If the 64 bit setup fails, try 32 bit. Some systems
* do not setup 64 bit maps on systems with 2GB or less
* memory installed.
*/
- ret = pci_set_dma_mask(pdev, DMA_BIT_MASK(32));
+ ret = dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(32));
if (ret) {
qib_devinfo(pdev, "Unable to set DMA mask: %d\n", ret);
goto bail;
}
- ret = pci_set_consistent_dma_mask(pdev, DMA_BIT_MASK(32));
- } else
- ret = pci_set_consistent_dma_mask(pdev, DMA_BIT_MASK(64));
- if (ret) {
- qib_early_err(&pdev->dev,
- "Unable to set DMA consistent mask: %d\n", ret);
- goto bail;
}
pci_set_master(pdev);
--
2.27.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] IB/qib: Use dma_set_mask_and_coherent to simplify code
2020-11-21 9:51 [PATCH] IB/qib: Use dma_set_mask_and_coherent to simplify code Christophe JAILLET
@ 2020-11-23 15:17 ` Mike Marciniszyn
2020-11-24 12:55 ` Jason Gunthorpe
1 sibling, 0 replies; 3+ messages in thread
From: Mike Marciniszyn @ 2020-11-23 15:17 UTC (permalink / raw)
To: Christophe JAILLET, dennis.dalessandro, dledford, jgg
Cc: linux-rdma, linux-kernel, kernel-janitors
On 11/21/2020 4:51 AM, Christophe JAILLET wrote:
> 'pci_set_dma_mask()' + 'pci_set_consistent_dma_mask()' can be replaced by
> an equivalent 'dma_set_mask_and_coherent()' which is much less verbose.
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Thanks for the patch.
Looks ok to me.
Acked-by: Mike Marciniszyn <mike.marciniszyn@cornelisnetworks.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] IB/qib: Use dma_set_mask_and_coherent to simplify code
2020-11-21 9:51 [PATCH] IB/qib: Use dma_set_mask_and_coherent to simplify code Christophe JAILLET
2020-11-23 15:17 ` Mike Marciniszyn
@ 2020-11-24 12:55 ` Jason Gunthorpe
1 sibling, 0 replies; 3+ messages in thread
From: Jason Gunthorpe @ 2020-11-24 12:55 UTC (permalink / raw)
To: Christophe JAILLET
Cc: dennis.dalessandro, mike.marciniszyn, dledford, linux-rdma,
linux-kernel, kernel-janitors
On Sat, Nov 21, 2020 at 10:51:27AM +0100, Christophe JAILLET wrote:
> 'pci_set_dma_mask()' + 'pci_set_consistent_dma_mask()' can be replaced by
> an equivalent 'dma_set_mask_and_coherent()' which is much less verbose.
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> Acked-by: Mike Marciniszyn <mike.marciniszyn@cornelisnetworks.com>
> ---
> drivers/infiniband/hw/qib/qib_pcie.c | 11 ++---------
> 1 file changed, 2 insertions(+), 9 deletions(-)
Applied to for-next, thanks
Jason
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-11-24 12:55 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-21 9:51 [PATCH] IB/qib: Use dma_set_mask_and_coherent to simplify code Christophe JAILLET
2020-11-23 15:17 ` Mike Marciniszyn
2020-11-24 12:55 ` Jason Gunthorpe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).