* [PATCH] zlib: export S390 symbols for zlib modules
@ 2020-11-23 19:17 Randy Dunlap
2020-11-23 19:20 ` Ilya Leoshkevich
0 siblings, 1 reply; 2+ messages in thread
From: Randy Dunlap @ 2020-11-23 19:17 UTC (permalink / raw)
To: linux-kernel
Cc: Randy Dunlap, kernel test robot, Mikhail Zaslonko,
Ilya Leoshkevich, Andrew Morton, Heiko Carstens, Vasily Gorbik,
Christian Borntraeger, linux-s390
Fix build errors when ZLIB_INFLATE=m and ZLIB_DEFLATE=m
and ZLIB_DFLTCC=y by exporting the 2 needed symbols in
dfltcc_inflate.c.
Fixes these build errors:
ERROR: modpost: "dfltcc_inflate" [lib/zlib_inflate/zlib_inflate.ko] undefined!
ERROR: modpost: "dfltcc_can_inflate" [lib/zlib_inflate/zlib_inflate.ko] undefined!
Fixes: 126196100063 ("lib/zlib: add s390 hardware support for kernel zlib_inflate")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Reported-by: kernel test robot <lkp@intel.com>
Cc: Mikhail Zaslonko <zaslonko@linux.ibm.com>
Cc: Ilya Leoshkevich <iii@linux.ibm.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Heiko Carstens <hca@linux.ibm.com>
Cc: Vasily Gorbik <gor@linux.ibm.com>
Cc: Christian Borntraeger <borntraeger@de.ibm.com>
Cc: linux-s390@vger.kernel.org
---
lib/zlib_dfltcc/dfltcc_inflate.c | 3 +++
1 file changed, 3 insertions(+)
--- linux-next-20201120.orig/lib/zlib_dfltcc/dfltcc_inflate.c
+++ linux-next-20201120/lib/zlib_dfltcc/dfltcc_inflate.c
@@ -4,6 +4,7 @@
#include "dfltcc_util.h"
#include "dfltcc.h"
#include <asm/setup.h>
+#include <linux/export.h>
#include <linux/zutil.h>
/*
@@ -29,6 +30,7 @@ int dfltcc_can_inflate(
return is_bit_set(dfltcc_state->af.fns, DFLTCC_XPND) &&
is_bit_set(dfltcc_state->af.fmts, DFLTCC_FMT0);
}
+EXPORT_SYMBOL(dfltcc_can_inflate);
static int dfltcc_was_inflate_used(
z_streamp strm
@@ -147,3 +149,4 @@ dfltcc_inflate_action dfltcc_inflate(
return (cc == DFLTCC_CC_OP1_TOO_SHORT || cc == DFLTCC_CC_OP2_TOO_SHORT) ?
DFLTCC_INFLATE_BREAK : DFLTCC_INFLATE_CONTINUE;
}
+EXPORT_SYMBOL(dfltcc_inflate);
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] zlib: export S390 symbols for zlib modules
2020-11-23 19:17 [PATCH] zlib: export S390 symbols for zlib modules Randy Dunlap
@ 2020-11-23 19:20 ` Ilya Leoshkevich
0 siblings, 0 replies; 2+ messages in thread
From: Ilya Leoshkevich @ 2020-11-23 19:20 UTC (permalink / raw)
To: Randy Dunlap, linux-kernel
Cc: kernel test robot, Mikhail Zaslonko, Andrew Morton,
Heiko Carstens, Vasily Gorbik, Christian Borntraeger, linux-s390
On Mon, 2020-11-23 at 11:17 -0800, Randy Dunlap wrote:
> Fix build errors when ZLIB_INFLATE=m and ZLIB_DEFLATE=m
> and ZLIB_DFLTCC=y by exporting the 2 needed symbols in
> dfltcc_inflate.c.
>
> Fixes these build errors:
>
> ERROR: modpost: "dfltcc_inflate" [lib/zlib_inflate/zlib_inflate.ko]
> undefined!
> ERROR: modpost: "dfltcc_can_inflate"
> [lib/zlib_inflate/zlib_inflate.ko] undefined!
>
> Fixes: 126196100063 ("lib/zlib: add s390 hardware support for kernel
> zlib_inflate")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Reported-by: kernel test robot <lkp@intel.com>
> Cc: Mikhail Zaslonko <zaslonko@linux.ibm.com>
> Cc: Ilya Leoshkevich <iii@linux.ibm.com>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Cc: Heiko Carstens <hca@linux.ibm.com>
> Cc: Vasily Gorbik <gor@linux.ibm.com>
> Cc: Christian Borntraeger <borntraeger@de.ibm.com>
> Cc: linux-s390@vger.kernel.org
> ---
> lib/zlib_dfltcc/dfltcc_inflate.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> --- linux-next-20201120.orig/lib/zlib_dfltcc/dfltcc_inflate.c
> +++ linux-next-20201120/lib/zlib_dfltcc/dfltcc_inflate.c
> @@ -4,6 +4,7 @@
> #include "dfltcc_util.h"
> #include "dfltcc.h"
> #include <asm/setup.h>
> +#include <linux/export.h>
> #include <linux/zutil.h>
>
> /*
> @@ -29,6 +30,7 @@ int dfltcc_can_inflate(
> return is_bit_set(dfltcc_state->af.fns, DFLTCC_XPND) &&
> is_bit_set(dfltcc_state->af.fmts, DFLTCC_FMT0);
> }
> +EXPORT_SYMBOL(dfltcc_can_inflate);
>
> static int dfltcc_was_inflate_used(
> z_streamp strm
> @@ -147,3 +149,4 @@ dfltcc_inflate_action dfltcc_inflate(
> return (cc == DFLTCC_CC_OP1_TOO_SHORT || cc ==
> DFLTCC_CC_OP2_TOO_SHORT) ?
> DFLTCC_INFLATE_BREAK : DFLTCC_INFLATE_CONTINUE;
> }
> +EXPORT_SYMBOL(dfltcc_inflate);
Thanks for fixing this!
Acked-by: Ilya Leoshkevich <iii@linux.ibm.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-11-23 19:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-23 19:17 [PATCH] zlib: export S390 symbols for zlib modules Randy Dunlap
2020-11-23 19:20 ` Ilya Leoshkevich
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).