* [PATCH] dma-mapping: fix an uninitialized pointer read due to typo in argp assignment
@ 2020-11-25 13:55 Colin King
2020-11-25 18:22 ` Song Bao Hua (Barry Song)
0 siblings, 1 reply; 3+ messages in thread
From: Colin King @ 2020-11-25 13:55 UTC (permalink / raw)
To: Barry Song, Christoph Hellwig, Marek Szyprowski, Robin Murphy, iommu
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
The assignment of argp is currently using argp as the source because of
a typo. Fix this by assigning it the value passed in arg instead.
Addresses-Coverity: ("Uninitialized pointer read")
Fixes: bfd2defed94d ("dma-mapping: add benchmark support for streaming DMA APIs")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
kernel/dma/map_benchmark.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/dma/map_benchmark.c b/kernel/dma/map_benchmark.c
index ca616b664f72..e1e37603d01b 100644
--- a/kernel/dma/map_benchmark.c
+++ b/kernel/dma/map_benchmark.c
@@ -192,7 +192,7 @@ static long map_benchmark_ioctl(struct file *file, unsigned int cmd,
unsigned long arg)
{
struct map_benchmark_data *map = file->private_data;
- void __user *argp = (void __user *)argp;
+ void __user *argp = (void __user *)arg;
u64 old_dma_mask;
int ret;
--
2.29.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* RE: [PATCH] dma-mapping: fix an uninitialized pointer read due to typo in argp assignment
2020-11-25 13:55 [PATCH] dma-mapping: fix an uninitialized pointer read due to typo in argp assignment Colin King
@ 2020-11-25 18:22 ` Song Bao Hua (Barry Song)
2020-11-25 18:29 ` Christoph Hellwig
0 siblings, 1 reply; 3+ messages in thread
From: Song Bao Hua (Barry Song) @ 2020-11-25 18:22 UTC (permalink / raw)
To: Colin King, Christoph Hellwig, Marek Szyprowski, Robin Murphy, iommu
Cc: kernel-janitors, linux-kernel
> -----Original Message-----
> From: Colin King [mailto:colin.king@canonical.com]
> Sent: Thursday, November 26, 2020 2:56 AM
> To: Song Bao Hua (Barry Song) <song.bao.hua@hisilicon.com>; Christoph
> Hellwig <hch@lst.de>; Marek Szyprowski <m.szyprowski@samsung.com>;
> Robin Murphy <robin.murphy@arm.com>; iommu@lists.linux-foundation.org
> Cc: kernel-janitors@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: [PATCH] dma-mapping: fix an uninitialized pointer read due to typo in
> argp assignment
>
> From: Colin Ian King <colin.king@canonical.com>
>
> The assignment of argp is currently using argp as the source because of
> a typo. Fix this by assigning it the value passed in arg instead.
>
> Addresses-Coverity: ("Uninitialized pointer read")
> Fixes: bfd2defed94d ("dma-mapping: add benchmark support for streaming
> DMA APIs")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Acked-by: Barry Song <song.bao.hua@hisilicon.com>
> ---
> kernel/dma/map_benchmark.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/dma/map_benchmark.c b/kernel/dma/map_benchmark.c
> index ca616b664f72..e1e37603d01b 100644
> --- a/kernel/dma/map_benchmark.c
> +++ b/kernel/dma/map_benchmark.c
> @@ -192,7 +192,7 @@ static long map_benchmark_ioctl(struct file *file,
> unsigned int cmd,
> unsigned long arg)
> {
> struct map_benchmark_data *map = file->private_data;
> - void __user *argp = (void __user *)argp;
> + void __user *argp = (void __user *)arg;
> u64 old_dma_mask;
>
> int ret;
> --
> 2.29.2
Thanks
Barry
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] dma-mapping: fix an uninitialized pointer read due to typo in argp assignment
2020-11-25 18:22 ` Song Bao Hua (Barry Song)
@ 2020-11-25 18:29 ` Christoph Hellwig
0 siblings, 0 replies; 3+ messages in thread
From: Christoph Hellwig @ 2020-11-25 18:29 UTC (permalink / raw)
To: Song Bao Hua (Barry Song)
Cc: Colin King, Christoph Hellwig, Marek Szyprowski, Robin Murphy,
iommu, kernel-janitors, linux-kernel
Ooops, that was my edit. I'll make sure to fold the fix into the
original commit.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-11-25 18:29 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-25 13:55 [PATCH] dma-mapping: fix an uninitialized pointer read due to typo in argp assignment Colin King
2020-11-25 18:22 ` Song Bao Hua (Barry Song)
2020-11-25 18:29 ` Christoph Hellwig
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).