* lib/crypto/blake2s-selftest.c:566:13: warning: no previous prototype for 'blake2s_selftest'
@ 2020-11-13 8:02 kernel test robot
2020-11-27 5:41 ` [PATCH] crypto: lib/blake2s - Move selftest prototype into header file Herbert Xu
0 siblings, 1 reply; 3+ messages in thread
From: kernel test robot @ 2020-11-13 8:02 UTC (permalink / raw)
To: Jason A. Donenfeld
Cc: kbuild-all, linux-kernel, Herbert Xu, Samuel Neves, Ard Biesheuvel
[-- Attachment #1: Type: text/plain, Size: 1586 bytes --]
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 585e5b17b92dead8a3aca4e3c9876fbca5f7e0ba
commit: 66d7fb94e4ffe5acc589e0b2b4710aecc1f07a28 crypto: blake2s - generic C library implementation and selftest
date: 12 months ago
config: parisc-randconfig-r003-20201113 (attached as .config)
compiler: hppa-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=66d7fb94e4ffe5acc589e0b2b4710aecc1f07a28
git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
git fetch --no-tags linus master
git checkout 66d7fb94e4ffe5acc589e0b2b4710aecc1f07a28
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=parisc
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
>> lib/crypto/blake2s-selftest.c:566:13: warning: no previous prototype for 'blake2s_selftest' [-Wmissing-prototypes]
566 | bool __init blake2s_selftest(void)
| ^~~~~~~~~~~~~~~~
vim +/blake2s_selftest +566 lib/crypto/blake2s-selftest.c
565
> 566 bool __init blake2s_selftest(void)
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 29334 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] crypto: lib/blake2s - Move selftest prototype into header file
2020-11-13 8:02 lib/crypto/blake2s-selftest.c:566:13: warning: no previous prototype for 'blake2s_selftest' kernel test robot
@ 2020-11-27 5:41 ` Herbert Xu
2020-11-27 5:43 ` [v2 PATCH] " Herbert Xu
0 siblings, 1 reply; 3+ messages in thread
From: Herbert Xu @ 2020-11-27 5:41 UTC (permalink / raw)
To: kernel test robot
Cc: Jason A. Donenfeld, kbuild-all, linux-kernel, Samuel Neves,
Ard Biesheuvel, Linux Crypto Mailing List
On Fri, Nov 13, 2020 at 04:02:28PM +0800, kernel test robot wrote:
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> head: 585e5b17b92dead8a3aca4e3c9876fbca5f7e0ba
> commit: 66d7fb94e4ffe5acc589e0b2b4710aecc1f07a28 crypto: blake2s - generic C library implementation and selftest
> date: 12 months ago
> config: parisc-randconfig-r003-20201113 (attached as .config)
> compiler: hppa-linux-gcc (GCC) 9.3.0
> reproduce (this is a W=1 build):
> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> chmod +x ~/bin/make.cross
> # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=66d7fb94e4ffe5acc589e0b2b4710aecc1f07a28
> git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
> git fetch --no-tags linus master
> git checkout 66d7fb94e4ffe5acc589e0b2b4710aecc1f07a28
> # save the attached .config to linux build tree
> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=parisc
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
>
> All warnings (new ones prefixed by >>):
>
> >> lib/crypto/blake2s-selftest.c:566:13: warning: no previous prototype for 'blake2s_selftest' [-Wmissing-prototypes]
> 566 | bool __init blake2s_selftest(void)
> | ^~~~~~~~~~~~~~~~
>
> vim +/blake2s_selftest +566 lib/crypto/blake2s-selftest.c
>
> 565
> > 566 bool __init blake2s_selftest(void)
---8<---
This patch fixes a missing prototype warning on blake2s_selftest.
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
diff --git a/include/crypto/internal/blake2s.h b/include/crypto/internal/blake2s.h
index 74ff77032e52..6e376ae6b6b5 100644
--- a/include/crypto/internal/blake2s.h
+++ b/include/crypto/internal/blake2s.h
@@ -16,6 +16,8 @@ void blake2s_compress_generic(struct blake2s_state *state,const u8 *block,
void blake2s_compress_arch(struct blake2s_state *state,const u8 *block,
size_t nblocks, const u32 inc);
+bool blake2s_selftest(void);
+
static inline void blake2s_set_lastblock(struct blake2s_state *state)
{
state->f[0] = -1;
diff --git a/lib/crypto/blake2s.c b/lib/crypto/blake2s.c
index 41025a30c524..6a4b6b78d630 100644
--- a/lib/crypto/blake2s.c
+++ b/lib/crypto/blake2s.c
@@ -17,8 +17,6 @@
#include <linux/bug.h>
#include <asm/unaligned.h>
-bool blake2s_selftest(void);
-
void blake2s_update(struct blake2s_state *state, const u8 *in, size_t inlen)
{
const size_t fill = BLAKE2S_BLOCK_SIZE - state->buflen;
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [v2 PATCH] crypto: lib/blake2s - Move selftest prototype into header file
2020-11-27 5:41 ` [PATCH] crypto: lib/blake2s - Move selftest prototype into header file Herbert Xu
@ 2020-11-27 5:43 ` Herbert Xu
0 siblings, 0 replies; 3+ messages in thread
From: Herbert Xu @ 2020-11-27 5:43 UTC (permalink / raw)
To: kernel test robot
Cc: Jason A. Donenfeld, kbuild-all, linux-kernel, Samuel Neves,
Ard Biesheuvel, Linux Crypto Mailing List
v2
Actually include the header file.
---8<---
This patch fixes a missing prototype warning on blake2s_selftest.
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
diff --git a/include/crypto/internal/blake2s.h b/include/crypto/internal/blake2s.h
index 74ff77032e52..6e376ae6b6b5 100644
--- a/include/crypto/internal/blake2s.h
+++ b/include/crypto/internal/blake2s.h
@@ -16,6 +16,8 @@ void blake2s_compress_generic(struct blake2s_state *state,const u8 *block,
void blake2s_compress_arch(struct blake2s_state *state,const u8 *block,
size_t nblocks, const u32 inc);
+bool blake2s_selftest(void);
+
static inline void blake2s_set_lastblock(struct blake2s_state *state)
{
state->f[0] = -1;
diff --git a/lib/crypto/blake2s-selftest.c b/lib/crypto/blake2s-selftest.c
index 79ef404a990d..5d9ea53be973 100644
--- a/lib/crypto/blake2s-selftest.c
+++ b/lib/crypto/blake2s-selftest.c
@@ -3,7 +3,7 @@
* Copyright (C) 2015-2019 Jason A. Donenfeld <Jason@zx2c4.com>. All Rights Reserved.
*/
-#include <crypto/blake2s.h>
+#include <crypto/internal/blake2s.h>
#include <linux/string.h>
/*
diff --git a/lib/crypto/blake2s.c b/lib/crypto/blake2s.c
index 41025a30c524..6a4b6b78d630 100644
--- a/lib/crypto/blake2s.c
+++ b/lib/crypto/blake2s.c
@@ -17,8 +17,6 @@
#include <linux/bug.h>
#include <asm/unaligned.h>
-bool blake2s_selftest(void);
-
void blake2s_update(struct blake2s_state *state, const u8 *in, size_t inlen)
{
const size_t fill = BLAKE2S_BLOCK_SIZE - state->buflen;
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-11-27 5:43 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-13 8:02 lib/crypto/blake2s-selftest.c:566:13: warning: no previous prototype for 'blake2s_selftest' kernel test robot
2020-11-27 5:41 ` [PATCH] crypto: lib/blake2s - Move selftest prototype into header file Herbert Xu
2020-11-27 5:43 ` [v2 PATCH] " Herbert Xu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).