* [PATCH] NFS: remove trailing semicolon in macro definition
@ 2020-11-27 19:43 trix
2020-11-29 16:42 ` Trond Myklebust
0 siblings, 1 reply; 4+ messages in thread
From: trix @ 2020-11-27 19:43 UTC (permalink / raw)
To: bfields, chuck.lever, trond.myklebust, anna.schumaker, davem, kuba
Cc: linux-nfs, netdev, linux-kernel, Tom Rix
From: Tom Rix <trix@redhat.com>
The macro use will already have a semicolon.
Signed-off-by: Tom Rix <trix@redhat.com>
---
net/sunrpc/auth_gss/gss_generic_token.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/sunrpc/auth_gss/gss_generic_token.c b/net/sunrpc/auth_gss/gss_generic_token.c
index fe97f3106536..9ae22d797390 100644
--- a/net/sunrpc/auth_gss/gss_generic_token.c
+++ b/net/sunrpc/auth_gss/gss_generic_token.c
@@ -46,7 +46,7 @@
/* TWRITE_STR from gssapiP_generic.h */
#define TWRITE_STR(ptr, str, len) \
memcpy((ptr), (char *) (str), (len)); \
- (ptr) += (len);
+ (ptr) += (len)
/* XXXX this code currently makes the assumption that a mech oid will
never be longer than 127 bytes. This assumption is not inherent in
--
2.18.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] NFS: remove trailing semicolon in macro definition
2020-11-27 19:43 [PATCH] NFS: remove trailing semicolon in macro definition trix
@ 2020-11-29 16:42 ` Trond Myklebust
2020-11-29 16:50 ` Trond Myklebust
0 siblings, 1 reply; 4+ messages in thread
From: Trond Myklebust @ 2020-11-29 16:42 UTC (permalink / raw)
To: bfields, kuba, anna.schumaker, trix, chuck.lever, davem
Cc: linux-nfs, netdev, linux-kernel
Hi Tom,
On Fri, 2020-11-27 at 11:43 -0800, trix@redhat.com wrote:
> From: Tom Rix <trix@redhat.com>
>
> The macro use will already have a semicolon.
>
> Signed-off-by: Tom Rix <trix@redhat.com>
> ---
> net/sunrpc/auth_gss/gss_generic_token.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/sunrpc/auth_gss/gss_generic_token.c
> b/net/sunrpc/auth_gss/gss_generic_token.c
> index fe97f3106536..9ae22d797390 100644
> --- a/net/sunrpc/auth_gss/gss_generic_token.c
> +++ b/net/sunrpc/auth_gss/gss_generic_token.c
> @@ -46,7 +46,7 @@
> /* TWRITE_STR from gssapiP_generic.h */
> #define TWRITE_STR(ptr, str, len) \
> memcpy((ptr), (char *) (str), (len)); \
> - (ptr) += (len);
> + (ptr) += (len)
>
> /* XXXX this code currently makes the assumption that a mech oid
> will
> never be longer than 127 bytes. This assumption is not inherent
> in
There is exactly 1 use of this macro in the code AFAICS. Can we please
just get rid of it, and make the code trivially easier to read?
Thanks
Trond
--
Trond Myklebust
Linux NFS client maintainer, Hammerspace
trond.myklebust@hammerspace.com
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] NFS: remove trailing semicolon in macro definition
2020-11-29 16:42 ` Trond Myklebust
@ 2020-11-29 16:50 ` Trond Myklebust
2020-11-29 17:07 ` Tom Rix
0 siblings, 1 reply; 4+ messages in thread
From: Trond Myklebust @ 2020-11-29 16:50 UTC (permalink / raw)
To: bfields, davem, kuba, anna.schumaker, trix, chuck.lever
Cc: linux-nfs, netdev, linux-kernel
On Sun, 2020-11-29 at 16:42 +0000, Trond Myklebust wrote:
> Hi Tom,
>
> On Fri, 2020-11-27 at 11:43 -0800, trix@redhat.com wrote:
> > From: Tom Rix <trix@redhat.com>
> >
> > The macro use will already have a semicolon.
> >
> > Signed-off-by: Tom Rix <trix@redhat.com>
> > ---
> > net/sunrpc/auth_gss/gss_generic_token.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/net/sunrpc/auth_gss/gss_generic_token.c
> > b/net/sunrpc/auth_gss/gss_generic_token.c
> > index fe97f3106536..9ae22d797390 100644
> > --- a/net/sunrpc/auth_gss/gss_generic_token.c
> > +++ b/net/sunrpc/auth_gss/gss_generic_token.c
> > @@ -46,7 +46,7 @@
> > /* TWRITE_STR from gssapiP_generic.h */
> > #define TWRITE_STR(ptr, str, len) \
> > memcpy((ptr), (char *) (str), (len)); \
> > - (ptr) += (len);
> > + (ptr) += (len)
> >
> > /* XXXX this code currently makes the assumption that a mech oid
> > will
> > never be longer than 127 bytes. This assumption is not
> > inherent
> > in
>
> There is exactly 1 use of this macro in the code AFAICS. Can we
> please
> just get rid of it, and make the code trivially easier to read?
>
BTW: To illustrate just how obfuscating this kind of macro can be, note
that the line you are changing above will be completely optimised away
in the 1 use case we're talking about. It is bumping a pointer value
that immediately gets discarded.
--
Trond Myklebust
Linux NFS client maintainer, Hammerspace
trond.myklebust@hammerspace.com
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] NFS: remove trailing semicolon in macro definition
2020-11-29 16:50 ` Trond Myklebust
@ 2020-11-29 17:07 ` Tom Rix
0 siblings, 0 replies; 4+ messages in thread
From: Tom Rix @ 2020-11-29 17:07 UTC (permalink / raw)
To: Trond Myklebust, bfields, davem, kuba, anna.schumaker, chuck.lever
Cc: linux-nfs, netdev, linux-kernel
On 11/29/20 8:50 AM, Trond Myklebust wrote:
> On Sun, 2020-11-29 at 16:42 +0000, Trond Myklebust wrote:
>> Hi Tom,
>>
>> On Fri, 2020-11-27 at 11:43 -0800, trix@redhat.com wrote:
>>> From: Tom Rix <trix@redhat.com>
>>>
>>> The macro use will already have a semicolon.
>>>
>>> Signed-off-by: Tom Rix <trix@redhat.com>
>>> ---
>>> net/sunrpc/auth_gss/gss_generic_token.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/net/sunrpc/auth_gss/gss_generic_token.c
>>> b/net/sunrpc/auth_gss/gss_generic_token.c
>>> index fe97f3106536..9ae22d797390 100644
>>> --- a/net/sunrpc/auth_gss/gss_generic_token.c
>>> +++ b/net/sunrpc/auth_gss/gss_generic_token.c
>>> @@ -46,7 +46,7 @@
>>> /* TWRITE_STR from gssapiP_generic.h */
>>> #define TWRITE_STR(ptr, str, len) \
>>> memcpy((ptr), (char *) (str), (len)); \
>>> - (ptr) += (len);
>>> + (ptr) += (len)
>>>
>>> /* XXXX this code currently makes the assumption that a mech oid
>>> will
>>> never be longer than 127 bytes. This assumption is not
>>> inherent
>>> in
>> There is exactly 1 use of this macro in the code AFAICS. Can we
>> please
>> just get rid of it, and make the code trivially easier to read?
>>
>
> BTW: To illustrate just how obfuscating this kind of macro can be, note
> that the line you are changing above will be completely optimised away
> in the 1 use case we're talking about. It is bumping a pointer value
> that immediately gets discarded.
Yes, I agree.
I was wondering about expanding treewide, all the single shot macros defined/used in c files.
other fixers that cleanup unused variables would remove the unneeded expansions like this one.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-11-29 17:09 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-27 19:43 [PATCH] NFS: remove trailing semicolon in macro definition trix
2020-11-29 16:42 ` Trond Myklebust
2020-11-29 16:50 ` Trond Myklebust
2020-11-29 17:07 ` Tom Rix
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).