[PATCH 3/3] media: xilinx: fix error return code in xvip_graph_init

* [PATCH 3/3] media: xilinx: fix error return code in xvip_graph_init
@ 2020-11-28 10:20 Qinglang Miao
  0 siblings, 0 replies; only message in thread
From: Qinglang Miao @ 2020-11-28 10:20 UTC (permalink / raw)
  To: Hyun Kwon, Laurent Pinchart, Mauro Carvalho Chehab, Michal Simek
  Cc: linux-media, linux-arm-kernel, linux-kernel, Qinglang Miao

Fix to return a negative error code(-ENODEV) from the error
handling case instead of 0, as done elsewhere in this function.

Fixes: df3305156f98 ("[media] v4l: xilinx: Add Xilinx Video IP core")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Qinglang Miao <miaoqinglang@huawei.com>
---
 drivers/media/platform/xilinx/xilinx-vipp.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/media/platform/xilinx/xilinx-vipp.c b/drivers/media/platform/xilinx/xilinx-vipp.c
index cc2856efe..9cab2f77f 100644
--- a/drivers/media/platform/xilinx/xilinx-vipp.c
+++ b/drivers/media/platform/xilinx/xilinx-vipp.c
@@ -525,6 +525,7 @@ static int xvip_graph_init(struct xvip_composite_device *xdev)
 
 	if (list_empty(&xdev->notifier.asd_list)) {
 		dev_err(xdev->dev, "no subdev found in graph\n");
+		ret = -ENODEV;
 		goto done;
 	}
 
-- 
2.23.0


^ permalink raw reply related	[flat|nested] only message in thread