linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] net: broadcom CNIC: requires MMU
@ 2020-11-29  7:08 Randy Dunlap
  2020-12-01 20:00 ` patchwork-bot+netdevbpf
  0 siblings, 1 reply; 2+ messages in thread
From: Randy Dunlap @ 2020-11-29  7:08 UTC (permalink / raw)
  To: linux-kernel
  Cc: Randy Dunlap, Jeff Kirsher, Rasesh Mody, GR-Linux-NIC-Dev,
	David S. Miller, Jakub Kicinski, netdev

The CNIC kconfig symbol selects UIO and UIO depends on MMU.
Since 'select' does not follow dependency chains, add the same MMU
dependency to CNIC.

Quietens this kconfig warning:

WARNING: unmet direct dependencies detected for UIO
  Depends on [n]: MMU [=n]
  Selected by [m]:
  - CNIC [=m] && NETDEVICES [=y] && ETHERNET [=y] && NET_VENDOR_BROADCOM [=y] && PCI [=y] && (IPV6 [=m] || IPV6 [=m]=n)

Fixes: adfc5217e9db ("broadcom: Move the Broadcom drivers")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Cc: Rasesh Mody <rmody@marvell.com>
Cc: GR-Linux-NIC-Dev@marvell.com
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Jakub Kicinski <kuba@kernel.org>
Cc: netdev@vger.kernel.org
---
This isn't really the correct Fixes: tag, but I don't know how to go
backwards in git history to find it. :(

 drivers/net/ethernet/broadcom/Kconfig |    1 +
 1 file changed, 1 insertions(+)

--- linux-next-20201125.orig/drivers/net/ethernet/broadcom/Kconfig
+++ linux-next-20201125/drivers/net/ethernet/broadcom/Kconfig
@@ -88,6 +88,7 @@ config BNX2
 config CNIC
 	tristate "QLogic CNIC support"
 	depends on PCI && (IPV6 || IPV6=n)
+	depends on MMU
 	select BNX2
 	select UIO
 	help

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] net: broadcom CNIC: requires MMU
  2020-11-29  7:08 [PATCH] net: broadcom CNIC: requires MMU Randy Dunlap
@ 2020-12-01 20:00 ` patchwork-bot+netdevbpf
  0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2020-12-01 20:00 UTC (permalink / raw)
  To: Randy Dunlap
  Cc: linux-kernel, jeffrey.t.kirsher, rmody, GR-Linux-NIC-Dev, davem,
	kuba, netdev

Hello:

This patch was applied to netdev/net.git (refs/heads/master):

On Sat, 28 Nov 2020 23:08:43 -0800 you wrote:
> The CNIC kconfig symbol selects UIO and UIO depends on MMU.
> Since 'select' does not follow dependency chains, add the same MMU
> dependency to CNIC.
> 
> Quietens this kconfig warning:
> 
> WARNING: unmet direct dependencies detected for UIO
>   Depends on [n]: MMU [=n]
>   Selected by [m]:
>   - CNIC [=m] && NETDEVICES [=y] && ETHERNET [=y] && NET_VENDOR_BROADCOM [=y] && PCI [=y] && (IPV6 [=m] || IPV6 [=m]=n)
> 
> [...]

Here is the summary with links:
  - net: broadcom CNIC: requires MMU
    https://git.kernel.org/netdev/net/c/14483cbf040f

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-12-01 20:01 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-29  7:08 [PATCH] net: broadcom CNIC: requires MMU Randy Dunlap
2020-12-01 20:00 ` patchwork-bot+netdevbpf

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).