* [PATCH 1/2] interconnect: qcom: sdm660: Fix the kerneldoc for qcom_icc_provider
@ 2020-11-30 10:18 Georgi Djakov
2020-11-30 10:18 ` [PATCH 2/2] interconnect: qcom: sdm660: Remove unused macros Georgi Djakov
0 siblings, 1 reply; 2+ messages in thread
From: Georgi Djakov @ 2020-11-30 10:18 UTC (permalink / raw)
To: kholk11
Cc: bjorn.andersson, linux-pm, linux-arm-msm, linux-kernel, georgi.djakov
Fix the following warning by documenting the regmap field:
sdm660.c:191: warning: Function parameter or member 'regmap' not
described in 'qcom_icc_provider'
Signed-off-by: Georgi Djakov <georgi.djakov@linaro.org>
---
drivers/interconnect/qcom/sdm660.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/interconnect/qcom/sdm660.c b/drivers/interconnect/qcom/sdm660.c
index 6953d6d99a11..dbcfc8f15738 100644
--- a/drivers/interconnect/qcom/sdm660.c
+++ b/drivers/interconnect/qcom/sdm660.c
@@ -179,6 +179,7 @@ static const struct clk_bulk_data bus_mm_clocks[] = {
* @bus_clks: the clk_bulk_data table of bus clocks
* @num_clks: the total number of clk_bulk_data entries
* @is_bimc_node: indicates whether to use bimc specific setting
+ * @regmap: regmap for accessing the QoS registers
* @mmio: NoC base iospace
*/
struct qcom_icc_provider {
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH 2/2] interconnect: qcom: sdm660: Remove unused macros
2020-11-30 10:18 [PATCH 1/2] interconnect: qcom: sdm660: Fix the kerneldoc for qcom_icc_provider Georgi Djakov
@ 2020-11-30 10:18 ` Georgi Djakov
0 siblings, 0 replies; 2+ messages in thread
From: Georgi Djakov @ 2020-11-30 10:18 UTC (permalink / raw)
To: kholk11
Cc: bjorn.andersson, linux-pm, linux-arm-msm, linux-kernel, georgi.djakov
The following is observed when compiling with -Wunused-macros:
sdm660.c:43: warning: macro "NOC_PERM_MODE_FIXED" is not used
sdm660.c:44: warning: macro "NOC_PERM_MODE_BYPASS" is not used
sdm660.c:39: warning: macro "NOC_QOS_MODE_LIMITER" is not used
These are not used anywhere in the code, so let's remove them.
Signed-off-by: Georgi Djakov <georgi.djakov@linaro.org>
---
drivers/interconnect/qcom/sdm660.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/interconnect/qcom/sdm660.c b/drivers/interconnect/qcom/sdm660.c
index dbcfc8f15738..bf7e544129c3 100644
--- a/drivers/interconnect/qcom/sdm660.c
+++ b/drivers/interconnect/qcom/sdm660.c
@@ -36,13 +36,9 @@
/* Valid for both NoC and BIMC */
#define NOC_QOS_MODE_FIXED 0x0
-#define NOC_QOS_MODE_LIMITER 0x1
#define NOC_QOS_MODE_BYPASS 0x2
/* NoC QoS */
-#define NOC_PERM_MODE_FIXED 1
-#define NOC_PERM_MODE_BYPASS (1 << NOC_QOS_MODE_BYPASS)
-
#define NOC_QOS_PRIORITYn_ADDR(n) (0x8 + (n * 0x1000))
#define NOC_QOS_PRIORITY_MASK 0xf
#define NOC_QOS_PRIORITY_P1_SHIFT 0x2
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-11-30 10:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-30 10:18 [PATCH 1/2] interconnect: qcom: sdm660: Fix the kerneldoc for qcom_icc_provider Georgi Djakov
2020-11-30 10:18 ` [PATCH 2/2] interconnect: qcom: sdm660: Remove unused macros Georgi Djakov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).