* [RESEND PATCH 1/3] drm/mediatek: Separate mtk_mipi_tx to an independent module
2020-11-16 23:14 [RESEND PATCH 0/3] Move Mediatek MIPI DSI PHY driver from DRM folder to PHY folder Chun-Kuang Hu
@ 2020-11-16 23:14 ` Chun-Kuang Hu
2020-11-16 23:14 ` [RESEND PATCH 2/3] phy: mediatek: Move mtk_mipi_dsi_phy driver into drivers/phy/mediatek folder Chun-Kuang Hu
2020-11-16 23:14 ` [RESEND PATCH 3/3] MAINTAINERS: add files for Mediatek DRM drivers Chun-Kuang Hu
2 siblings, 0 replies; 9+ messages in thread
From: Chun-Kuang Hu @ 2020-11-16 23:14 UTC (permalink / raw)
To: Philipp Zabel, David Airlie, Daniel Vetter, Matthias Brugger,
Vinod Koul, Chunfeng Yun, Kishon Vijay Abraham I
Cc: linux-kernel, dri-devel, linux-mediatek, Chun-Kuang Hu
mtk_mipi_tx is a part of mtk_drm module, but phy driver should be an
independent module rather than be part of drm module, so separate the phy
driver to an independent module.
Signed-off-by: Chun-Kuang Hu <chunkuang.hu@kernel.org>
---
drivers/gpu/drm/mediatek/Kconfig | 8 ++++++++
drivers/gpu/drm/mediatek/Makefile | 9 ++++++---
drivers/gpu/drm/mediatek/mtk_drm_drv.c | 1 -
drivers/gpu/drm/mediatek/mtk_drm_drv.h | 1 -
drivers/gpu/drm/mediatek/mtk_mipi_tx.c | 3 +++
5 files changed, 17 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/mediatek/Kconfig b/drivers/gpu/drm/mediatek/Kconfig
index 65cd03a4be29..24c4890a6e65 100644
--- a/drivers/gpu/drm/mediatek/Kconfig
+++ b/drivers/gpu/drm/mediatek/Kconfig
@@ -13,6 +13,7 @@ config DRM_MEDIATEK
select DRM_PANEL
select MEMORY
select MTK_SMI
+ select PHY_MTK_MIPI_DSI
select VIDEOMODE_HELPERS
help
Choose this option if you have a Mediatek SoCs.
@@ -27,3 +28,10 @@ config DRM_MEDIATEK_HDMI
select PHY_MTK_HDMI
help
DRM/KMS HDMI driver for Mediatek SoCs
+
+config PHY_MTK_MIPI_DSI
+ tristate "Mediatek MIPI-DSI-PHY Driver"
+ depends on ARCH_MEDIATEK && OF
+ select GENERIC_PHY
+ help
+ Support MIPI DSI PHY for Mediatek SoCs.
diff --git a/drivers/gpu/drm/mediatek/Makefile b/drivers/gpu/drm/mediatek/Makefile
index 77b0fd86063d..baa188000543 100644
--- a/drivers/gpu/drm/mediatek/Makefile
+++ b/drivers/gpu/drm/mediatek/Makefile
@@ -10,9 +10,6 @@ mediatek-drm-y := mtk_disp_color.o \
mtk_drm_gem.o \
mtk_drm_plane.o \
mtk_dsi.o \
- mtk_mipi_tx.o \
- mtk_mt8173_mipi_tx.o \
- mtk_mt8183_mipi_tx.o \
mtk_dpi.o
obj-$(CONFIG_DRM_MEDIATEK) += mediatek-drm.o
@@ -22,3 +19,9 @@ mediatek-drm-hdmi-objs := mtk_cec.o \
mtk_hdmi_ddc.o
obj-$(CONFIG_DRM_MEDIATEK_HDMI) += mediatek-drm-hdmi.o
+
+phy-mtk-mipi-dsi-drv-objs := mtk_mipi_tx.o \
+ mtk_mt8173_mipi_tx.o \
+ mtk_mt8183_mipi_tx.o
+
+obj-$(CONFIG_PHY_MTK_MIPI_DSI) += phy-mtk-mipi-dsi-drv.o
diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.c b/drivers/gpu/drm/mediatek/mtk_drm_drv.c
index 59c85c63b7cc..bad75c5be090 100644
--- a/drivers/gpu/drm/mediatek/mtk_drm_drv.c
+++ b/drivers/gpu/drm/mediatek/mtk_drm_drv.c
@@ -636,7 +636,6 @@ static struct platform_driver * const mtk_drm_drivers[] = {
&mtk_disp_rdma_driver,
&mtk_dpi_driver,
&mtk_drm_platform_driver,
- &mtk_mipi_tx_driver,
&mtk_dsi_driver,
};
diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.h b/drivers/gpu/drm/mediatek/mtk_drm_drv.h
index b5be63e53176..6ff98a68444b 100644
--- a/drivers/gpu/drm/mediatek/mtk_drm_drv.h
+++ b/drivers/gpu/drm/mediatek/mtk_drm_drv.h
@@ -54,6 +54,5 @@ extern struct platform_driver mtk_disp_ovl_driver;
extern struct platform_driver mtk_disp_rdma_driver;
extern struct platform_driver mtk_dpi_driver;
extern struct platform_driver mtk_dsi_driver;
-extern struct platform_driver mtk_mipi_tx_driver;
#endif /* MTK_DRM_DRV_H */
diff --git a/drivers/gpu/drm/mediatek/mtk_mipi_tx.c b/drivers/gpu/drm/mediatek/mtk_mipi_tx.c
index 8cee2591e728..f2a892e16c27 100644
--- a/drivers/gpu/drm/mediatek/mtk_mipi_tx.c
+++ b/drivers/gpu/drm/mediatek/mtk_mipi_tx.c
@@ -242,4 +242,7 @@ struct platform_driver mtk_mipi_tx_driver = {
.of_match_table = mtk_mipi_tx_match,
},
};
+module_platform_driver(mtk_mipi_tx_driver);
+MODULE_DESCRIPTION("MediaTek MIPI TX Driver");
+MODULE_LICENSE("GPL v2");
--
2.17.1
^ permalink raw reply related [flat|nested] 9+ messages in thread* [RESEND PATCH 2/3] phy: mediatek: Move mtk_mipi_dsi_phy driver into drivers/phy/mediatek folder
2020-11-16 23:14 [RESEND PATCH 0/3] Move Mediatek MIPI DSI PHY driver from DRM folder to PHY folder Chun-Kuang Hu
2020-11-16 23:14 ` [RESEND PATCH 1/3] drm/mediatek: Separate mtk_mipi_tx to an independent module Chun-Kuang Hu
@ 2020-11-16 23:14 ` Chun-Kuang Hu
2020-11-17 3:35 ` Chunfeng Yun
2020-11-30 10:34 ` Vinod Koul
2020-11-16 23:14 ` [RESEND PATCH 3/3] MAINTAINERS: add files for Mediatek DRM drivers Chun-Kuang Hu
2 siblings, 2 replies; 9+ messages in thread
From: Chun-Kuang Hu @ 2020-11-16 23:14 UTC (permalink / raw)
To: Philipp Zabel, David Airlie, Daniel Vetter, Matthias Brugger,
Vinod Koul, Chunfeng Yun, Kishon Vijay Abraham I
Cc: linux-kernel, dri-devel, linux-mediatek, Chun-Kuang Hu
mtk_mipi_dsi_phy is currently placed inside mediatek drm driver, but it's
more suitable to place a phy driver into phy driver folder, so move
mtk_mipi_dsi_phy driver into phy driver folder.
Signed-off-by: Chun-Kuang Hu <chunkuang.hu@kernel.org>
---
drivers/gpu/drm/mediatek/Kconfig | 7 -------
drivers/gpu/drm/mediatek/Makefile | 6 ------
drivers/phy/mediatek/Kconfig | 7 +++++++
drivers/phy/mediatek/Makefile | 5 +++++
.../mediatek/phy-mtk-mipi-dsi-mt8173.c} | 2 +-
.../mediatek/phy-mtk-mipi-dsi-mt8183.c} | 2 +-
.../mtk_mipi_tx.c => phy/mediatek/phy-mtk-mipi-dsi.c} | 2 +-
.../mtk_mipi_tx.h => phy/mediatek/phy-mtk-mipi-dsi.h} | 0
8 files changed, 15 insertions(+), 16 deletions(-)
rename drivers/{gpu/drm/mediatek/mtk_mt8173_mipi_tx.c => phy/mediatek/phy-mtk-mipi-dsi-mt8173.c} (99%)
rename drivers/{gpu/drm/mediatek/mtk_mt8183_mipi_tx.c => phy/mediatek/phy-mtk-mipi-dsi-mt8183.c} (99%)
rename drivers/{gpu/drm/mediatek/mtk_mipi_tx.c => phy/mediatek/phy-mtk-mipi-dsi.c} (99%)
rename drivers/{gpu/drm/mediatek/mtk_mipi_tx.h => phy/mediatek/phy-mtk-mipi-dsi.h} (100%)
diff --git a/drivers/gpu/drm/mediatek/Kconfig b/drivers/gpu/drm/mediatek/Kconfig
index 24c4890a6e65..2976d21e9a34 100644
--- a/drivers/gpu/drm/mediatek/Kconfig
+++ b/drivers/gpu/drm/mediatek/Kconfig
@@ -28,10 +28,3 @@ config DRM_MEDIATEK_HDMI
select PHY_MTK_HDMI
help
DRM/KMS HDMI driver for Mediatek SoCs
-
-config PHY_MTK_MIPI_DSI
- tristate "Mediatek MIPI-DSI-PHY Driver"
- depends on ARCH_MEDIATEK && OF
- select GENERIC_PHY
- help
- Support MIPI DSI PHY for Mediatek SoCs.
diff --git a/drivers/gpu/drm/mediatek/Makefile b/drivers/gpu/drm/mediatek/Makefile
index baa188000543..a892edec5563 100644
--- a/drivers/gpu/drm/mediatek/Makefile
+++ b/drivers/gpu/drm/mediatek/Makefile
@@ -19,9 +19,3 @@ mediatek-drm-hdmi-objs := mtk_cec.o \
mtk_hdmi_ddc.o
obj-$(CONFIG_DRM_MEDIATEK_HDMI) += mediatek-drm-hdmi.o
-
-phy-mtk-mipi-dsi-drv-objs := mtk_mipi_tx.o \
- mtk_mt8173_mipi_tx.o \
- mtk_mt8183_mipi_tx.o
-
-obj-$(CONFIG_PHY_MTK_MIPI_DSI) += phy-mtk-mipi-dsi-drv.o
diff --git a/drivers/phy/mediatek/Kconfig b/drivers/phy/mediatek/Kconfig
index 50c5e9306e19..574b8e6398d2 100644
--- a/drivers/phy/mediatek/Kconfig
+++ b/drivers/phy/mediatek/Kconfig
@@ -42,3 +42,10 @@ config PHY_MTK_HDMI
select GENERIC_PHY
help
Support HDMI PHY for Mediatek SoCs.
+
+config PHY_MTK_MIPI_DSI
+ tristate "MediaTek MIPI-DSI Driver"
+ depends on ARCH_MEDIATEK && OF
+ select GENERIC_PHY
+ help
+ Support MIPI DSI for Mediatek SoCs.
diff --git a/drivers/phy/mediatek/Makefile b/drivers/phy/mediatek/Makefile
index 6325e38709ed..ace660fbed3a 100644
--- a/drivers/phy/mediatek/Makefile
+++ b/drivers/phy/mediatek/Makefile
@@ -11,3 +11,8 @@ phy-mtk-hdmi-drv-y := phy-mtk-hdmi.o
phy-mtk-hdmi-drv-y += phy-mtk-hdmi-mt2701.o
phy-mtk-hdmi-drv-y += phy-mtk-hdmi-mt8173.o
obj-$(CONFIG_PHY_MTK_HDMI) += phy-mtk-hdmi-drv.o
+
+phy-mtk-mipi-dsi-drv-y := phy-mtk-mipi-dsi.o
+phy-mtk-mipi-dsi-drv-y += phy-mtk-mipi-dsi-mt8173.o
+phy-mtk-mipi-dsi-drv-y += phy-mtk-mipi-dsi-mt8183.o
+obj-$(CONFIG_PHY_MTK_MIPI_DSI) += phy-mtk-mipi-dsi-drv.o
diff --git a/drivers/gpu/drm/mediatek/mtk_mt8173_mipi_tx.c b/drivers/phy/mediatek/phy-mtk-mipi-dsi-mt8173.c
similarity index 99%
rename from drivers/gpu/drm/mediatek/mtk_mt8173_mipi_tx.c
rename to drivers/phy/mediatek/phy-mtk-mipi-dsi-mt8173.c
index f18db14d8b63..7a847954594f 100644
--- a/drivers/gpu/drm/mediatek/mtk_mt8173_mipi_tx.c
+++ b/drivers/phy/mediatek/phy-mtk-mipi-dsi-mt8173.c
@@ -4,7 +4,7 @@
* Author: jitao.shi <jitao.shi@mediatek.com>
*/
-#include "mtk_mipi_tx.h"
+#include "phy-mtk-mipi-dsi.h"
#define MIPITX_DSI_CON 0x00
#define RG_DSI_LDOCORE_EN BIT(0)
diff --git a/drivers/gpu/drm/mediatek/mtk_mt8183_mipi_tx.c b/drivers/phy/mediatek/phy-mtk-mipi-dsi-mt8183.c
similarity index 99%
rename from drivers/gpu/drm/mediatek/mtk_mt8183_mipi_tx.c
rename to drivers/phy/mediatek/phy-mtk-mipi-dsi-mt8183.c
index 9f3e55aeebb2..99108426d57c 100644
--- a/drivers/gpu/drm/mediatek/mtk_mt8183_mipi_tx.c
+++ b/drivers/phy/mediatek/phy-mtk-mipi-dsi-mt8183.c
@@ -4,7 +4,7 @@
* Author: jitao.shi <jitao.shi@mediatek.com>
*/
-#include "mtk_mipi_tx.h"
+#include "phy-mtk-mipi-dsi.h"
#define MIPITX_LANE_CON 0x000c
#define RG_DSI_CPHY_T1DRV_EN BIT(0)
diff --git a/drivers/gpu/drm/mediatek/mtk_mipi_tx.c b/drivers/phy/mediatek/phy-mtk-mipi-dsi.c
similarity index 99%
rename from drivers/gpu/drm/mediatek/mtk_mipi_tx.c
rename to drivers/phy/mediatek/phy-mtk-mipi-dsi.c
index f2a892e16c27..18c481251f04 100644
--- a/drivers/gpu/drm/mediatek/mtk_mipi_tx.c
+++ b/drivers/phy/mediatek/phy-mtk-mipi-dsi.c
@@ -3,7 +3,7 @@
* Copyright (c) 2015 MediaTek Inc.
*/
-#include "mtk_mipi_tx.h"
+#include "phy-mtk-mipi-dsi.h"
inline struct mtk_mipi_tx *mtk_mipi_tx_from_clk_hw(struct clk_hw *hw)
{
diff --git a/drivers/gpu/drm/mediatek/mtk_mipi_tx.h b/drivers/phy/mediatek/phy-mtk-mipi-dsi.h
similarity index 100%
rename from drivers/gpu/drm/mediatek/mtk_mipi_tx.h
rename to drivers/phy/mediatek/phy-mtk-mipi-dsi.h
--
2.17.1
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [RESEND PATCH 2/3] phy: mediatek: Move mtk_mipi_dsi_phy driver into drivers/phy/mediatek folder
2020-11-16 23:14 ` [RESEND PATCH 2/3] phy: mediatek: Move mtk_mipi_dsi_phy driver into drivers/phy/mediatek folder Chun-Kuang Hu
@ 2020-11-17 3:35 ` Chunfeng Yun
2020-11-17 14:04 ` Chun-Kuang Hu
2020-11-30 10:34 ` Vinod Koul
1 sibling, 1 reply; 9+ messages in thread
From: Chunfeng Yun @ 2020-11-17 3:35 UTC (permalink / raw)
To: Chun-Kuang Hu
Cc: Philipp Zabel, David Airlie, Daniel Vetter, Matthias Brugger,
Vinod Koul, Kishon Vijay Abraham I, linux-kernel, dri-devel,
linux-mediatek
Hi CK,
On Tue, 2020-11-17 at 07:14 +0800, Chun-Kuang Hu wrote:
> mtk_mipi_dsi_phy is currently placed inside mediatek drm driver, but it's
> more suitable to place a phy driver into phy driver folder, so move
> mtk_mipi_dsi_phy driver into phy driver folder.
>
> Signed-off-by: Chun-Kuang Hu <chunkuang.hu@kernel.org>
You forgot to add acked-by me
> ---
> drivers/gpu/drm/mediatek/Kconfig | 7 -------
> drivers/gpu/drm/mediatek/Makefile | 6 ------
> drivers/phy/mediatek/Kconfig | 7 +++++++
> drivers/phy/mediatek/Makefile | 5 +++++
> .../mediatek/phy-mtk-mipi-dsi-mt8173.c} | 2 +-
> .../mediatek/phy-mtk-mipi-dsi-mt8183.c} | 2 +-
> .../mtk_mipi_tx.c => phy/mediatek/phy-mtk-mipi-dsi.c} | 2 +-
> .../mtk_mipi_tx.h => phy/mediatek/phy-mtk-mipi-dsi.h} | 0
> 8 files changed, 15 insertions(+), 16 deletions(-)
> rename drivers/{gpu/drm/mediatek/mtk_mt8173_mipi_tx.c => phy/mediatek/phy-mtk-mipi-dsi-mt8173.c} (99%)
> rename drivers/{gpu/drm/mediatek/mtk_mt8183_mipi_tx.c => phy/mediatek/phy-mtk-mipi-dsi-mt8183.c} (99%)
> rename drivers/{gpu/drm/mediatek/mtk_mipi_tx.c => phy/mediatek/phy-mtk-mipi-dsi.c} (99%)
> rename drivers/{gpu/drm/mediatek/mtk_mipi_tx.h => phy/mediatek/phy-mtk-mipi-dsi.h} (100%)
>
> diff --git a/drivers/gpu/drm/mediatek/Kconfig b/drivers/gpu/drm/mediatek/Kconfig
> index 24c4890a6e65..2976d21e9a34 100644
> --- a/drivers/gpu/drm/mediatek/Kconfig
> +++ b/drivers/gpu/drm/mediatek/Kconfig
> @@ -28,10 +28,3 @@ config DRM_MEDIATEK_HDMI
> select PHY_MTK_HDMI
> help
> DRM/KMS HDMI driver for Mediatek SoCs
> -
> -config PHY_MTK_MIPI_DSI
> - tristate "Mediatek MIPI-DSI-PHY Driver"
> - depends on ARCH_MEDIATEK && OF
> - select GENERIC_PHY
> - help
> - Support MIPI DSI PHY for Mediatek SoCs.
> diff --git a/drivers/gpu/drm/mediatek/Makefile b/drivers/gpu/drm/mediatek/Makefile
> index baa188000543..a892edec5563 100644
> --- a/drivers/gpu/drm/mediatek/Makefile
> +++ b/drivers/gpu/drm/mediatek/Makefile
> @@ -19,9 +19,3 @@ mediatek-drm-hdmi-objs := mtk_cec.o \
> mtk_hdmi_ddc.o
>
> obj-$(CONFIG_DRM_MEDIATEK_HDMI) += mediatek-drm-hdmi.o
> -
> -phy-mtk-mipi-dsi-drv-objs := mtk_mipi_tx.o \
> - mtk_mt8173_mipi_tx.o \
> - mtk_mt8183_mipi_tx.o
> -
> -obj-$(CONFIG_PHY_MTK_MIPI_DSI) += phy-mtk-mipi-dsi-drv.o
> diff --git a/drivers/phy/mediatek/Kconfig b/drivers/phy/mediatek/Kconfig
> index 50c5e9306e19..574b8e6398d2 100644
> --- a/drivers/phy/mediatek/Kconfig
> +++ b/drivers/phy/mediatek/Kconfig
> @@ -42,3 +42,10 @@ config PHY_MTK_HDMI
> select GENERIC_PHY
> help
> Support HDMI PHY for Mediatek SoCs.
> +
> +config PHY_MTK_MIPI_DSI
> + tristate "MediaTek MIPI-DSI Driver"
> + depends on ARCH_MEDIATEK && OF
> + select GENERIC_PHY
> + help
> + Support MIPI DSI for Mediatek SoCs.
> diff --git a/drivers/phy/mediatek/Makefile b/drivers/phy/mediatek/Makefile
> index 6325e38709ed..ace660fbed3a 100644
> --- a/drivers/phy/mediatek/Makefile
> +++ b/drivers/phy/mediatek/Makefile
> @@ -11,3 +11,8 @@ phy-mtk-hdmi-drv-y := phy-mtk-hdmi.o
> phy-mtk-hdmi-drv-y += phy-mtk-hdmi-mt2701.o
> phy-mtk-hdmi-drv-y += phy-mtk-hdmi-mt8173.o
> obj-$(CONFIG_PHY_MTK_HDMI) += phy-mtk-hdmi-drv.o
> +
> +phy-mtk-mipi-dsi-drv-y := phy-mtk-mipi-dsi.o
> +phy-mtk-mipi-dsi-drv-y += phy-mtk-mipi-dsi-mt8173.o
> +phy-mtk-mipi-dsi-drv-y += phy-mtk-mipi-dsi-mt8183.o
> +obj-$(CONFIG_PHY_MTK_MIPI_DSI) += phy-mtk-mipi-dsi-drv.o
> diff --git a/drivers/gpu/drm/mediatek/mtk_mt8173_mipi_tx.c b/drivers/phy/mediatek/phy-mtk-mipi-dsi-mt8173.c
> similarity index 99%
> rename from drivers/gpu/drm/mediatek/mtk_mt8173_mipi_tx.c
> rename to drivers/phy/mediatek/phy-mtk-mipi-dsi-mt8173.c
> index f18db14d8b63..7a847954594f 100644
> --- a/drivers/gpu/drm/mediatek/mtk_mt8173_mipi_tx.c
> +++ b/drivers/phy/mediatek/phy-mtk-mipi-dsi-mt8173.c
> @@ -4,7 +4,7 @@
> * Author: jitao.shi <jitao.shi@mediatek.com>
> */
>
> -#include "mtk_mipi_tx.h"
> +#include "phy-mtk-mipi-dsi.h"
>
> #define MIPITX_DSI_CON 0x00
> #define RG_DSI_LDOCORE_EN BIT(0)
> diff --git a/drivers/gpu/drm/mediatek/mtk_mt8183_mipi_tx.c b/drivers/phy/mediatek/phy-mtk-mipi-dsi-mt8183.c
> similarity index 99%
> rename from drivers/gpu/drm/mediatek/mtk_mt8183_mipi_tx.c
> rename to drivers/phy/mediatek/phy-mtk-mipi-dsi-mt8183.c
> index 9f3e55aeebb2..99108426d57c 100644
> --- a/drivers/gpu/drm/mediatek/mtk_mt8183_mipi_tx.c
> +++ b/drivers/phy/mediatek/phy-mtk-mipi-dsi-mt8183.c
> @@ -4,7 +4,7 @@
> * Author: jitao.shi <jitao.shi@mediatek.com>
> */
>
> -#include "mtk_mipi_tx.h"
> +#include "phy-mtk-mipi-dsi.h"
>
> #define MIPITX_LANE_CON 0x000c
> #define RG_DSI_CPHY_T1DRV_EN BIT(0)
> diff --git a/drivers/gpu/drm/mediatek/mtk_mipi_tx.c b/drivers/phy/mediatek/phy-mtk-mipi-dsi.c
> similarity index 99%
> rename from drivers/gpu/drm/mediatek/mtk_mipi_tx.c
> rename to drivers/phy/mediatek/phy-mtk-mipi-dsi.c
> index f2a892e16c27..18c481251f04 100644
> --- a/drivers/gpu/drm/mediatek/mtk_mipi_tx.c
> +++ b/drivers/phy/mediatek/phy-mtk-mipi-dsi.c
> @@ -3,7 +3,7 @@
> * Copyright (c) 2015 MediaTek Inc.
> */
>
> -#include "mtk_mipi_tx.h"
> +#include "phy-mtk-mipi-dsi.h"
>
> inline struct mtk_mipi_tx *mtk_mipi_tx_from_clk_hw(struct clk_hw *hw)
> {
> diff --git a/drivers/gpu/drm/mediatek/mtk_mipi_tx.h b/drivers/phy/mediatek/phy-mtk-mipi-dsi.h
> similarity index 100%
> rename from drivers/gpu/drm/mediatek/mtk_mipi_tx.h
> rename to drivers/phy/mediatek/phy-mtk-mipi-dsi.h
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [RESEND PATCH 2/3] phy: mediatek: Move mtk_mipi_dsi_phy driver into drivers/phy/mediatek folder
2020-11-17 3:35 ` Chunfeng Yun
@ 2020-11-17 14:04 ` Chun-Kuang Hu
0 siblings, 0 replies; 9+ messages in thread
From: Chun-Kuang Hu @ 2020-11-17 14:04 UTC (permalink / raw)
To: Chunfeng Yun
Cc: Chun-Kuang Hu, Philipp Zabel, David Airlie, Daniel Vetter,
Matthias Brugger, Vinod Koul, Kishon Vijay Abraham I,
linux-kernel, DRI Development,
moderated list:ARM/Mediatek SoC support
Hi, Vinod:
Chunfeng Yun <chunfeng.yun@mediatek.com> 於 2020年11月17日 週二 上午11:36寫道：
>
> Hi CK,
> On Tue, 2020-11-17 at 07:14 +0800, Chun-Kuang Hu wrote:
> > mtk_mipi_dsi_phy is currently placed inside mediatek drm driver, but it's
> > more suitable to place a phy driver into phy driver folder, so move
> > mtk_mipi_dsi_phy driver into phy driver folder.
> >
> > Signed-off-by: Chun-Kuang Hu <chunkuang.hu@kernel.org>
> You forgot to add acked-by me
If you apply this patch, please add acked-by tag of chunfeng [1], thanks.
[1] https://patchwork.kernel.org/project/linux-mediatek/patch/20201029152702.533-3-chunkuang.hu@kernel.org/
Regards,
Chun-Kuang.
>
> > ---
> > drivers/gpu/drm/mediatek/Kconfig | 7 -------
> > drivers/gpu/drm/mediatek/Makefile | 6 ------
> > drivers/phy/mediatek/Kconfig | 7 +++++++
> > drivers/phy/mediatek/Makefile | 5 +++++
> > .../mediatek/phy-mtk-mipi-dsi-mt8173.c} | 2 +-
> > .../mediatek/phy-mtk-mipi-dsi-mt8183.c} | 2 +-
> > .../mtk_mipi_tx.c => phy/mediatek/phy-mtk-mipi-dsi.c} | 2 +-
> > .../mtk_mipi_tx.h => phy/mediatek/phy-mtk-mipi-dsi.h} | 0
> > 8 files changed, 15 insertions(+), 16 deletions(-)
> > rename drivers/{gpu/drm/mediatek/mtk_mt8173_mipi_tx.c => phy/mediatek/phy-mtk-mipi-dsi-mt8173.c} (99%)
> > rename drivers/{gpu/drm/mediatek/mtk_mt8183_mipi_tx.c => phy/mediatek/phy-mtk-mipi-dsi-mt8183.c} (99%)
> > rename drivers/{gpu/drm/mediatek/mtk_mipi_tx.c => phy/mediatek/phy-mtk-mipi-dsi.c} (99%)
> > rename drivers/{gpu/drm/mediatek/mtk_mipi_tx.h => phy/mediatek/phy-mtk-mipi-dsi.h} (100%)
> >
> > diff --git a/drivers/gpu/drm/mediatek/Kconfig b/drivers/gpu/drm/mediatek/Kconfig
> > index 24c4890a6e65..2976d21e9a34 100644
> > --- a/drivers/gpu/drm/mediatek/Kconfig
> > +++ b/drivers/gpu/drm/mediatek/Kconfig
> > @@ -28,10 +28,3 @@ config DRM_MEDIATEK_HDMI
> > select PHY_MTK_HDMI
> > help
> > DRM/KMS HDMI driver for Mediatek SoCs
> > -
> > -config PHY_MTK_MIPI_DSI
> > - tristate "Mediatek MIPI-DSI-PHY Driver"
> > - depends on ARCH_MEDIATEK && OF
> > - select GENERIC_PHY
> > - help
> > - Support MIPI DSI PHY for Mediatek SoCs.
> > diff --git a/drivers/gpu/drm/mediatek/Makefile b/drivers/gpu/drm/mediatek/Makefile
> > index baa188000543..a892edec5563 100644
> > --- a/drivers/gpu/drm/mediatek/Makefile
> > +++ b/drivers/gpu/drm/mediatek/Makefile
> > @@ -19,9 +19,3 @@ mediatek-drm-hdmi-objs := mtk_cec.o \
> > mtk_hdmi_ddc.o
> >
> > obj-$(CONFIG_DRM_MEDIATEK_HDMI) += mediatek-drm-hdmi.o
> > -
> > -phy-mtk-mipi-dsi-drv-objs := mtk_mipi_tx.o \
> > - mtk_mt8173_mipi_tx.o \
> > - mtk_mt8183_mipi_tx.o
> > -
> > -obj-$(CONFIG_PHY_MTK_MIPI_DSI) += phy-mtk-mipi-dsi-drv.o
> > diff --git a/drivers/phy/mediatek/Kconfig b/drivers/phy/mediatek/Kconfig
> > index 50c5e9306e19..574b8e6398d2 100644
> > --- a/drivers/phy/mediatek/Kconfig
> > +++ b/drivers/phy/mediatek/Kconfig
> > @@ -42,3 +42,10 @@ config PHY_MTK_HDMI
> > select GENERIC_PHY
> > help
> > Support HDMI PHY for Mediatek SoCs.
> > +
> > +config PHY_MTK_MIPI_DSI
> > + tristate "MediaTek MIPI-DSI Driver"
> > + depends on ARCH_MEDIATEK && OF
> > + select GENERIC_PHY
> > + help
> > + Support MIPI DSI for Mediatek SoCs.
> > diff --git a/drivers/phy/mediatek/Makefile b/drivers/phy/mediatek/Makefile
> > index 6325e38709ed..ace660fbed3a 100644
> > --- a/drivers/phy/mediatek/Makefile
> > +++ b/drivers/phy/mediatek/Makefile
> > @@ -11,3 +11,8 @@ phy-mtk-hdmi-drv-y := phy-mtk-hdmi.o
> > phy-mtk-hdmi-drv-y += phy-mtk-hdmi-mt2701.o
> > phy-mtk-hdmi-drv-y += phy-mtk-hdmi-mt8173.o
> > obj-$(CONFIG_PHY_MTK_HDMI) += phy-mtk-hdmi-drv.o
> > +
> > +phy-mtk-mipi-dsi-drv-y := phy-mtk-mipi-dsi.o
> > +phy-mtk-mipi-dsi-drv-y += phy-mtk-mipi-dsi-mt8173.o
> > +phy-mtk-mipi-dsi-drv-y += phy-mtk-mipi-dsi-mt8183.o
> > +obj-$(CONFIG_PHY_MTK_MIPI_DSI) += phy-mtk-mipi-dsi-drv.o
> > diff --git a/drivers/gpu/drm/mediatek/mtk_mt8173_mipi_tx.c b/drivers/phy/mediatek/phy-mtk-mipi-dsi-mt8173.c
> > similarity index 99%
> > rename from drivers/gpu/drm/mediatek/mtk_mt8173_mipi_tx.c
> > rename to drivers/phy/mediatek/phy-mtk-mipi-dsi-mt8173.c
> > index f18db14d8b63..7a847954594f 100644
> > --- a/drivers/gpu/drm/mediatek/mtk_mt8173_mipi_tx.c
> > +++ b/drivers/phy/mediatek/phy-mtk-mipi-dsi-mt8173.c
> > @@ -4,7 +4,7 @@
> > * Author: jitao.shi <jitao.shi@mediatek.com>
> > */
> >
> > -#include "mtk_mipi_tx.h"
> > +#include "phy-mtk-mipi-dsi.h"
> >
> > #define MIPITX_DSI_CON 0x00
> > #define RG_DSI_LDOCORE_EN BIT(0)
> > diff --git a/drivers/gpu/drm/mediatek/mtk_mt8183_mipi_tx.c b/drivers/phy/mediatek/phy-mtk-mipi-dsi-mt8183.c
> > similarity index 99%
> > rename from drivers/gpu/drm/mediatek/mtk_mt8183_mipi_tx.c
> > rename to drivers/phy/mediatek/phy-mtk-mipi-dsi-mt8183.c
> > index 9f3e55aeebb2..99108426d57c 100644
> > --- a/drivers/gpu/drm/mediatek/mtk_mt8183_mipi_tx.c
> > +++ b/drivers/phy/mediatek/phy-mtk-mipi-dsi-mt8183.c
> > @@ -4,7 +4,7 @@
> > * Author: jitao.shi <jitao.shi@mediatek.com>
> > */
> >
> > -#include "mtk_mipi_tx.h"
> > +#include "phy-mtk-mipi-dsi.h"
> >
> > #define MIPITX_LANE_CON 0x000c
> > #define RG_DSI_CPHY_T1DRV_EN BIT(0)
> > diff --git a/drivers/gpu/drm/mediatek/mtk_mipi_tx.c b/drivers/phy/mediatek/phy-mtk-mipi-dsi.c
> > similarity index 99%
> > rename from drivers/gpu/drm/mediatek/mtk_mipi_tx.c
> > rename to drivers/phy/mediatek/phy-mtk-mipi-dsi.c
> > index f2a892e16c27..18c481251f04 100644
> > --- a/drivers/gpu/drm/mediatek/mtk_mipi_tx.c
> > +++ b/drivers/phy/mediatek/phy-mtk-mipi-dsi.c
> > @@ -3,7 +3,7 @@
> > * Copyright (c) 2015 MediaTek Inc.
> > */
> >
> > -#include "mtk_mipi_tx.h"
> > +#include "phy-mtk-mipi-dsi.h"
> >
> > inline struct mtk_mipi_tx *mtk_mipi_tx_from_clk_hw(struct clk_hw *hw)
> > {
> > diff --git a/drivers/gpu/drm/mediatek/mtk_mipi_tx.h b/drivers/phy/mediatek/phy-mtk-mipi-dsi.h
> > similarity index 100%
> > rename from drivers/gpu/drm/mediatek/mtk_mipi_tx.h
> > rename to drivers/phy/mediatek/phy-mtk-mipi-dsi.h
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [RESEND PATCH 2/3] phy: mediatek: Move mtk_mipi_dsi_phy driver into drivers/phy/mediatek folder
2020-11-16 23:14 ` [RESEND PATCH 2/3] phy: mediatek: Move mtk_mipi_dsi_phy driver into drivers/phy/mediatek folder Chun-Kuang Hu
2020-11-17 3:35 ` Chunfeng Yun
@ 2020-11-30 10:34 ` Vinod Koul
2020-12-01 14:30 ` Chun-Kuang Hu
1 sibling, 1 reply; 9+ messages in thread
From: Vinod Koul @ 2020-11-30 10:34 UTC (permalink / raw)
To: Chun-Kuang Hu
Cc: Philipp Zabel, David Airlie, Daniel Vetter, Matthias Brugger,
Chunfeng Yun, Kishon Vijay Abraham I, linux-kernel, dri-devel,
linux-mediatek
On 17-11-20, 07:14, Chun-Kuang Hu wrote:
> mtk_mipi_dsi_phy is currently placed inside mediatek drm driver, but it's
> more suitable to place a phy driver into phy driver folder, so move
> mtk_mipi_dsi_phy driver into phy driver folder.
Acked-By: Vinod Koul <vkoul@kernel.org>
I am thinking this would go thru drm-tree, if not let me know I would
apply this
--
~Vinod
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [RESEND PATCH 2/3] phy: mediatek: Move mtk_mipi_dsi_phy driver into drivers/phy/mediatek folder
2020-11-30 10:34 ` Vinod Koul
@ 2020-12-01 14:30 ` Chun-Kuang Hu
0 siblings, 0 replies; 9+ messages in thread
From: Chun-Kuang Hu @ 2020-12-01 14:30 UTC (permalink / raw)
To: Vinod Koul
Cc: Chun-Kuang Hu, Philipp Zabel, David Airlie, Daniel Vetter,
Matthias Brugger, Chunfeng Yun, Kishon Vijay Abraham I,
linux-kernel, DRI Development,
moderated list:ARM/Mediatek SoC support
Hi, Vinod:
Vinod Koul <vkoul@kernel.org> 於 2020年11月30日 週一 下午6:34寫道：
>
> On 17-11-20, 07:14, Chun-Kuang Hu wrote:
> > mtk_mipi_dsi_phy is currently placed inside mediatek drm driver, but it's
> > more suitable to place a phy driver into phy driver folder, so move
> > mtk_mipi_dsi_phy driver into phy driver folder.
>
> Acked-By: Vinod Koul <vkoul@kernel.org>
>
> I am thinking this would go thru drm-tree, if not let me know I would
> apply this
Applied to mediatek-drm-next [1], thanks.
[1] https://git.kernel.org/pub/scm/linux/kernel/git/chunkuang.hu/linux.git/log/?h=mediatek-drm-next
Regards,
Chun-Kuang.
>
> --
> ~Vinod
^ permalink raw reply [flat|nested] 9+ messages in thread
* [RESEND PATCH 3/3] MAINTAINERS: add files for Mediatek DRM drivers
2020-11-16 23:14 [RESEND PATCH 0/3] Move Mediatek MIPI DSI PHY driver from DRM folder to PHY folder Chun-Kuang Hu
2020-11-16 23:14 ` [RESEND PATCH 1/3] drm/mediatek: Separate mtk_mipi_tx to an independent module Chun-Kuang Hu
2020-11-16 23:14 ` [RESEND PATCH 2/3] phy: mediatek: Move mtk_mipi_dsi_phy driver into drivers/phy/mediatek folder Chun-Kuang Hu
@ 2020-11-16 23:14 ` Chun-Kuang Hu
2020-11-17 14:05 ` Chun-Kuang Hu
2 siblings, 1 reply; 9+ messages in thread
From: Chun-Kuang Hu @ 2020-11-16 23:14 UTC (permalink / raw)
To: Philipp Zabel, David Airlie, Daniel Vetter, Matthias Brugger,
Vinod Koul, Chunfeng Yun, Kishon Vijay Abraham I
Cc: linux-kernel, dri-devel, linux-mediatek, Chun-Kuang Hu
Mediatek MIPI DSI phy driver is moved from drivers/gpu/drm/mediatek to
drivers/phy/mediatek, so add the new folder to the Mediatek DRM drivers'
information.
Signed-off-by: Chun-Kuang Hu <chunkuang.hu@kernel.org>
---
MAINTAINERS | 1 +
1 file changed, 1 insertion(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index e73636b75f29..14f5018c01b6 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -5867,6 +5867,7 @@ S: Supported
F: Documentation/devicetree/bindings/display/mediatek/
F: drivers/gpu/drm/mediatek/
F: drivers/phy/mediatek/phy-mtk-hdmi*
+F: drivers/phy/mediatek/phy-mtk-mipi*
DRM DRIVERS FOR NVIDIA TEGRA
M: Thierry Reding <thierry.reding@gmail.com>
--
2.17.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [RESEND PATCH 3/3] MAINTAINERS: add files for Mediatek DRM drivers
2020-11-16 23:14 ` [RESEND PATCH 3/3] MAINTAINERS: add files for Mediatek DRM drivers Chun-Kuang Hu
@ 2020-11-17 14:05 ` Chun-Kuang Hu
0 siblings, 0 replies; 9+ messages in thread
From: Chun-Kuang Hu @ 2020-11-17 14:05 UTC (permalink / raw)
To: Chun-Kuang Hu
Cc: Philipp Zabel, David Airlie, Daniel Vetter, Matthias Brugger,
Vinod Koul, Chunfeng Yun, Kishon Vijay Abraham I, linux-kernel,
DRI Development, moderated list:ARM/Mediatek SoC support
Hi, Vinod:
Chun-Kuang Hu <chunkuang.hu@kernel.org> 於 2020年11月17日 週二 上午7:14寫道：
>
> Mediatek MIPI DSI phy driver is moved from drivers/gpu/drm/mediatek to
> drivers/phy/mediatek, so add the new folder to the Mediatek DRM drivers'
> information.
>
> Signed-off-by: Chun-Kuang Hu <chunkuang.hu@kernel.org>
If you apply this patch, please add acked-by tag of chunfeng [1], thanks.
[1] https://patchwork.kernel.org/project/linux-mediatek/patch/20201029152702.533-4-chunkuang.hu@kernel.org/
Regards,
Chun-Kuang.
> ---
> MAINTAINERS | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index e73636b75f29..14f5018c01b6 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -5867,6 +5867,7 @@ S: Supported
> F: Documentation/devicetree/bindings/display/mediatek/
> F: drivers/gpu/drm/mediatek/
> F: drivers/phy/mediatek/phy-mtk-hdmi*
> +F: drivers/phy/mediatek/phy-mtk-mipi*
>
> DRM DRIVERS FOR NVIDIA TEGRA
> M: Thierry Reding <thierry.reding@gmail.com>
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 9+ messages in thread