linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] drivers/perf: Enable PID_IN_CONTEXTIDR with SPE
@ 2020-11-30 16:24 James Clark
  2020-11-30 16:46 ` Will Deacon
  0 siblings, 1 reply; 8+ messages in thread
From: James Clark @ 2020-11-30 16:24 UTC (permalink / raw)
  To: linux-arm-kernel, linux-kernel, linux-perf-users
  Cc: James Clark, Will Deacon, Mark Rutland, Al Grant, Leo Yan,
	John Garry, Suzuki K Poulose

Enable PID_IN_CONTEXTIDR by default when Arm SPE is enabled.
This flag is required to get PID data in the SPE trace. Without
it the perf tool will report 0 for PID which isn't very useful,
especially when doing system wide profiling or profiling
applications that fork.

There is a small performance overhead when enabling
PID_IN_CONTEXTIDR, but SPE itself is optional and not enabled by
default so the impact is minimised.

Cc: Will Deacon <will@kernel.org>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Al Grant <al.grant@arm.com>
Cc: Leo Yan <leo.yan@linaro.org>
Cc: John Garry <john.garry@huawei.com>
Cc: Suzuki K Poulose <suzuki.poulose@arm.com>
Signed-off-by: James Clark <james.clark@arm.com>
---
 drivers/perf/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/perf/Kconfig b/drivers/perf/Kconfig
index 130327ff0b0e..47ede46c3d57 100644
--- a/drivers/perf/Kconfig
+++ b/drivers/perf/Kconfig
@@ -125,6 +125,7 @@ config XGENE_PMU
 config ARM_SPE_PMU
 	tristate "Enable support for the ARMv8.2 Statistical Profiling Extension"
 	depends on ARM64
+	select PID_IN_CONTEXTIDR
 	help
 	  Enable perf support for the ARMv8.2 Statistical Profiling
 	  Extension, which provides periodic sampling of operations in
-- 
2.28.0


^ permalink raw reply related	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2020-12-14  8:52 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-30 16:24 [PATCH] drivers/perf: Enable PID_IN_CONTEXTIDR with SPE James Clark
2020-11-30 16:46 ` Will Deacon
2020-12-01  4:10   ` Leo Yan
2020-12-01 23:09     ` Will Deacon
2020-12-03  6:39       ` Leo Yan
2020-12-03  6:41         ` Leo Yan
2020-12-04  0:07         ` Mathieu Poirier
2020-12-14  8:51       ` James Clark

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).