From: Rob Herring <robh@kernel.org>
To: Bongsu jeon <bongsu.jeon2@gmail.com>
Cc: krzk@kernel.org, linux-nfc@lists.01.org, netdev@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Bongsu Jeon <bongsu.jeon@samsung.com>
Subject: Re: [PATCH v2 net-next 1/4] dt-bindings: net: nfc: s3fwrn5: Support a UART interface
Date: Mon, 30 Nov 2020 10:39:08 -0700 [thread overview]
Message-ID: <20201130173908.GC2684526@robh.at.kernel.org> (raw)
In-Reply-To: <1606737627-29485-1-git-send-email-bongsu.jeon@samsung.com>
On Mon, Nov 30, 2020 at 09:00:27PM +0900, Bongsu jeon wrote:
> From: Bongsu Jeon <bongsu.jeon@samsung.com>
>
> Since S3FWRN82 NFC Chip, The UART interface can be used.
> S3FWRN82 supports I2C and UART interface.
>
> Signed-off-by: Bongsu Jeon <bongsu.jeon@samsung.com>
> ---
>
> Changes in v2:
> -change the compatible name.
> -change the const to enum for compatible.
> -change the node name to nfc.
>
> .../bindings/net/nfc/samsung,s3fwrn5.yaml | 32 ++++++++++++++++++++--
> 1 file changed, 29 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/net/nfc/samsung,s3fwrn5.yaml b/Documentation/devicetree/bindings/net/nfc/samsung,s3fwrn5.yaml
> index cb0b8a5..481bbcc 100644
> --- a/Documentation/devicetree/bindings/net/nfc/samsung,s3fwrn5.yaml
> +++ b/Documentation/devicetree/bindings/net/nfc/samsung,s3fwrn5.yaml
> @@ -12,7 +12,10 @@ maintainers:
>
> properties:
> compatible:
> - const: samsung,s3fwrn5-i2c
> + oneOf:
Don't need 'oneOf' here.
> + - enum:
> + - samsung,s3fwrn5-i2c
> + - samsung,s3fwrn82
>
> en-gpios:
> maxItems: 1
> @@ -47,10 +50,19 @@ additionalProperties: false
> required:
> - compatible
> - en-gpios
> - - interrupts
> - - reg
> - wake-gpios
>
> +allOf:
> + - if:
> + properties:
> + compatible:
> + contains:
> + const: samsung,s3fwrn5-i2c
> + then:
> + required:
> + - interrupts
> + - reg
> +
> examples:
> - |
> #include <dt-bindings/gpio/gpio.h>
> @@ -71,3 +83,17 @@ examples:
> wake-gpios = <&gpj0 2 GPIO_ACTIVE_HIGH>;
> };
> };
> + # UART example on Raspberry Pi
> + - |
> + uart0 {
> + status = "okay";
> +
> + nfc {
> + compatible = "samsung,s3fwrn82";
> +
> + en-gpios = <&gpio 20 0>;
> + wake-gpios = <&gpio 16 0>;
> +
> + status = "okay";
> + };
> + };
> --
> 1.9.1
>
prev parent reply other threads:[~2020-11-30 17:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-30 12:00 [PATCH v2 net-next 1/4] dt-bindings: net: nfc: s3fwrn5: Support a UART interface Bongsu jeon
2020-11-30 16:55 ` Jakub Kicinski
2020-11-30 18:29 ` Krzysztof Kozlowski
2020-11-30 17:37 ` Rob Herring
2020-11-30 17:39 ` Rob Herring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201130173908.GC2684526@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=bongsu.jeon2@gmail.com \
--cc=bongsu.jeon@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=krzk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfc@lists.01.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).