linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 1/1] arm64: dts: allwinner: H5: NanoPi Neo Plus2: phy-mode rgmii-id
@ 2020-11-29 19:45 Heinrich Schuchardt
  2020-11-29 20:57 ` Andrew Lunn
  2020-12-01 10:33 ` Maxime Ripard
  0 siblings, 2 replies; 3+ messages in thread
From: Heinrich Schuchardt @ 2020-11-29 19:45 UTC (permalink / raw)
  To: Rob Herring, Maxime Ripard
  Cc: Chen-Yu Tsai, Willy Liu, David S . Miller, devicetree,
	linux-arm-kernel, linux-kernel, Heinrich Schuchardt

Since commit bbc4d71d6354 ("net: phy: realtek: fix rtl8211e rx/tx
delay config") network is broken on the NanoPi Neo Plus2.

This patch changes the phy-mode to use internal delays both for RX and TX
as has been done for other boards affected by the same commit.

Fixes: bbc4d71d6354 ("net: phy: realtek: fix rtl8211e rx/tx delay config")
Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
---
 arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-neo-plus2.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-neo-plus2.dts b/arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-neo-plus2.dts
index 4f9ba53ffaae..9d93fe153689 100644
--- a/arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-neo-plus2.dts
+++ b/arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-neo-plus2.dts
@@ -96,7 +96,7 @@ &emac {
 	pinctrl-0 = <&emac_rgmii_pins>;
 	phy-supply = <&reg_gmac_3v3>;
 	phy-handle = <&ext_rgmii_phy>;
-	phy-mode = "rgmii";
+	phy-mode = "rgmii-id";
 	status = "okay";
 };

--
2.29.2


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH 1/1] arm64: dts: allwinner: H5: NanoPi Neo Plus2: phy-mode rgmii-id
  2020-11-29 19:45 [PATCH 1/1] arm64: dts: allwinner: H5: NanoPi Neo Plus2: phy-mode rgmii-id Heinrich Schuchardt
@ 2020-11-29 20:57 ` Andrew Lunn
  2020-12-01 10:33 ` Maxime Ripard
  1 sibling, 0 replies; 3+ messages in thread
From: Andrew Lunn @ 2020-11-29 20:57 UTC (permalink / raw)
  To: Heinrich Schuchardt
  Cc: Rob Herring, Maxime Ripard, devicetree, linux-kernel, Willy Liu,
	Chen-Yu Tsai, David S . Miller, linux-arm-kernel

On Sun, Nov 29, 2020 at 08:45:12PM +0100, Heinrich Schuchardt wrote:
> Since commit bbc4d71d6354 ("net: phy: realtek: fix rtl8211e rx/tx
> delay config") network is broken on the NanoPi Neo Plus2.
> 
> This patch changes the phy-mode to use internal delays both for RX and TX
> as has been done for other boards affected by the same commit.
> 
> Fixes: bbc4d71d6354 ("net: phy: realtek: fix rtl8211e rx/tx delay config")
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH 1/1] arm64: dts: allwinner: H5: NanoPi Neo Plus2: phy-mode rgmii-id
  2020-11-29 19:45 [PATCH 1/1] arm64: dts: allwinner: H5: NanoPi Neo Plus2: phy-mode rgmii-id Heinrich Schuchardt
  2020-11-29 20:57 ` Andrew Lunn
@ 2020-12-01 10:33 ` Maxime Ripard
  1 sibling, 0 replies; 3+ messages in thread
From: Maxime Ripard @ 2020-12-01 10:33 UTC (permalink / raw)
  To: Heinrich Schuchardt
  Cc: Rob Herring, Chen-Yu Tsai, Willy Liu, David S . Miller,
	devicetree, linux-arm-kernel, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 516 bytes --]

On Sun, Nov 29, 2020 at 08:45:12PM +0100, Heinrich Schuchardt wrote:
> Since commit bbc4d71d6354 ("net: phy: realtek: fix rtl8211e rx/tx
> delay config") network is broken on the NanoPi Neo Plus2.
> 
> This patch changes the phy-mode to use internal delays both for RX and TX
> as has been done for other boards affected by the same commit.
> 
> Fixes: bbc4d71d6354 ("net: phy: realtek: fix rtl8211e rx/tx delay config")
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>

Applied, thanks!
Maxime

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-12-01 10:35 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-29 19:45 [PATCH 1/1] arm64: dts: allwinner: H5: NanoPi Neo Plus2: phy-mode rgmii-id Heinrich Schuchardt
2020-11-29 20:57 ` Andrew Lunn
2020-12-01 10:33 ` Maxime Ripard

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).